From: zhuyinbo <zhuyinbo@loongson.cn>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
loongson-kernel@lists.loongnix.cn, zhuyinbo@loongson.cn
Subject: Re: [PATCH v12 2/2] spi: loongson: add bus driver for the loongson spi controller
Date: Fri, 9 Jun 2023 15:13:18 +0800 [thread overview]
Message-ID: <dc360396-de35-0eb7-3073-75deeb2d762c@loongson.cn> (raw)
In-Reply-To: <CAHp75VfUg6wq1xSpGsQFQpYbK+tkA3NJBCjBMte6sB7fQBBvrw@mail.gmail.com>
在 2023/6/8 下午6:18, Andy Shevchenko 写道:
> On Thu, Jun 8, 2023 at 1:15 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Thu, Jun 8, 2023 at 10:28 AM Yinbo Zhu <zhuyinbo@loongson.cn> wrote:
>>> + ret = readb_poll_timeout(loongson_spi->base + LOONGSON_SPI_SPSR_REG, loongson_spi->spsr,
>>> + (loongson_spi->spsr & 0x1) != LOONGSON_SPI_SPSR_RFEMPTY, 1, MSEC_PER_SEC);
>>
>> (loongson_spi->spsr &
>> LOONGSON_SPI_SPSR_RFEMPTY) != LOONGSON_SPI_SPSR_RFEMPTY,
>> 1, MSEC_PER_SEC);
>
> Actually the last should be USEC_PER_MSEC, as the parameter is in microseconds.
okay, I got it.
Thanks
>
next prev parent reply other threads:[~2023-06-09 7:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 7:28 [PATCH v12 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-06-08 7:28 ` [PATCH v12 1/2] spi: add loongson spi bindings Yinbo Zhu
2023-06-08 7:45 ` Krzysztof Kozlowski
2023-06-08 8:39 ` zhuyinbo
2023-06-08 8:53 ` Krzysztof Kozlowski
2023-06-08 10:00 ` zhuyinbo
2023-06-08 10:02 ` Krzysztof Kozlowski
2023-06-08 11:42 ` zhuyinbo
2023-06-08 11:45 ` Krzysztof Kozlowski
2023-06-08 12:10 ` zhuyinbo
2023-06-08 13:26 ` Krzysztof Kozlowski
2023-06-09 3:13 ` zhuyinbo
2023-06-09 16:45 ` Krzysztof Kozlowski
2023-06-12 7:13 ` zhuyinbo
2023-06-12 7:17 ` Krzysztof Kozlowski
2023-06-12 7:40 ` zhuyinbo
2023-06-12 8:16 ` Krzysztof Kozlowski
2023-06-12 11:29 ` zhuyinbo
2023-06-12 18:03 ` Krzysztof Kozlowski
2023-06-13 2:04 ` zhuyinbo
2023-06-08 7:28 ` [PATCH v12 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-06-08 10:15 ` Andy Shevchenko
2023-06-08 10:18 ` Andy Shevchenko
2023-06-09 7:13 ` zhuyinbo [this message]
2023-06-08 10:29 ` Mark Brown
2023-06-08 11:45 ` zhuyinbo
2023-06-08 11:53 ` Mark Brown
2023-06-09 3:17 ` zhuyinbo
2023-06-09 7:10 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc360396-de35-0eb7-3073-75deeb2d762c@loongson.cn \
--to=zhuyinbo@loongson.cn \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=wanghongliang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®