From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 020AEC433DB for ; Tue, 23 Mar 2021 09:46:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C932A619C0 for ; Tue, 23 Mar 2021 09:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230230AbhCWJps (ORCPT ); Tue, 23 Mar 2021 05:45:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230229AbhCWJpX (ORCPT ); Tue, 23 Mar 2021 05:45:23 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45314C061756; Tue, 23 Mar 2021 02:45:23 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id z25so24735191lja.3; Tue, 23 Mar 2021 02:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uzZS3gbuouaMb0aQwKUk+wnYNoHawdjGYDJEn+Ti01E=; b=CuMYxk9uua2EDFqkfdK0Apjwmd1wXAWoekdTgXV9zgxk8CIPZNvSZmTRC5rzD8vRF8 Y4RaU/csADxzOMkK0iTCfjP2Hge4U7sVREuftSAvjeVv16p37mQu0DE0ybOVhTh5WPUz 6ONeLy0gAcnTd66kT8S+DqJMZjJj7qdOcOv9Kd9ofDUM/7iJ9JMl53+3D6LzJU/Lldiz 3VeOcGjKkVzCNVmqWqMjb8VeuFL36oJuWo7P3vegKe4ZIszPeJUwNbT/vnxAnpAZ4AFZ Jvdk1B4yI0bKknFRUSShq+c1Wvg8P1VJ2hhPtexJUJZEJ4j78X0Lb4+80Xz+ppvT/gzu I+Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=uzZS3gbuouaMb0aQwKUk+wnYNoHawdjGYDJEn+Ti01E=; b=sRRl8hfterDVNbzGAAUFXwGVMXKPdQvvkElyMF6EITgelR6DHvNQF0oZaoyNcudxzW o0aPcNmmUEdUnGHvMjb7OqKkIjYOa5YQvfTO7Ccy19KaWE6XoDh9YFGqsmdV7rfh0CKG D6/HE/EbuqmGmojRvG2hZeyWYPPaNwQutU50TcPiS0AbhijVMLjwMgG0BeSb8GM6AwAS CAFqYO3UXYqpZniNEa5pU4QcL5ZGDB4VF56WYdAQrrk+y7nqbP8Bvx37Em2QJ4rDSBxD 9ntmpnWVa2utXm7GIyr8DDlskXfjNlJmDBTHeMQw7OxoRPRumVXNQBROLuCv5mitYncw Fg1A== X-Gm-Message-State: AOAM530KiB6iIYGSnk3VYQmnPgdcQQUMYJiZzsAmMLr45LQpYAdVgncR oKISMZMY24JnzKF5c3ZLfho= X-Google-Smtp-Source: ABdhPJx+jkwGhKp9ObWDXaNpkj/W9ElDHuF8ny9OFN3+0UAmgX1evbxBuAjAQBqkCSkyuKwuzCkcvg== X-Received: by 2002:a2e:9c8e:: with SMTP id x14mr2604023lji.312.1616492721795; Tue, 23 Mar 2021 02:45:21 -0700 (PDT) Received: from [192.168.1.100] ([31.173.87.52]) by smtp.gmail.com with ESMTPSA id a8sm2269164ljn.96.2021.03.23.02.45.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 02:45:21 -0700 (PDT) Subject: Re: [PATCH v1 4/6] usb: gadget: pch_udc: Move pch_udc_init() to satisfy kernel doc To: Andy Shevchenko , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Felipe Balbi , Greg Kroah-Hartman , Linus Walleij References: <20210322211149.6658-1-andriy.shevchenko@linux.intel.com> <20210322211149.6658-4-andriy.shevchenko@linux.intel.com> From: Sergei Shtylyov Organization: Brain-dead Software Message-ID: Date: Tue, 23 Mar 2021 12:45:13 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322211149.6658-4-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On 23.03.2021 0:11, Andy Shevchenko wrote: > Kernel doc and the content described by it shouldn't be teared apart. s/teared/torn/? > Otherwise validator is not happy: > > .../pch_udc.c:573: warning: expecting prototype for pch_udc_reconnect(). Prototype was for pch_udc_init() instead > > Fixes: 1c575d2d2e3f ("usb: gadget: pch_udc: Fix usb/gadget/pch_udc: Fix ether gadget connect/disconnect issue") > Signed-off-by: Andy Shevchenko [...] MBR, Sergei