From: Shawn Lin <shawn.lin@rock-chips.com>
To: BeaCox <0xbeac@gmail.com>
Cc: shawn.lin@rock-chips.com, Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulfh@kernel.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mmc: dw_mmc: disable bh_work and stop timers on remove
Date: Mon, 2 Nov 2026 10:32:17 +0800 [thread overview]
Message-ID: <dc3e350e-fafe-436d-b847-5bcba99d1c1d@rock-chips.com> (raw)
In-Reply-To: <20261102022644.49510-1-0xbeac@gmail.com>
在 2026/11/02 星期一 10:26, BeaCox 写道:
> Hi Shawn,
>
> Thanks for the review and for checking the history. You are right on
> both points.
>
> dw_mci_remove() never called tasklet_kill(), so the race goes back to
> the original driver (f95f3850f7a9); 921c87ba3893 only replaced
> tasklet_schedule() with queue_work(). I have replaced the Fixes tag
> accordingly.
>
> I have also split the fix in two, since the two parts have different
> lifetimes:
>
> 1/2 drains bh_work. This is the long-standing race and the patch
> applies to 6.11 and later, where the bh_work form exists; it is
> marked Cc: stable # 6.11+.
> 2/2 cancels the watchdog timer. That code is new in 7.4
> (ce0043b9a302), so there is nothing to backport it to.
>
> The code is otherwise unchanged. v2 follows shortly.
>
> If you would rather keep it as a single patch without the stable tag,
> just let me know and I will squash them.
>
I'm fine with split the fix in two patches.
> Thanks,
> BeaCox
>
next prev parent reply other threads:[~2026-11-02 2:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 6:37 BeaCox
2026-11-01 10:43 ` Shawn Lin
2026-11-02 2:26 ` BeaCox
2026-11-02 2:32 ` Shawn Lin [this message]
2026-11-02 2:29 ` [RFC PATCH v2 0/2] mmc: dw_mmc: fix teardown races " BeaCox
2026-11-02 2:29 ` [RFC PATCH v2 1/2] mmc: dw_mmc: drain bh_work on host removal BeaCox
2026-11-02 2:34 ` Shawn Lin
2026-11-02 2:29 ` [RFC PATCH v2 2/2] mmc: dw_mmc: cancel the watchdog timer on remove BeaCox
2026-11-02 2:33 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc3e350e-fafe-436d-b847-5bcba99d1c1d@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=0xbeac@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®