From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sonic301-22.consmr.mail.gq1.yahoo.com (sonic301-22.consmr.mail.gq1.yahoo.com [98.137.64.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB83221C16E for ; Fri, 14 Nov 2025 22:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=98.137.64.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763160051; cv=none; b=Ddoc8ckEGpUA6j8mSKZKwZzi3aq4hUQzFJRVekcrYB+AACAcXUFBwHpKGn73suPhEUNV2jC4RKaTbz4nZ6mORIzhLwCnyc1jv52q6IT9aQ886YVpgvFwILxTbvp+LRfQwsing5bzT6PkAsBVl61fjObp46u5MdKiGc96WaZUlD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763160051; c=relaxed/simple; bh=GXKq4qFm2Qic82MUT9U/ZlOoz1C/eNqIuRGuCoAjflA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wp6MJ13mOmfY+umTIGIxbNyDOAq9/E7xmML3rWmBJEUn7TltQHK20ybUh46bNu2OPlZaMIr+J7VuhjflUvtrJt65j/YKjI4sdU75VwYfzXt69GFWVaPe86Wdw1N28oDl8NibMS64xaNPasKWM3AQ7/eUeLLF3lWPv3QEw4rjNW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com; spf=pass smtp.mailfrom=yahoo.com; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b=UGdlr+hY; arc=none smtp.client-ip=98.137.64.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="UGdlr+hY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1763160049; bh=iaO/GQHIWCg+Hr9D5m3jX5yvTCqb1XRrkZhoE4MkWjo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=UGdlr+hY8HLJ7TrYXImT61zRJuLkaRLxyZYqs7lNk09BAiHHT8DrVdF1zmxGhmDNvTIaoDqlwaltUjaNhZYeGMqXLKLv/a5q33hrq0i5aAXEVfexwncdG7uRvpmiB13l716Ap/He1NpGPp1HUxATOgZWnaMwkkAgqnXTuxSU7cCVNAFko6LbQDmyBg/wg6hJMQHy7D6+MnhCSCSYWd7DItiBu5VJZhuq2iftRcOxLprZpR2gtL1ERQOmvmpMWML6jImYbE+wSAtmM3Ffx9aV/XVq+1ya+qlWK+mtmDg7Fn0L0JVxWDIbfKv45KRrVaE3ZL7dpnib3NqxL31hmmDvlw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1763160049; bh=djzSRIM5AaOruUoBebZbmr2SqOc1rLarSZsSWPcTeNR=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=Xvm9UTiT6ktq7ydk05wIegnbrfMkIRlQ73UeD6ueh05XEsulGZ9K3eJbxlIX/9JpRV7HOIkuquxteWd7jeBLXQwGWEa+RMmQC0xp/f+VEx7QlMsjYLaBdQjI1se+coMkpiL1rYbqhl41mb4y0dOlKPpvX4Zco+ejBdMEin2Y+Y61L/yGBj02Qk9l/TWnnBeORPVHfnGr3EGNrGJqe9dRRhNu4geCoxfd9pecWdmJNMoPNxSVbQ7nu52HCSx1NtnPlq+QflEHlhnM331YFVJKT3nQnmvIPthrXoR6nEQs+NcS0UIRPS3hxsQd6nyfhoHu/ULSJGbo7h1iYI8eQkfilQ== X-YMail-OSG: 4FfyHgQVM1l7C.5Szl5k__iV_mDnh830DH56pSboKIDzQwidApP.29oiG.QpVKJ FGiKG_upW0I5Zvae4oTmVB.5FbO2TPIPYgBQaLsQU700CAJM9Sb9wi8wo00k3Mlf7ivuHPEuQDel Ju54NvoTsUTs602TCvEYPMfSrQaORJBoSIqksDCqewYnc7fdGwUwYuSipzEV.RemIHmFb1uKOk6T 1zr33gmYXldgnuuEwDS_78WQ1WobtwNCjjplfgrz1YCkgEs7Gf6NDMfwVyGWCznqi0Hb07GoDhYt e0QQuzgw.RgpxBDIoKg84DFzYdGB77Ky8P_9e4M.jqJT2qGRNALN6s_X.1VjlVInsT42oZvPmlvQ CcvDDrdUl_pq_KDdMUlzBmymYo16aZtWJC_r4ZZNSVkAlKKg9yf4gnKUk90MiSS8eKuXP7k2BW8H uNXyAvMZrmkJ2JJyHRswmdMjXnaZ0YaQD1dV7WsU4GxWtkHdmCegkjtABlWAYMmP5pjWVJFCjdDf fxuVzXwjhdVvp7dqIKwIjoudFY1lrWs0o17eiWVcEO7r.04uAQNfUzLyY74IH3lyXKpsl.x3FkFt ZvLVkKAbOb11tamxPEHlKKM0I6llfMwdO7p_cEYqf8odBmTDLQUHC87xrcWRCH.zZprKMy7O_qBb 1wYScI6Y2h1FIraoDggxVUTnmxX.wlnQqmb9Nmzi6.K1fBFJ2Kg3_PLxPYDuXEzO7GIcbmTSshPV T25o8LyxgIEoQtzGTyiUnowsSitgHhvHMsQjFV3s0WQYO1AGBcxbP0WjIiiRMeqC_.u50Efqjy7U 3g0LJwOFzc2mW_YG9SZGLwDgPbobRQpO7W.ndvDst2bgGMrTLRaV4Qq2gbOa2JnfgbPARknhwYPh Zuv1NNMg4VYy1FpUt69kHZLGWuiogJOifZJATi__SDBpRsRUjbHfDOn.ajk1BC_RhGDRtTDXmIvQ cUAYl6F7TgvUrGpaKQBvxKYlVZucWIe.MOvxmbetpZZaJeYC5BnORm1Tz..hnqDuqTZeQKFn5dQV r2lNvQwUInmvZSrN1NdbM14JvaR.6_eUztxZ6lndb8_W3PSDGOwcvS9DbA2X1VRJ7w1uJdm8I96J 2cErCoCfnWQfyacEHvAOsBx5AH6brOg0iFq0WekOmnKKwphbIUVNK5.oFPZn52YD_1.Bassq8RSu 8RsDTuKWcCDDzhzd.oLZD70dCQUD0jUrnXRR0P4vRIXqIVGPT_qNIYy97SmOnHc1_V5xb1LYEwos I2T.2mJqktwWjmPXsTcYIvuaB5N59.bG_VpYwwWtwPXlKb1WE3jEhK8zP49UHozHFN5KNJGGZfE_ QTqSYTVwtFutNTqTlKh6F3g8WjGQKsEKv_kEm5YV6ZKtnIfux31BlbMD_co3SWUphVNpiYHzSNzQ X6pFJixd._POctZA4IMM5edEQePcmeF7aBkznOQYezb7vgNO06VnXkgylpZyN0wTKgo4MS.IWV9o Eri89iXSKFmcWYqj.RWpJPNIdVCm0vM9OzwyeO6W6b0xxPMTlOw7t.sVD3ppXDFWNQlEPoJawulF BpPDNAwrHM4ph091j7fKnVE1OR.jJCda0Sesf4QlYVPHplT1ZYKqECs5AbAsTOaxEI_b662GR8fK Ke4iZyZ5EmN3lRDyIXQfIrKD8.yR2nqN4cezVrW9QWQt9B0kGqIJsQnCZJICu4A2YplpPGpXbADS BuZH6QKvJhnFXQhxdpG378GrIxcH5km0PcSRwcNzqYQFxLLkTS6aC_vM4HGTAI0c6Yz_tJtzdfcw hbB5ZPvyY13NzOYb6EhFseyXUaCnDV9HXpSyvDNChmI663XdqKktY7rGZhLDbq7aZ8ytRijP.YDw 3dW8wMHXRBEQltVkiNBI2eaM.p5B_KZCov3_pmaPuUNla.UWQun3xP4V12BySmCDkemR6CqwFjzi uHRyuvy9Yaiw0htvkRvCQ48IZ9EBeyPZ9ecIM.VFmWvZZt304uix8EL74fPeCYricKQ0NTLl45XM Xm1UI0F3PQcfadrqe_jwsEdeZDMgkGEOKq3q7CAcOwg9wcKvyjdngkh2sprJOuVIgHGnoWcLJ9kt tW2czl2kzCuytc0fDLo58NSA1_5IrwkLIY_KNhhe8ChBr7VZycu1CjMhsJkwDfYQ.SsVcOgeFSTp dAqgKON2YWDXei7VCYfZluBGfLrF7H8Y.5qENVU1cVhxVrdtyl4my3LlgS8WtIvmTZeMaVl4o57n dS8F4pe01mu2t4mM2tM0YKidRZ45l2lXcW.aN9X6rguVDO4SXgxDxmGq27qqVAvTG64ZBJnkmPVg VTS82yKgF.WaIKfCKR0knYfA- X-Sonic-MF: X-Sonic-ID: 33d2b546-738f-416b-973d-321f9834d415 Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Fri, 14 Nov 2025 22:40:49 +0000 Received: by hermes--production-bf1-58477f5468-vjcpj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fdd2b53d4999915145ebe89b3164e7d5; Fri, 14 Nov 2025 22:20:34 +0000 (UTC) Message-ID: Date: Fri, 14 Nov 2025 23:20:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm: rename drm_ioctl_flags() to drm_ioctl_get_flags() to fix kernel-doc name conflict To: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, zack.rusin@broadcom.com Cc: bcm-kernel-feedback-list@broadcom.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org References: <20251010002520.359824-1-adelodunolaoluwa.ref@yahoo.com> <20251010002520.359824-1-adelodunolaoluwa@yahoo.com> Content-Language: en-US From: Sunday Adelodun In-Reply-To: <20251010002520.359824-1-adelodunolaoluwa@yahoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.24652 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo On 10/10/25 01:25, Sunday Adelodun wrote: > The function `drm_ioctl_flags()` defined in `drm_ioctl.c` shares the same > identifier name as the `enum drm_ioctl_flags` defined in > `drm_ioctl.h`. Although this naming overlap is perfectly valid in C — > since functions and enumerations exist in separate namespaces and do > not affect compilation or linkage — it causes a symbol collision in the > kernel-doc build system. > > During `make htmldocs`, Sphinx reports the following warning: > ./Documentation/gpu/drm-uapi:574: ./drivers/gpu/drm/drm_ioctl.c:915: > WARNING: Duplicate C declaration, also defined at gpu/drm-uapi:69. > Declaration is '.. c:function:: > bool drm_ioctl_flags (unsigned int nr, unsigned int *flags)'. > > This happens because kernel-doc processes both identifiers (the enum and > the function) under the same name, leading to a duplicate symbol entry > in the generated documentation index. The build system therefore treats > them as conflicting declarations, even though they represent different > entities in code. > > To resolve this, the function has been renamed to > `drm_ioctl_get_flags()`, which both removes the naming collision and > better describes the function’s purpose—retrieving ioctl permission > flags associated with a given command number. > > All affected references have been updated accordingly in: > - `drivers/gpu/drm/drm_ioctl.c` > - `drivers/gpu/drm/vmwgfx/vmwgfx_drv.c` > - `include/drm/drm_ioctl.h` > > No other symbols or behavior are modified. > > Signed-off-by: Sunday Adelodun > --- > drivers/gpu/drm/drm_ioctl.c | 6 +++--- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- > include/drm/drm_ioctl.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c > index f593dc569d31..313e8bb7986a 100644 > --- a/drivers/gpu/drm/drm_ioctl.c > +++ b/drivers/gpu/drm/drm_ioctl.c > @@ -912,7 +912,7 @@ long drm_ioctl(struct file *filp, > EXPORT_SYMBOL(drm_ioctl); > > /** > - * drm_ioctl_flags - Check for core ioctl and return ioctl permission flags > + * drm_ioctl_get_flags - Check for core ioctl and return ioctl permission flags > * @nr: ioctl number > * @flags: where to return the ioctl permission flags > * > @@ -923,7 +923,7 @@ EXPORT_SYMBOL(drm_ioctl); > * Returns: > * True if the @nr corresponds to a DRM core ioctl number, false otherwise. > */ > -bool drm_ioctl_flags(unsigned int nr, unsigned int *flags) > +bool drm_ioctl_get_flags(unsigned int nr, unsigned int *flags) > { > if (nr >= DRM_COMMAND_BASE && nr < DRM_COMMAND_END) > return false; > @@ -935,4 +935,4 @@ bool drm_ioctl_flags(unsigned int nr, unsigned int *flags) > *flags = drm_ioctls[nr].flags; > return true; > } > -EXPORT_SYMBOL(drm_ioctl_flags); > +EXPORT_SYMBOL(drm_ioctl_get_flags); > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index 8ff958d119be..fa4644067d46 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -1257,7 +1257,7 @@ static long vmw_generic_ioctl(struct file *filp, unsigned int cmd, > goto out_io_encoding; > > flags = ioctl->flags; > - } else if (!drm_ioctl_flags(nr, &flags)) > + } else if (!drm_ioctl_get_flags(nr, &flags)) > return -EINVAL; > > return ioctl_func(filp, cmd, arg); > diff --git a/include/drm/drm_ioctl.h b/include/drm/drm_ioctl.h > index 171760b6c4a1..585dda7550b0 100644 > --- a/include/drm/drm_ioctl.h > +++ b/include/drm/drm_ioctl.h > @@ -164,7 +164,7 @@ long drm_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); > /* Let drm_compat_ioctl be assigned to .compat_ioctl unconditionally */ > #define drm_compat_ioctl NULL > #endif > -bool drm_ioctl_flags(unsigned int nr, unsigned int *flags); > +bool drm_ioctl_get_flags(unsigned int nr, unsigned int *flags); > > int drm_noop(struct drm_device *dev, void *data, > struct drm_file *file_priv); Hi all, I hope this meets you well. I wanted to check if there's any update or if any further changes are needed from my side regarding this patch. Thank you for your time. Best regards, Sunday Adelodun