Re: [PATCH RESEND] arm64: dts: qcom: sm8550: Add support for camss

[Bryan O'Donoghue <bryan.odonoghue@linaro.org>]

On 10/06/2025 10:48, Vladimir Zapolskiy wrote:
> Hello Wenmeng.
> 
> On 5/16/25 10:27, Wenmeng Liu wrote:
>> Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
>> includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
>>
>> SM8550 provides
>> - 3 x VFE, 3 RDI per VFE
>> - 2 x VFE Lite, 4 RDI per VFE
>> - 3 x CSID
>> - 2 x CSID Lite
>> - 8 x CSI PHY
>>
>> Co-developed-by: Depeng Shao <quic_depengs@quicinc.com>
>> Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8550.dtsi | 210 +++++++++++++++++++++++++++
>>   1 file changed, 210 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/ 
>> dts/qcom/sm8550.dtsi
>> index e9bb077aa9f0..722521496a2d 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> @@ -3326,6 +3326,216 @@ cci2_i2c1: i2c-bus@1 {
>>               };
>>           };
>> +        isp: isp@acb7000 {
>> +            compatible = "qcom,sm8550-camss";
>> +
> 
> This is the first time, when 'isp' label is used instead of 'camss', it 
> might
> be I missed the context, is there any particular reason to do such a 
> change?
> 
> If the label name is changed to the regular 'camss', then
> 
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> 
> -- 
> Best wishes,
> Vladimir

List feedback from DT people is isp@ is the correct prefix.

---
bod