From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758264AbcILLzV (ORCPT ); Mon, 12 Sep 2016 07:55:21 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:35659 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758232AbcILLzS (ORCPT ); Mon, 12 Sep 2016 07:55:18 -0400 Subject: Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting To: Colin King , Chas Williams <3chas3@gmail.com>, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org References: <20160912092930.20683-1-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: Date: Mon, 12 Sep 2016 14:55:15 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160912092930.20683-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 9/12/2016 12:29 PM, Colin King wrote: > From: Colin Ian King > > The newline escape is incorrect and needs fixing. Also adjust source > formatting / indentation and remove trailing white space. > > Signed-off-by: Colin Ian King > --- > drivers/atm/iphase.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c > index 9d8807e..256b191 100644 > --- a/drivers/atm/iphase.c > +++ b/drivers/atm/iphase.c > @@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc) > if ((ret = ia_cbr_setup (iadev, vcc)) < 0) { > return ret; > } > - } > - else > - printk("iadev: Non UBR, ABR and CBR traffic not supportedn"); > + } else > + printk("iadev: Non UBR, ABR and CBR traffic not supported\n"); All branches of the *if* statement should have {} if at least one has them, perhaps a material for a follow-up patch). [...] MBR, Sergei