From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457F6C3279B for ; Tue, 10 Jul 2018 15:04:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 085CD208E8 for ; Tue, 10 Jul 2018 15:04:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 085CD208E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933842AbeGJPE0 (ORCPT ); Tue, 10 Jul 2018 11:04:26 -0400 Received: from foss.arm.com ([217.140.101.70]:48386 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933600AbeGJPEW (ORCPT ); Tue, 10 Jul 2018 11:04:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A5A4780D; Tue, 10 Jul 2018 08:04:22 -0700 (PDT) Received: from [192.168.100.244] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4771C3F589; Tue, 10 Jul 2018 08:04:22 -0700 (PDT) Subject: Re: 4.18rc3 TX2 boot failure with "ACPICA: AML parser: attempt to continue loading table after error" To: "Rafael J. Wysocki" Cc: "Schmauss, Erik" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Lorenzo Pieralisi References: <218e4339-477d-eb0d-6007-764c8e24229f@arm.com> <3574827.zOC4apc8e1@aspire.rjw.lan> <2264016.O8iB3BUh2s@aspire.rjw.lan> From: Jeremy Linton Message-ID: Date: Tue, 10 Jul 2018 10:04:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2264016.O8iB3BUh2s@aspire.rjw.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 07/10/2018 06:25 AM, Rafael J. Wysocki wrote: > On Tuesday, July 10, 2018 1:13:17 PM CEST Rafael J. Wysocki wrote: >> On Tuesday, July 10, 2018 5:44:05 AM CEST Jeremy Linton wrote: >>> Hi, >>> >>> On 07/09/2018 04:28 PM, Rafael J. Wysocki wrote: >>>> On Mon, Jul 9, 2018 at 10:45 PM, Jeremy Linton wrote: >>>>> Hi, >>>>> >>>>> First thanks for the patch.. >>>>> >>>>> On 07/08/2018 04:14 AM, Rafael J. Wysocki wrote: >>>>>> >>>>>> On Monday, July 2, 2018 11:41:42 PM CEST Jeremy Linton wrote: >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I'm experiencing two problems with commit 5088814a6e931 which is >>>>>>> "ACPICA: AML parser: attempt to continue loading table after error" >>>>>>> >>>>>>> The first is this boot failure on a thunderX2: >>>>>>> >>>>>>> [ 10.770098] ACPI Error: Ignore error and continue table load >>>>> >>>>> >>>>> [trimming] >>>>> >>>>>>> ]--- >>>>>>> >>>>>>> Which does appear to be the result of some bad data in the table, but it >>>>>>> was working with 4.17, and reverting this commit solves the problem. >>>>>> >>>>>> >>>>>> Does the patch below make any difference? >>>>>> >>>>>> --- >>>>>> drivers/acpi/acpica/psobject.c | 3 +++ >>>>>> 1 file changed, 3 insertions(+) >>>>>> >>>>>> Index: linux-pm/drivers/acpi/acpica/psobject.c >>>>>> =================================================================== >>>>>> --- linux-pm.orig/drivers/acpi/acpica/psobject.c >>>>>> +++ linux-pm/drivers/acpi/acpica/psobject.c >>>>>> @@ -39,6 +39,9 @@ static acpi_status acpi_ps_get_aml_opcod >>>>>> ACPI_FUNCTION_TRACE_PTR(ps_get_aml_opcode, walk_state); >>>>>> walk_state->aml = walk_state->parser_state.aml; >>>>>> + if (!walk_state->aml) >>>>>> + return AE_CTRL_PARSE_CONTINUE; >>>>>> + >>>>> >>>>> >>>>> Well this seems to avoid the crash, but now it hangs right after on the >>>>> "Ignore error and continue table load" message. >>>> >>>> Well, maybe we should just abort in that case. >>>> >>>> I'm wondering what happens if you replace the return statement in the >>>> patch above with >>>> >>>> return_ACPI_STATUS(AE_AML_BAD_OPCODE) >>> >>> Yes, that is where I went when I applied the patch but I used >>> AE_CTRL_TERMINATE, which terminates the loop in acpi_ps_parse_loop() and >>> that appears to successfully finish/terminate the initial parsing pass. >>> But, it then crashes in acpi_ns_lookup called via the >>> acpi_walk_resources sequences that goes through ut_evalute_object() due >>> to the path/scope_info->scope.node being ACPI_ROOT_OBJECT (-1) and >>> bypassing the null check. Adding a ACPI_ROOT_OBJECT check as well as the >>> null checks in acpi_ns_lookup results in a successful boot. Tracking >>> down how the terminate (or whatever) is leaving the info->prefix_node >>> (in acpi_ns_evaluate) set to ROOT_OBJECT instead of null, is something I >>> don't yet understand. >>> >>> Anyway, I tried Using BAD_OPCODE rather than TERMINATE and it seems to >>> have the same basic result as PARSE_CONTINUE. >> >> OK, thanks! >> >> I evidently didn't look deep enough. >> >> Can you please check the patch below? >> >> I'm not sure if we can pass this broken state to >> acpi_ps_complete_final_op(), so it may be necessary to return >> an error directly when aml_op_start is NULL. >> >> --- >> drivers/acpi/acpica/psloop.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> Index: linux-pm/drivers/acpi/acpica/psloop.c >> =================================================================== >> --- linux-pm.orig/drivers/acpi/acpica/psloop.c >> +++ linux-pm/drivers/acpi/acpica/psloop.c >> @@ -493,6 +493,9 @@ acpi_status acpi_ps_parse_loop(struct ac >> ASL_CV_CAPTURE_COMMENTS(walk_state); >> >> aml_op_start = parser_state->aml; >> + if (!aml_op_start) >> + break; >> + >> if (!op) { >> status = >> acpi_ps_create_op(walk_state, aml_op_start, &op); >> >> -- > > So maybe something like this: > > --- > drivers/acpi/acpica/psloop.c | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-pm/drivers/acpi/acpica/psloop.c > =================================================================== > --- linux-pm.orig/drivers/acpi/acpica/psloop.c > +++ linux-pm/drivers/acpi/acpica/psloop.c > @@ -494,6 +494,9 @@ acpi_status acpi_ps_parse_loop(struct ac > > aml_op_start = parser_state->aml; > if (!op) { > + if (!aml_op_start) > + return_ACPI_STATUS(AE_AML_INTERNAL); > + > status = > acpi_ps_create_op(walk_state, aml_op_start, &op); > if (ACPI_FAILURE(status)) { > > This gets rid of the infinite loop, but its still has the problem with acpi_ns_lookup crashing due to -1 in the scope.node.