From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D23C01DFDA1 for ; Wed, 4 Mar 2026 05:41:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772602912; cv=none; b=AskkS45ZhyfUKA3aIxiLDPDa468dXwe3tcwLoTHJHpNEwdcnN6B3H+bjVSK+oa/Q46r+EmikvumlPMYiGzzPxKpBWjzH0GN5RMczhp/uUkmOTagbekaazoQfB+vY/B1TgcxhVrxR6izd7MgFCfEe8QEiDnGmbA5Wh/g1wotqA98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772602912; c=relaxed/simple; bh=EuXdb769TzxSabic49+YuzfWZXwBJqDChmUmYS4MOL8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kujo4gV9thKOcmJKBa6AGxDQNBMxzu+gc1oEYxYA/Dl6sJv35c5niy+a8J9mCTfhRLVWDSve+qOtHw3un4amWtAL1vFUUZ8+HZJqp6nYEa0FqgsPk7kObfW8pxdQ4tLUorsPYJMijK0yMmchCFkQpACHuuSWuY5k8IXF4iGMBwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hnr/iguj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vau+uJ+j; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hnr/iguj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vau+uJ+j" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245SPBi1677902 for ; Wed, 4 Mar 2026 05:41:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qt/HtlB2bl3WqSWGBiy3e0LJSkBn9/Il23j6YIhRm+4=; b=Hnr/iguj6k1fVonc PMAh9YyYKduzxadaY/AQVRXix8kVklW20hbfs4s9mODekG0CB1q+tK+nwdzpG4tv CALIf/u+fFnncbs27+mzPwYkkLo10pZOh13kktkNVjony2scj/G2CTSNxLxYSs9V SciVKIbgmDOOXBeSO11pQXJyK4fjPh00JmzqmZ/sC82DDg/6WA8jp+CysQv7GG0e h11vKx2xJWXE9EuRanpgJqdxzmtLu5GErLbIYi7/bsTXCJT3ytr5+SxDUwULFcAi 0EjgyKuJL9NlwZhkARQXP+HZMQES8LDxBBeR3SGt9l/R1WFlXdebYVCSqVbM4TPL be8xTQ== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cp73h9fnj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 05:41:49 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2be2f742c46so5660407eec.0 for ; Tue, 03 Mar 2026 21:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772602909; x=1773207709; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qt/HtlB2bl3WqSWGBiy3e0LJSkBn9/Il23j6YIhRm+4=; b=Vau+uJ+jiy0Sz12Kvq3MTDKyI/SgCy3ZS8i1mxoi4Y3lOdBpJsyhZqGyRCmvqI63z6 bmnnkD+L+pilNHrkv75MLInKUvedA8ql2Ia+yo3Bz0TAR/UpMvCypZu1tuHjNrNDQUhi 8iHbNrvs7f9kuAtYC9lX0RhB/0GCRflrFyGJtJl2AOIsZPhoSBHDWzuXeScSM/NOU5KH Bkb+RURdFnPEUw5dtUhM962dfk1DP+ciWZQ/L+mRPPiRj3lDQz0jNPq8tLwJR/tqKQ20 bDW6oaqDIbQu17VR48xELqRXgcflRsuzPQYHwYv6g0Xlo5qg8FpszFNKLQYPsI7zr5nl MEIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772602909; x=1773207709; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qt/HtlB2bl3WqSWGBiy3e0LJSkBn9/Il23j6YIhRm+4=; b=VUDwdrdcURQZFJWhSmj2fWrkD58Bguk8lhiRpuDPkzLQPanW4/e1KO1xsF7o3kCjk5 DPulvv1zb5skUHhePfzE54vWPmpPRGT+y9K7iNFafYsySi0he1zVaE0+sEoHdCE++IaY AQ9GMMTuceSiwwT+blW6IIH9FbTWuWPVOzAOtB2/RefV8w+oKyqdnI1u2Ur1WVV1yfMQ qQhflf8c95kj2nBQjawSMtEVLbJMi/NStRUPwFbt9ymlo37MC/Fupt+Ia2GSoW4q5sgg AyirKhPSdRMagIP0BpxYEH8aE7WrHjVGwTZqT54YbB1CRA7iFyhFGZn6RjloaDA/hRIH bJ+g== X-Forwarded-Encrypted: i=1; AJvYcCX4FTcF46l+MlyYDmHSFMNw6UkJZHpQoVCAQMZyX5yK528wlEHnrARvN6AohnQa0Lxzi/kLWnt8YN8jqYg=@vger.kernel.org X-Gm-Message-State: AOJu0YxCw63h/uZzXqUqgjxXgTzQYoH4VPgBXibctV+cbqqg/kHKFVnE +rwRIvW6H2+WE2dyywObFi5plUTWEN/EP3qhef6iy2On7xg/cj58sf8Sj3Bd/Xdv3DW+86k84NW eFIXLW8lOvJOuUf3oWkIxBD6WAMCjPBP4RdasqCbFGvMvpYO9e9UUKg9pkmNjSgnpaEs= X-Gm-Gg: ATEYQzwvtmMfQZlYujlS1GVL/ZKQjioLfN2qVUn05IH4H+sBAxPmQkGwg1UnxX34oXB hGNVtspO44mcAMzffsqtdfq2QlPB41fMEWnehZkeS2zVtYD9vZ6YvN96N5PrujttysBCVxv32LZ qMTYGHafINUnsbSLiHSJdiJEsHR8skeua72nZODoGl7/sQn8qzbIgLFUKhkbEnF0/jc0XH+Zo7M 088uf1DVs4x4E8bCQMzpioot2Xyuy1nQjP730Iz75njKzfFWmBVXSED7FKgwkqEWkcdB6hBCdQQ 6xNMWVLU8AD/Xe1ckrcNRz7sydmhSMKYN5Le1RHAw9Fz2cYgTns1I9KcNhDHWNIdx4QUGBqkKuS bXY/tpo+8lhbfOvKAP7IVExJxn75fd6Zp4/DBKxxGAsPHrUJhiuAipMk= X-Received: by 2002:a05:7301:1292:b0:2b8:30b8:58cf with SMTP id 5a478bee46e88-2be30fccf2fmr316298eec.8.1772602908960; Tue, 03 Mar 2026 21:41:48 -0800 (PST) X-Received: by 2002:a05:7301:1292:b0:2b8:30b8:58cf with SMTP id 5a478bee46e88-2be30fccf2fmr316277eec.8.1772602908364; Tue, 03 Mar 2026 21:41:48 -0800 (PST) Received: from [192.168.86.165] ([76.176.48.107]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be1731b6b6sm6231081eec.5.2026.03.03.21.41.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 21:41:47 -0800 (PST) Message-ID: Date: Tue, 3 Mar 2026 21:41:46 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] clocksource/drivers/timer-mediatek: Convert timer-mediatek to a loadable module To: Zhipeng Wang , daniel.lezcano@linaro.org, tglx@kernel.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chun-hung.wu@mediatek.com, walter.chang@mediatek.com, jstultz@google.com, amergnat@baylibre.com, aisheng.dong@nxp.com, jindong.yue@nxp.com, xuegang.liu@nxp.com References: <20260304025720.2583655-1-zhipeng.wang_1@nxp.com> <20260304025720.2583655-4-zhipeng.wang_1@nxp.com> Content-Language: en-US From: Trilok Soni In-Reply-To: <20260304025720.2583655-4-zhipeng.wang_1@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ZZ2g46lPZYUHpr3XPr2yAl2t33SDOLgT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA0NSBTYWx0ZWRfX3KKZ7oSh4dU3 tM+6jaLhhX/CNmdgkc3N9bF+YRJi0wCC3JKExhdQlugqcc8PyKyw5OypWDWnUbEmE/xAwRxfP6n KU7u7zHL4BuVPEhxTB3DdiXZVsfAt0cPWkK+kBDlW4t2kxgerNWg+k2BoUSKrDU0+LRbS5rfAd2 JugpBJi5KuaBlozf8Hgs62nA5iQbnfLgYuuQG+q5wzWOc8iWblWKXxjLpAz2rQpjit3eZZpLHsT ukhhK9vA7m24f6Iya4FaHshcCnWgDXc8XdSXO49wojYunuFTbSLoJrMdDmey1ycoSwgH3WGB5/3 wbCi6Oc+vFmLzrQSo8JGCJLP0lPBs+XWIO22ZljK/4INcKD3+GaoFiNN0e0ILUV0zyV+ERLQ1a/ pWxObAxZMx88DlIGHY5OqDlnw64iheup2aRDpheBulS17G8q5HE41galdA1gd2nwQhqKTQFKO5q X81FHBj/90KyXPMCGzg== X-Proofpoint-ORIG-GUID: ZZ2g46lPZYUHpr3XPr2yAl2t33SDOLgT X-Authority-Analysis: v=2.4 cv=BpWQAIX5 c=1 sm=1 tr=0 ts=69a7c61d cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=lsoD3MMNObdLvy1227ExmA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=mpaa-ttXAAAA:8 a=QX4gbG5DAAAA:8 a=IpJZQVW2AAAA:8 a=8AirrxEcAAAA:8 a=JS8otC1fTDAvhBOTJEIA:9 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 a=AbAUZ8qAyYyZVLSsDulk:22 a=IawgGOuG5U0WyFbmm1f5:22 a=ST-jHhOKWsTCqRlWije3:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_02,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040045 On 3/3/2026 6:57 PM, Zhipeng Wang wrote: > From: Chun-Hung Wu > > Convert the timer-mediatek driver into a loadable module so that > it can register an always-on timer as the tick_broadcast_device on > MediaTek SoCs. This helps support GKI modular configurations. You have expanded GKI in the cover letter but not in the commit text. Please add that in the commit text since this patch will be committed and not the cover letter. > > Signed-off-by: Chun-Hung Wu > Signed-off-by: Walter Chang > Tested-by: Walter Chang > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: Alexandre Mergnat > Signed-off-by: Zhipeng Wang > --- > drivers/clocksource/Kconfig | 2 +- > drivers/clocksource/timer-mediatek.c | 33 ++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index fd9112706545..2112efb85029 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -488,7 +488,7 @@ config SYS_SUPPORTS_SH_CMT > bool > > config MTK_TIMER > - bool "Mediatek timer driver" if COMPILE_TEST > + tristate "MediaTek timer driver" > depends on HAS_IOMEM > select TIMER_OF > select CLKSRC_MMIO > diff --git a/drivers/clocksource/timer-mediatek.c b/drivers/clocksource/timer-mediatek.c > index 7bcb4a3f26fb..4ad4bac6f34b 100644 > --- a/drivers/clocksource/timer-mediatek.c > +++ b/drivers/clocksource/timer-mediatek.c > @@ -13,6 +13,9 @@ > #include > #include > #include > +#include > +#include > +#include > #include > #include > #include "timer-of.h" > @@ -337,5 +340,35 @@ static int __init mtk_gpt_init(struct device_node *node) > > return 0; > } > + > +#ifndef MODULE > TIMER_OF_DECLARE(mtk_mt6577, "mediatek,mt6577-timer", mtk_gpt_init); > TIMER_OF_DECLARE(mtk_mt6765, "mediatek,mt6765-timer", mtk_syst_init); > +#else > +static int mtk_timer_probe(struct platform_device *pdev) > +{ > + int (*timer_init)(struct device_node *node); > + struct device_node *np = pdev->dev.of_node; > + > + timer_init = of_device_get_match_data(&pdev->dev); > + return timer_init(np); > +} > + > +static const struct of_device_id mtk_timer_match_table[] = { > + { .compatible = "mediatek,mt6577-timer", .data = mtk_gpt_init }, > + { .compatible = "mediatek,mt6765-timer", .data = mtk_syst_init }, > + { /* sentinel */ } > +}; > + > +static struct platform_driver mtk_timer_driver = { > + .probe = mtk_timer_probe, > + .driver = { > + .name = "mediatek-timer", > + .of_match_table = mtk_timer_match_table, > + }, > +}; > +module_platform_driver(mtk_timer_driver); > + > +MODULE_DESCRIPTION("MediaTek Timer driver"); > +MODULE_LICENSE("GPL"); > +#endif