From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7181CEB8FB3 for ; Wed, 6 Sep 2023 06:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239942AbjIFGUb (ORCPT ); Wed, 6 Sep 2023 02:20:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbjIFGU3 (ORCPT ); Wed, 6 Sep 2023 02:20:29 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A22B127 for ; Tue, 5 Sep 2023 23:20:25 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9a603159f33so482824166b.0 for ; Tue, 05 Sep 2023 23:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693981223; x=1694586023; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=adh+U84otDp6D2XjrT9VmlnQv1geqMIUW73SkaICVTU=; b=RHiU0c/T8651V3YbqBCkdFm4/VeEvValgC1+E/2wCWMocevxzZsyQGUUcOaaGwSDZK ev8ExlKb7GNBqCQF8S9JgGoDVLWCLSMfyCGJhAbpcxUhhc6iW4YuLhzCQ45xmI7/wFzn IFEurR96XuXJsW3agD+O+rQga7qSP3UDLBSMlNFbMTOfv/J/fZdB4xdvVNh1LKdqTe2I DxyUlFrlYiotTxQt+6iv1VkaryeM+HHdioYHimeHZH9NChqifjngcGNS0h7sYJfK9a+W bjCWJyS/BHW7bqqCg06D5By+wzw5ztbimVrFhGZeWtS6esL8fMH9cWNgtgwCWlzxr+0Y 6BRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693981223; x=1694586023; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=adh+U84otDp6D2XjrT9VmlnQv1geqMIUW73SkaICVTU=; b=JwgL+NQqjghv1xp1Lwl9en3XWhjfVcrr7NnafV/UYZU9JmOn/G0F2oF7LZ3oQQx0jt wv0M4iOcEqogr0YfQtIIRnnAYH803txLtEvBwSiKSrYW3HhGNmPr3zocB9WXLj7T0I65 pGnoMSY9zcdr0xa1mGFaTqAX+vbDpjZflKNN6FpFMNXj9OHVPo51GYgpHz7stWv1PhLs f9FNC6qMeWl8K94ZGxmQcE5VA8UsFCjFc2Bk3DrxwpqTbW9oDYwR3oViAfhyItplHtgJ rd4OAbzcDx58Or/fAufMc8FWzOBDfrluHK947tMJVXTrqxKfHg8svc+eWYaYMfu//04I Cy+g== X-Gm-Message-State: AOJu0YwfrnnQTcWI4/mOxqh0n2cUqmMNDlyk1TatAdY/SzUmmri5slm7 gRmHtihwwjiAfpSfRLn2PSfmdg== X-Google-Smtp-Source: AGHT+IG4ETI87Rghtciw0SPzGjlGgvKSQBl+bWvP8rr+LeMJJnzkKCMyApg0Q/K4wLu/0o/HhY43kg== X-Received: by 2002:a17:906:8a4c:b0:9a5:d657:47ec with SMTP id gx12-20020a1709068a4c00b009a5d65747ecmr1332932ejc.64.1693981222918; Tue, 05 Sep 2023 23:20:22 -0700 (PDT) Received: from [192.168.69.115] (cou50-h01-176-172-51-223.dsl.sta.abo.bbox.fr. [176.172.51.223]) by smtp.gmail.com with ESMTPSA id i7-20020a170906850700b00993664a9987sm8503328ejx.103.2023.09.05.23.20.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 23:20:22 -0700 (PDT) Message-ID: Date: Wed, 6 Sep 2023 08:20:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v4 3/3] remoteproc: zynqmp: get TCM from device-tree Content-Language: en-US To: Tanmay Shah , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Michal Simek Cc: Conor Dooley , Radhey Shyam Pandey , Ben Levinsky References: <20230829181900.2561194-1-tanmay.shah@amd.com> <20230829181900.2561194-4-tanmay.shah@amd.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/9/23 23:48, Tanmay Shah wrote: > > On 9/4/23 2:50 AM, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 29/8/23 20:19, Tanmay Shah wrote: >>> Use new dt bindings to get TCM address and size >>> information. Also make sure that driver stays >>> compatible with previous device-tree bindings. >>> So, if TCM information isn't available in device-tree >>> for zynqmp platform, hard-coded address of TCM will >>> be used. >>> >>> New platforms that are compatible with this >>> driver must add TCM support in device-tree as per new >>> bindings. >>> >>> Signed-off-by: Tanmay Shah >>> --- >>> drivers/remoteproc/xlnx_r5_remoteproc.c | 279 +++++++++++++++++++----- >>> 1 file changed, 221 insertions(+), 58 deletions(-) >> >> >>> /** >>> @@ -75,11 +79,17 @@ struct mbox_info { >>> * Hardcoded TCM bank values. This will be removed once TCM bindings are >>> * accepted for system-dt specifications and upstreamed in linux kernel >> >> Just curious, for how long this fall back code has to be maintained? >> (When/how will we know we can remove it?) > > > I believe we should never remove it. It's important that driver works with old bindings as well. Do you mind posting a followup patch updating the comment, to clarify? Thanks, Phil.