From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751805AbeCVTZG (ORCPT ); Thu, 22 Mar 2018 15:25:06 -0400 Received: from gateway32.websitewelcome.com ([192.185.145.111]:22662 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbeCVTZE (ORCPT ); Thu, 22 Mar 2018 15:25:04 -0400 Subject: Re: [PATCH] caif_dev: use true and false for boolean values To: Dmitry Tarnyagin , "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180305220537.GA15924@embeddedor.com> From: "Gustavo A. R. Silva" Message-ID: Date: Thu, 22 Mar 2018 14:24:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180305220537.GA15924@embeddedor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.54.187 X-Source-L: No X-Exim-ID: 1ez5pf-000d6I-6s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.67]) [189.145.54.187]:55632 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, I was just wondering about the status of this patch. Thanks! -- Gustavo On 03/05/2018 04:05 PM, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > net/caif/caif_dev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c > index e0adcd1..f2848d6 100644 > --- a/net/caif/caif_dev.c > +++ b/net/caif/caif_dev.c > @@ -139,7 +139,7 @@ static void caif_flow_cb(struct sk_buff *skb) > > spin_lock_bh(&caifd->flow_lock); > send_xoff = caifd->xoff; > - caifd->xoff = 0; > + caifd->xoff = false; > dtor = caifd->xoff_skb_dtor; > > if (WARN_ON(caifd->xoff_skb != skb)) > @@ -213,7 +213,7 @@ static int transmit(struct cflayer *layer, struct cfpkt *pkt) > pr_debug("queue has stopped(%d) or is full (%d > %d)\n", > netif_queue_stopped(caifd->netdev), > qlen, high); > - caifd->xoff = 1; > + caifd->xoff = true; > caifd->xoff_skb = skb; > caifd->xoff_skb_dtor = skb->destructor; > skb->destructor = caif_flow_cb; > @@ -400,7 +400,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, > break; > } > > - caifd->xoff = 0; > + caifd->xoff = false; > cfcnfg_set_phy_state(cfg, &caifd->layer, true); > rcu_read_unlock(); > > @@ -435,7 +435,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, > if (caifd->xoff_skb_dtor != NULL && caifd->xoff_skb != NULL) > caifd->xoff_skb->destructor = caifd->xoff_skb_dtor; > > - caifd->xoff = 0; > + caifd->xoff = false; > caifd->xoff_skb_dtor = NULL; > caifd->xoff_skb = NULL; > >