From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1538C48BE5 for ; Thu, 17 Jun 2021 10:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F261613BF for ; Thu, 17 Jun 2021 10:17:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbhFQKTe (ORCPT ); Thu, 17 Jun 2021 06:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230473AbhFQKTd (ORCPT ); Thu, 17 Jun 2021 06:19:33 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0AA9C06175F for ; Thu, 17 Jun 2021 03:17:25 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id i12so4872172ila.13 for ; Thu, 17 Jun 2021 03:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TgPllGimVmcNN4ah98danBO0E/RhAz5y3uGjSnBg5Bc=; b=PXgXAzeg2+TFQw/5cu/tUjYhxtgHMrg6wM9mTZ/2DUYOajPAZuwkcnT3BA3Vl1uMwJ z4AuUF5RRXZKCLYUpFoOruA4jtT6Ej0anJhopRkQcoBSuVzsWXee54XbXWYhRwG79RTt TBkG7fMwJoLkYro4pHZQW3dtYgjPtxkyMFwSg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TgPllGimVmcNN4ah98danBO0E/RhAz5y3uGjSnBg5Bc=; b=or9su0KVNuHhKwkpBDmmbZZKUsWbNJLCvWAUGYhTAPJyRNDOGqt3ZtzCCnoMxeiz1/ 4erP5jvNa6ZHKaOoihCuBkbR7BcqhGr7Rw7TisrQ7FXhozE2Sd5WXwALawi5hcRStq7J lPgGYVACE7WYN5G9qLhBWyqS7dndyK9HoX4N4ZHX8xD/ocQ2XJDE1g0DfPUyGcgQSG8L bO31cvPRGB0wS8VwqnrG+qzXKnYRPW0XHmr+Gqt7ODrBh7cgYvBR3OKipymTi2aOP0uy K2tDKqAD4sFPitOtARiYS1mdu5H0aiJheW0BJ66NlOIWR+RxHUSwVbC7qrC8s34kCwoB il7A== X-Gm-Message-State: AOAM532mxu3r1nXdxKBm0HiQ03xGUMzDvf4EskTDHUvrJgA4gKtfQMad KVnhNapRtx3iecM7Yk9uMP4Ed4Jaya7Mkg== X-Google-Smtp-Source: ABdhPJz2LAw4NBLhpIqLHyfUazN/hOQHG2W76Bos6afm67s91rmSwPdAKQDg2dDZUAmHkyvazNdM+g== X-Received: by 2002:a92:3302:: with SMTP id a2mr2993017ilf.62.1623925044956; Thu, 17 Jun 2021 03:17:24 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id r8sm2488194iln.35.2021.06.17.03.17.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 03:17:24 -0700 (PDT) Subject: Re: [PATCH net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load() To: Yang Yingliang , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: elder@kernel.org, davem@davemloft.net, kuba@kernel.org References: <20210617051119.1153120-1-yangyingliang@huawei.com> From: Alex Elder Message-ID: Date: Thu, 17 Jun 2021 05:17:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210617051119.1153120-1-yangyingliang@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/17/21 12:11 AM, Yang Yingliang wrote: > This node pointer is returned by of_parse_phandle() with refcount > incremented in this function. of_node_put() on it before exiting > this function. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Acked-by: Alex Elder > --- > drivers/net/ipa/ipa_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c > index 2243e3e5b7ea..f82130db32f6 100644 > --- a/drivers/net/ipa/ipa_main.c > +++ b/drivers/net/ipa/ipa_main.c > @@ -530,6 +530,7 @@ static int ipa_firmware_load(struct device *dev) > } > > ret = of_address_to_resource(node, 0, &res); > + of_node_put(node); > if (ret) { > dev_err(dev, "error %d getting \"memory-region\" resource\n", > ret); >