From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753684AbdJMGhO (ORCPT ); Fri, 13 Oct 2017 02:37:14 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56416 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753271AbdJMGhN (ORCPT ); Fri, 13 Oct 2017 02:37:13 -0400 Subject: Re: [PATCH] s390/pkey: fix kzalloc-simple.cocci warnings To: Vasyl Gomonovych , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com References: <1507751566-15948-1-git-send-email-gomonovych@gmail.com> From: Harald Freudenberger Date: Fri, 13 Oct 2017 08:36:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1507751566-15948-1-git-send-email-gomonovych@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17101306-0020-0000-0000-000003C062C8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101306-0021-0000-0000-00004253ED01 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-13_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710130092 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2017 09:52 PM, Vasyl Gomonovych wrote: > drivers/s390/crypto/pkey_api.c:128:11-18: WARNING: kzalloc should be used for cprbmem, instead of kmalloc/memset > > Use kzalloc rather than kmalloc followed by memset with 0 > > Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > > Signed-off-by: Vasyl Gomonovych > --- > drivers/s390/crypto/pkey_api.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/s390/crypto/pkey_api.c b/drivers/s390/crypto/pkey_api.c > index f61fa47..8dda5bb 100644 > --- a/drivers/s390/crypto/pkey_api.c > +++ b/drivers/s390/crypto/pkey_api.c > @@ -125,10 +125,9 @@ static int alloc_and_prep_cprbmem(size_t paramblen, > * allocate consecutive memory for request CPRB, request param > * block, reply CPRB and reply param block > */ > - cprbmem = kmalloc(2 * cprbplusparamblen, GFP_KERNEL); > + cprbmem = kzalloc(2 * cprbplusparamblen, GFP_KERNEL); > if (!cprbmem) > return -ENOMEM; > - memset(cprbmem, 0, 2 * cprbplusparamblen); > > preqcblk = (struct CPRBX *) cprbmem; > prepcblk = (struct CPRBX *) (cprbmem + cprbplusparamblen); applied, will be available with the next merge window. Thanks