From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C52C2D0EF for ; Thu, 16 Apr 2020 06:10:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D6D520771 for ; Thu, 16 Apr 2020 06:10:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436567AbgDPGKr (ORCPT ); Thu, 16 Apr 2020 02:10:47 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2379 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2407402AbgDPGKf (ORCPT ); Thu, 16 Apr 2020 02:10:35 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C34421E7C8418E60C631; Thu, 16 Apr 2020 14:10:25 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 16 Apr 2020 14:10:21 +0800 Subject: Re: [PATCH v5] f2fs: fix long latency due to discard during umount To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1586941673-4296-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Thu, 16 Apr 2020 14:10:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1586941673-4296-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/15 17:07, Sahitya Tummala wrote: > F2FS already has a default timeout of 5 secs for discards that > can be issued during umount, but it can take more than the 5 sec > timeout if the underlying UFS device queue is already full and there > are no more available free tags to be used. Fix this by submitting a > small batch of discard requests so that it won't cause the device > queue to be full at any time and thus doesn't incur its wait time > in the umount context. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks,