mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Jie Gan <jie.gan@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Mike Leach <mike.leach@arm.com>,
	James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@arm.com>,
	Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>,
	Abel Vesa <abelvesa@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 0/5] Fix traceNoC probe issue on multiple QCOM platforms
Date: Mon, 9 Nov 2026 10:46:44 +0000	[thread overview]
Message-ID: <dc798bed-85b4-4d47-87c3-f0e0f156ed0a@arm.com> (raw)
In-Reply-To: <42b832c0-5cbd-452f-a9f3-50355a008533@oss.qualcomm.com>

On 09/11/2026 01:25, Jie Gan wrote:
> 
> 
> On 7/10/2026 10:38 AM, Jie Gan wrote:
>> The CoreSight TNOC (Trace Network-On-Chip) binding so far only allowed 
>> the
>> two-string AMBA form "qcom,coresight-tnoc", "arm,primecell". That form
>> forces the device onto the AMBA bus, where the driver must read the
>> peripheral ID from the device registers during probe. On several QCOM
>> platforms this AMBA peripheral-ID probing fails, so the traceNoC device
>> never probes and its trace path is unavailable.
>>
>> This series drops the "arm,primecell" entry and turns "qcom,coresight- 
>> tnoc"
>> into a standalone platform compatible. Without "arm,primecell" the device
>> is created on the platform bus and probes through the platform driver by
>> compatible string, bypassing the AMBA peripheral-ID read while 
>> remaining a
>> fully functional Aggregator TNOC that allocates a system trace ID (ATID).
>>
>> The series is organized as: binding first, then the driver support for 
>> the
>> platform-bus compatible, followed by the per-platform DT fixes that 
>> switch
>> the affected nodes over to it.
>>
>> - Patch 1 (dt-bindings) drops "arm,primecell" and makes
>> "qcom,coresight-tnoc" a single standalone compatible, and updates the
>> example node accordingly.
>> - Patch 2 (driver) adds "qcom,coresight-tnoc" to the platform driver's
>> match table and renames the itnoc-specific names to generic tnoc names,
>> since the platform driver now serves both the Interconnect and Aggregator
>> TNOC. It also restricts the ATID-unsupported handling to
>> "qcom,coresight-itnoc" only, so the Aggregator TNOC on the platform 
>> bus is
>> no longer wrongly covered and correctly allocates a trace ID.
>> - Patches 3-4 (kaanapali, sm8750) drop the "arm,primecell" entry on the
>> traceNoC nodes and use the standalone "qcom,coresight-tnoc" compatible,
>> fixing the probe failure on those platforms.
>> - Patch 5 (glymur) switches the node from "qcom,coresight-itnoc" to
>> "qcom,coresight-tnoc". This node is actually an Aggregator TNOC (its
>> tn_ag_* endpoints show aggregation), so it should expose a system trace
>> ID rather than being treated as an Interconnect TNOC.
>>
> 
> Gentle ping.

Apologies for missing this. Please could you resend it based on v7.4-rc,
as this doesn't apply cleanly on coresight/next

Cheers
Suzuki


      reply	other threads:[~2026-11-09 10:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10  2:38 Jie Gan
2026-07-10  2:39 ` [PATCH v6 1/5] dt-bindings: arm: coresight-tnoc: Bind on platform bus instead of AMBA Jie Gan
2026-07-10  7:03   ` Krzysztof Kozlowski
2026-07-10  2:39 ` [PATCH v6 2/5] coresight: tnoc: Bind Aggregator TNOC on the platform bus Jie Gan
2026-07-10  8:40   ` Leo Yan
2026-07-10  2:39 ` [PATCH v6 3/5] arm64: dts: qcom: kaanapali: bind traceNoC " Jie Gan
2026-07-10  9:49   ` Konrad Dybcio
2026-07-10  2:39 ` [PATCH v6 4/5] arm64: dts: qcom: sm8750: " Jie Gan
2026-07-10  9:49   ` Konrad Dybcio
2026-07-10  2:39 ` [PATCH v6 5/5] arm64: dts: qcom: glymur: use Aggregator TNOC compatible Jie Gan
2026-07-10  9:50   ` Konrad Dybcio
2026-11-09  1:25 ` [PATCH v6 0/5] Fix traceNoC probe issue on multiple QCOM platforms Jie Gan
2026-11-09 10:46   ` Suzuki K Poulose [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc798bed-85b4-4d47-87c3-f0e0f156ed0a@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=james.clark@linaro.org \
    --cc=jie.gan@oss.qualcomm.com \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@arm.com \
    --cc=robh@kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=yuanfang.zhang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®