From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E1A73F077C for ; Fri, 10 Jul 2026 08:41:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783672895; cv=none; b=uVAU4KtlMlfIBhTCqZowY7a/38E7dm1ekfopqkkgY9j2k4dvUfu30Y1t78aLLIqlOROfG+/wSBOdJfy9yhBSbKpS1TtgEMNVM71OTzLUOXAXEDu4+ZwyiNmJppiToJWByJJl/UHiT+gNTKFcEF9mDTUWUP5iQ+azw8rsIVLE31w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783672895; c=relaxed/simple; bh=OI6vZMxTu6pN9CeOFlTYwvTpQF8ytBKQzoHYrEpHfxA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=CNyPYIQ4vU+90WItmMr7iSmUjFG/5a3NRg38v7wlb7tv/vsx5pCsRAEylUNpWp1Tw+fd9JAQqg0DUgf3khkhbUQkN3tCEd6jesbcKhDavRYhbLsO27Dg39i2UXRuCs6gTXwrFczHhCYoNUrStW2TpzqpM1N7dDh1Ep3NIJ3aAFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YBZDBdkT; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=M8gU1W1k; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YBZDBdkT"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="M8gU1W1k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783672893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OI6vZMxTu6pN9CeOFlTYwvTpQF8ytBKQzoHYrEpHfxA=; b=YBZDBdkTFnQRyP3NseX4c9Z8qW7I/L48TPPTnBLu3HN4f+xhrMUm1OcDGL+GEZpTgQjgz5 xu+HL7H5edsDx5NFED/qdUP4QPLhDzjTOPlA7YPGo4vwC1kgLE5uGUDzT2L6VBNEwyjOSX bHBkZd91PhyUPYF9phNvBpThNLYVaPs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607--ranaOY8N-CLZDOmDQIkgA-1; Fri, 10 Jul 2026 04:41:32 -0400 X-MC-Unique: -ranaOY8N-CLZDOmDQIkgA-1 X-Mimecast-MFC-AGG-ID: -ranaOY8N-CLZDOmDQIkgA_1783672891 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-493dc8408fdso5511845e9.1 for ; Fri, 10 Jul 2026 01:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783672891; x=1784277691; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=OI6vZMxTu6pN9CeOFlTYwvTpQF8ytBKQzoHYrEpHfxA=; b=M8gU1W1klufWB9YWST7wEF36H6mX13GXvY3B/lx/U9BpqR+9yfpqnwvkP8vzF447Qk ZH0gZVHx+X7hcdAgu3cyRVTbSieKEvEsxwsETpzcsBQC6wfTPN3dkiMb5Ha7EOKH1g/7 8kRAruzKLK8ZVVN6QGdMLIeJsXCqlyZbubodcoY3xO27WuYXmm/uhS5NjsB6izIqbpvF C6Gr10hDKwQgqmcX7UDu5tQI0Ym9Lzu7GKR4VLp3+GNFrN7KSfnDpjcTAwRdqXotRbwo +74YEuvola1RKJQN47JFg5rZLlQMPb6oD9PLBN6/N26pSsfRr4fKvJefTMGnoDbjBxNh Acmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783672891; x=1784277691; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=OI6vZMxTu6pN9CeOFlTYwvTpQF8ytBKQzoHYrEpHfxA=; b=Q0aMs+Cj/PbCF3qEpxGMKqakWX5cJTKAOax0s9ldKr1g7yqp0+mX7voaD4Aj4Pf0ak 6Snd1Rp8U2GxIweb0Kpkq/bZIzmK0t7eqiRhUxONHil/5owIeaoOTPgHQcp0rnYYtgZc JrQpTRMMugkPKSXK0Sd4zXhO5FUHdlXPpx53QMoFLj6n5inu2T48K+vL24j3y/UYLzqe xWxT1pNnlxVDtB+wsgbw/lKKogCMLkXzrxKWDosf9PDIKA8g6Fm9MnNi2VU8z2zOjimt fRQN6x37pBQyLedNPIHF3fLm4rle4qm/lYdJBLq1iy0Vxn1sowQqNIlqr/fLS6E8NGFP prHw== X-Forwarded-Encrypted: i=1; AHgh+RovZySDahu9Aqb0or13P/J2MP/py9w/Uyv9LcSinEiH4h0BqIsjv3POIbwwtA3Y5QYdxwCQnqK2+UOWrEg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8Yua4bF3vwQ8f0N5XD2rrpsEgCknN1GdnaEMpajns06fKgs1s eP/fLu0dk+ibwkjF6PME9Xyad7dcA2fSpkgdPsYGPl3gJHEo5vnsSDUjs3gzFY3ifZz5ihboiIq KlC9T9XlUCbYu2yRAThfXKrlRk3QVDsNvpUxe3pmvWVNdyJskC96dmCvkwoV7TN3IZg== X-Gm-Gg: AfdE7cmJKjVoSCySdjOEO2KjGA81igP5G7n9+s10yJePlgtqdCmasaSpLMCp//1gb9B 3oUtry7qLzGofL5yjRoeaDn9LkQMs0AyKtHxUYwQv1U4pbI0vuNtBDvBR25xc2tDL/LEFBX3Ke6 bqaRyIQlj9HMgtFglENeJOcEaXVP1YVyO3qi1y8DScmROkNv2/JoRbk5EL6yvzaFWCrAlbXBj/4 NhVhxFCD2O6LwyWTwMBVK97w5uagPA2SKtwPs14ft1WVPXX/VhQYN31R2+do1Ncx4ZDDc8kXN8h KZ69+YjgpQxkrKRKaQO3TcaogDj5dnkl+2aW497qjJsDQoImU0qUAF4PM7jKPEOFn+s+pOc7vdN r0wNdiqi8gVgXxaY6ziaZ21bBHRDoqLugPCLXRT/J5zqsfJ2gYl5JW41FBCV/zc+p88kmowmdKB xC0Coz X-Received: by 2002:a05:600c:828c:b0:493:bed9:b53d with SMTP id 5b1f17b1804b1-493e68ee07cmr92567735e9.31.1783672890916; Fri, 10 Jul 2026 01:41:30 -0700 (PDT) X-Received: by 2002:a05:600c:828c:b0:493:bed9:b53d with SMTP id 5b1f17b1804b1-493e68ee07cmr92567485e9.31.1783672890572; Fri, 10 Jul 2026 01:41:30 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6d53absm119685795e9.6.2026.07.10.01.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 01:41:28 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 16/17] selftests/verification: Rearrange the wwnr_printk test From: Gabriele Monaco To: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Weissschuh , Tomas Glozar , John Kacur , Wen Yang , Steven Rostedt , Shuah Khan , linux-kselftest@vger.kernel.org Date: Fri, 10 Jul 2026 10:41:26 +0200 In-Reply-To: <87zezzxt9a.fsf@yellow.woof> References: <20260625121440.116317-1-gmonaco@redhat.com> <20260625121440.116317-17-gmonaco@redhat.com> <87zezzxt9a.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-07-10 at 08:18 +0200, Nam Cao wrote: > Gabriele Monaco writes: > > Simplify the test and run the steps expecting no reaction before the on= e > > expecting reactions. >=20 > This requirement is not clear from the code. I fear a new developer who > wants to introduce a new test case will easily trip over this, or even > us a few months from now. >=20 > Instead of this, how about each test case discards or ignores all > previous reactions? Fair points, the issue is that we are hammering wwnr, on some systems we ma= y still see printks for long after the monitor was disabled, I tried that gre= p -m1 trick to mitigate that. To ignore all previous reactions reliably we need to wait for the buffers t= o flush, something like waiting for a full second for nothing new on the ringbuffer perhaps. I could think of that or at least make this more clear = with comments. Thanks, Gabriele