mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>
Cc: John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>, Mike Leach <mike.leach@arm.com>,
	Leo Yan <leo.yan@linux.dev>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Suyash Mahar <smahar@meta.com>, Amir Ayupov <aaupov@fb.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] perf: cs-etm: Don't add global v0 HW_IDs to unformatted queues
Date: Thu, 1 Oct 2026 11:34:11 +0100	[thread overview]
Message-ID: <dc7a2922-bee7-42d1-b4a0-7469cd06f4b5@linaro.org> (raw)
In-Reply-To: <20260904164309.GZ8904@e132581.arm.com>



On 04/09/2026 17:43, Leo Yan wrote:
> On Fri, Aug 21, 2026 at 10:50:29AM +0100, James Clark wrote:
>> In the case of mixed formatted and unformatted trace with v0 HW_IDs, or
>> no HW_IDs at all resulting in the cs_etm__map_trace_ids_metadata()
>> fallback, formatted queues will write their HW_IDs to unformatted
>> queues.
> 
> I understand a session can support multiple sinks, but I don't expect
> to mix up formatted and unformatted trace (see sinks_compatible()).
> 

But sinks_compatible() is only called multiple times for per-thread 
sessions. For per-CPU, userspace opens separate events per-CPU. If the 
user doesn't specify a sink then the default one is chosen which can be 
a different type for each CPU/path.

> For the mentioned fallback, I am also struggling to establish a case.
> Even AUX_OUTPUT_HW_ID records are absent randomly, I don't think this
> impacts the queue's format initalization, no?

The fallback uses the metadata only, without sink information, which is 
equivalent to v0 records. So it's just another way to trigger the same 
problem.

If you're using global v0 mappings, then we assume that all trace IDs 
are possible in all queues, which results in multiple decoders being 
created and triggers an error in OpenCSD once it sees that being 
combined with unformatted.


  reply	other threads:[~2026-10-01 10:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  9:50 [PATCH 0/6] perf: cs-etm: HW_ID improvements James Clark
2026-08-21  9:50 ` [PATCH 1/6] perf: cs-etm: Don't add global v0 HW_IDs to unformatted queues James Clark
2026-09-04 16:43   ` Leo Yan
2026-10-01 10:34     ` James Clark [this message]
2026-08-21  9:50 ` [PATCH 2/6] perf cs-etm: Free partially created queues James Clark
2026-09-04 17:12   ` Leo Yan
2026-10-01 10:40     ` James Clark
2026-08-21  9:50 ` [PATCH 3/6] perf cs-etm: Synthesize missing HW_ID mappings for raw trace James Clark
2026-09-04 17:29   ` Leo Yan
2026-10-01 12:55     ` James Clark
2026-08-21  9:50 ` [PATCH 4/6] perf: cs-etm: Respect --no-itrace option James Clark
2026-08-24  9:53   ` Adrian Hunter
2026-09-04 17:45   ` Leo Yan
2026-10-01 12:57     ` James Clark
2026-08-21  9:50 ` [PATCH 5/6] perf/core: Return errors from perf_report_aux_output_id() James Clark
2026-08-21  9:50 ` [PATCH 6/6] coresight: perf: Retry failed HW_ID writes James Clark
2026-08-21 10:01   ` James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc7a2922-bee7-42d1-b4a0-7469cd06f4b5@linaro.org \
    --to=james.clark@linaro.org \
    --cc=aaupov@fb.com \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=irogers@google.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=smahar@meta.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®