From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759115AbcIXHk0 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 24 Sep 2016 03:40:26 -0400
Received: from mail-pf0-f196.google.com ([209.85.192.196]:35549 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753261AbcIXHkZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 24 Sep 2016 03:40:25 -0400
Subject: Re: [PATCH V3] clocksource/timer-imx-gpt: Preventing resource leakage
 in error case.
To: Thomas Gleixner <tglx@linutronix.de>
References: <1474631874-5777-1-git-send-email-arvind.yadav.cs@gmail.com>
 <alpine.DEB.2.20.1609231831170.5640@nanos>
Cc: baohua@kernel.org, daniel.lezcano@linaro.org,
        LKML <linux-kernel@vger.kernel.org>
From: arvind Yadav <arvind.yadav.cs@gmail.com>
Message-ID: <dc7aa0af-8788-2159-8f87-5810e88aead1@gmail.com>
Date: Sat, 24 Sep 2016 13:10:19 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1609231831170.5640@nanos>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for help and suggestion.
I am looking 'Documentation/SubmittingPatches'.

Thanks
	-Arvind Yadav


On Friday 23 September 2016 10:11 PM, Thomas Gleixner wrote:
> On Fri, 23 Sep 2016, Arvind Yadav wrote:
>
> So last time (V2) you had a almost perfect subject line:
>
>    clocksrouce/timer-imz-gpt: Prevent resource leaks in error path
>
> The only issue was the clocksrcouce typo. Now you made it:
>
>    clocksource/timer-imx-gpt: Preventing resource leakage in error case.
>
> Documentation/SubmittingPatches says:
>
>   Describe your changes in imperative mood ... as if you are giving orders
>   to the codebase to change its behaviour.
>
>   "Preventing" is not imperative and the above is not a proper sentence,
>   while the V2 one is.
>
>>   	ret = _mxc_timer_init(imxtm);
>> -	if (ret)
>> -		return ret;
>> +	if (ret) {
>> +		goto error_iounmap;
>> +	}
> Further Documentation/SubmittingPatches also tells you which tools to use
> _before_ submission. If you'd used them then the above change would look
> different. You surely can figure that out yourself.
>
> Thanks,
>
> 	tglx
>
>