From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/4] memory: fsl_ifc: Fix optional NAND IRQ handling and migrate to platform IRQ API
Date: Wed, 9 Sep 2026 08:00:07 +0200 [thread overview]
Message-ID: <dc7c1fb8-9d01-4d1c-abcd-1bddd70edecb@kernel.org> (raw)
In-Reply-To: <CAKxU2N-xfKn_AChcAse_nxFBznxog+OLYW2htBwKHd_Mxk0BUA@mail.gmail.com>
On 06/09/2026 20:34, Rosen Penev wrote:
> On Tue, Sep 1, 2026 at 8:29 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> dev_set_drvdata(&dev->dev, NULL);
>>> @@ -204,9 +202,21 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
>>> int ret = 0;
>>> int version, banks;
>>> void __iomem *addr;
>>> + int nand_irq;
>>> + int irq;
>>
>> Why do you need the intermediate variables?
> In order to call platform_get_irq before any allocation happens in probe.
>>
But allocation is the first thing the probe is doing.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-09 6:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 20:24 [PATCHv2 0/4] memory: fsl_ifc: Switch to modern devm and platform IRQ APIs Rosen Penev
2026-07-21 20:24 ` [PATCHv2 1/4] memory: fsl_ifc: Fix optional NAND IRQ handling and migrate to platform IRQ API Rosen Penev
2026-09-01 15:29 ` Krzysztof Kozlowski
2026-09-06 18:34 ` Rosen Penev
2026-09-09 6:00 ` Krzysztof Kozlowski [this message]
2026-09-09 22:33 ` Rosen Penev
2026-09-10 6:28 ` Krzysztof Kozlowski
2026-07-21 20:24 ` [PATCHv2 2/4] memory: fsl_ifc: Use devm_platform_ioremap_resource and fix error paths Rosen Penev
2026-09-01 15:34 ` Krzysztof Kozlowski
2026-07-21 20:24 ` [PATCHv2 3/4] memory: fsl_ifc: Use devm_request_irq and simplify remove Rosen Penev
2026-07-21 20:24 ` [PATCHv2 4/4] memory: fsl_ifc: drop simple-bus emulation Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc7c1fb8-9d01-4d1c-abcd-1bddd70edecb@kernel.org \
--to=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®