From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CA0A3F4DD2 for ; Tue, 2 Jun 2026 17:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780420219; cv=none; b=qGomejr4jH+x17JhKBGXzWPk0eSJrxXYQvmuMv03fmX25Dz3XnLAfQJawcZwS46BWPXWxM3X4O6MfwBmEJIU0tstUXQqAMywZ3j4o0WuyFqjIBSlE7u+reLfR1xMXTerkuxEVHWavK7yQv9eVogNtBoLZ72w/AXgdvu6LC7LNhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780420219; c=relaxed/simple; bh=EtD5/9vaC69fMoxqqSkuAD764a7iBGKyoM1iNno7R5I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=edRW9LhCTgJbd74teFf9Ne2+mYtQrRwWhEcza21gVYRk8p7XE0kR0nsbzRK1qvObEsxBlKrf8U529Z/8WHCth5JdC1ZndmXxPiGcD+jSIyNeaM502pyh5wj9CxNHpCClDkPc13yn8IE/p1cODnqymSJnG24kwHZ+wdA+Y6HW7vQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RvGqCcDN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Nt/oCSDh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RvGqCcDN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Nt/oCSDh" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 652CpddL2884844 for ; Tue, 2 Jun 2026 17:10:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0WnpHurriknASg1CchB30qt7X0mCuqO6Pf6V96jiWis=; b=RvGqCcDNYtozPEiS CYLS/1v9wUP7ra0dhlJpkOOhOO9laDsk8pM9hPeXxK2WSDfiJHmrX7eFDeIFjW3R Vgw8CYBJaPcJFi2nEQU4j38RE6pFJj87Loajsn/11q7Ti2dR1likcCeJs92naRtY Q9lv2IuUqBxXxgwp9gDI3i2H/qdn7wzTWmWW3xr1EQ423C8Rhv+53dkRve0d+xBy Eph0XrYHFm+6BXqeZQAtX0KWK+FIA4NgaCjGLSZikyRuE6b9oDJ1jbk1D0Ec7M5C CcRXcOkAQDdJZe/GvFazntD3eFruKEWa6xGnpg/FtEAdzmtYkc9uy+3qxq4zvwAT RUqbOQ== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehsu12nj2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 17:10:17 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-3074d4102a9so191820eec.0 for ; Tue, 02 Jun 2026 10:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780420216; x=1781025016; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0WnpHurriknASg1CchB30qt7X0mCuqO6Pf6V96jiWis=; b=Nt/oCSDhNGmsmrkMaH0GkqEZqYaFqXpOO+IFZALgzkcptqSqb6TvX1MItJ229nFLdv UinuTX/mrV7odMhIKU+BLud31w1UNHPRkjujF1Vqd8Du0KxFVzFh0hSVVIqGLJbXHKcF +6tPTkuXZu/e6VWGmDRe1Mv9Hz092U+OLqfMhkExrbhsAwlYQD6UiPSE4AS/Qlae/7ec SoY+jP30afLqKDRg/8hpgh9AnwwNA5wxkKN3ZC9gnW2lQjPKcD8AoqIQghoAjGNqtiqE Hh05FOJdb111kkrHLkOPLviEezfQTeBlH3IHB9qADZSRVDOzsL2bQKKHJ2usTMJBz00c sKQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780420216; x=1781025016; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0WnpHurriknASg1CchB30qt7X0mCuqO6Pf6V96jiWis=; b=NKlxYsmPpDwvhon1GxsMV63dQPYM0wPviCB9lo+WGABds/cn+h/GBWg7o2LPjxgM3s 68h51aWd1pb7lxwex6S0svadagbNgL8VDmMvLNEF2wR2YGVBS2U86CiyoumE4wSFo1Au SqPcpM5CRcz9NqZY96vIKYOajqnFRfNaIcz5T/6JWFCk5Cj00oenyJhrT8+xSQD0e+Y3 R+zEvhe7srRUzY80RHlwFlzYxK3QIk0icMl9wPnnceuEwmVWSxswgHWptKY0f0HJyrK/ PetUPU3p8g+AsXCs3+9E2utE2Pc8xf5lO6go5OX+RPLeoAqHqdIOhSn6durVZ3Sd39xo FHcA== X-Forwarded-Encrypted: i=1; AFNElJ9OXzZMMh64LbzaFDQPYpW7lVKjFHNLBD7PSC+MsEsuSJVoIq1JtX27+pegdoNz/RDK2qjz4DY58MzIq/8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb+CiSEocWQtadpXskd/MZR0HPv4zJGHNlpX0LaHe33Mjt9TJA jEn8Q/EyPRo2BcACEDaqa0Nbd7t2uEua/KByAJe2Knxc5myG90GNbE39Np01Ug+nT1OOETyEOvL J4jNG2Cyg1rbYoHG2mabFoZLcW2wCIYj4ob76aXKFGbYaCVr3H43q8PyzqwjrxQUAlB0= X-Gm-Gg: Acq92OESeWLSEiOnpkeFlJicP0pHeQjsD63yWbtu8FRRqPUo8e9UGs5G0yrTw2tCPVZ 47Ig4xTEO+InJjchxCrsBn2lJlv7kIfhefK7cWK4YqD67249TEr8jLz7gaCvckYfcl+zM2EqgtO brLDEt8nkldum+sA0ppPeO4gJHW2Z0pLjzUzPdHoEs9OVTXRpIahX4gvfRLWvBMCAlXZy4v6cP0 1zkvFFlvoGslYWTa2SKfAr+ntTha69/9qYSvqsE3FmBJaGWvQ0QxtH4fsXptL6YsMhf7oUzA9Jg T/tSpcPikwWzMAMdzImfSc8AcFEVGPmUleXMoQo1Y4aG145Kz2ipKQ3dj+7seLXMjAYBNFYHH+t Hk2LTG1tZjlz4vLF9PaYmblwAPBeikQimRLX5k9XdtH5LBFr0Pud8PjtOauvvQti9EhLjGbTTM5 rk+JeJt1zJHJkTQpWoonipYxdu X-Received: by 2002:a05:7300:ef83:b0:304:ba84:a0cc with SMTP id 5a478bee46e88-304fa74682bmr8020151eec.33.1780420216458; Tue, 02 Jun 2026 10:10:16 -0700 (PDT) X-Received: by 2002:a05:7300:ef83:b0:304:ba84:a0cc with SMTP id 5a478bee46e88-304fa74682bmr8020119eec.33.1780420215911; Tue, 02 Jun 2026 10:10:15 -0700 (PDT) Received: from [192.168.1.59] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-304ed53f002sm12470560eec.18.2026.06.02.10.10.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 10:10:15 -0700 (PDT) Message-ID: Date: Tue, 2 Jun 2026 10:10:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/3] PCI: Add device-specific reset for Qualcomm devices To: Jose Ignacio Tornos Martinez , bhelgaas@google.com, alex@shazbot.org Cc: jjohnson@kernel.org, mani@kernel.org, linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, mhi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260602160024.1171949-1-jtornosm@redhat.com> <20260602160024.1171949-3-jtornosm@redhat.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260602160024.1171949-3-jtornosm@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 83FdWY6PTKL0RCHJGOFAwGqNfB1mf-Ld X-Proofpoint-GUID: 83FdWY6PTKL0RCHJGOFAwGqNfB1mf-Ld X-Authority-Analysis: v=2.4 cv=MKFQXsZl c=1 sm=1 tr=0 ts=6a1f0e79 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=_dsfnS01iu48ROCZzqsA:9 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDE2NSBTYWx0ZWRfXwlQM+5+/DJMa MmTb8oBkovkYOHExOD2IJNXeA1yqJvNzhqhedl2BXMzRfzUTU4QNTcgcTiPp2d/K8VGJeLCdxaT 3vX27bIdq1x0V1BxMXvSaDh3JKJBWeCP/jMUqdEuo1EYTktax4XUNsqL0HgOZCcYN+4ATSSlHgz e/fkgoTm6MWDmS+NfjoPAB1Kyr833acux+bGID92m3txLQlSCb3YPFoX1oZBTdyP0rvZ+C+jBH2 DkinZKs2QDOa1gMJCO4cvBFonAGtiM9+cHdyv3Wbfbih/76AoPDRvGJzAku7z0yh6zCXHV8sQi/ x5+CdGFNzRHNt00/Z+bydQCgK56JEAzIAPwzTzDePbpXlwtEx3shYb9rMCVVAVhzciTFOSqfo7s 3lOsG8zdIYykPhTR1hbHT1C0UKpH1ZnaAsJvy0Fz07NJjacxJdM3+T6TqDzZksBQgtYVqJ/RKPK jN2Vt8jNhExbeHSTFeQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-02_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020165 On 6/2/2026 9:00 AM, Jose Ignacio Tornos Martinez wrote: > Some Qualcomm PCIe devices (ath11k WiFi, ath12k WiFi, SDX62/SDX65 modems) Throughout your series you refer to ath11k and ath12k as if they are devices. They are not. They are device drivers, each of which supports a large number of devices. > lack working reset methods for VFIO passthrough scenarios. These devices > have no FLR capability, advertise NoSoftRst+ (blocking PM reset), and have > broken bus reset. > > The problem manifests in VFIO passthrough scenarios: > > - ath11k WiFi (17cb:1103): Normal VM operation works fine, including 17cb:1103 is WCN6855 > clean shutdown/reboot. However, when the VM terminates uncleanly > (crash, force-off), VFIO attempts to reset the device before it can > be assigned to another VM. Without a working reset method, the device > remains in an undefined state, preventing reuse. > > - ath12k WiFi (17cb:1107): Same behavior as ath11k. 17cb:1107 is WCN7850 > > - SDX62/SDX65 5G modems (17cb:0308): Never successfully initialize even > on first VM assignment without proper reset capability. ... > @@ -4252,6 +4268,9 @@ static const struct pci_dev_reset_methods pci_dev_reset_methods[] = { > reset_chelsio_generic_dev }, > { PCI_VENDOR_ID_HUAWEI, PCI_DEVICE_ID_HINIC_VF, > reset_hinic_vf_dev }, > + { PCI_VENDOR_ID_QCOM, 0x1103, reset_d3cold_d3hot }, /* ath11k */ s/ath11k/WCN6855/ > + { PCI_VENDOR_ID_QCOM, 0x1107, reset_d3cold_d3hot }, /* ath12k */ s/ath12k/WCN7850/ > + { PCI_VENDOR_ID_QCOM, 0x0308, reset_d3cold_d3hot }, /* SDX62/SDX65 */ > { 0 } > }; > same guidance applies to the 3/3 patch /jeff