From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688DAC433FE for ; Mon, 24 Jan 2022 06:39:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232289AbiAXGjn (ORCPT ); Mon, 24 Jan 2022 01:39:43 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:36430 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229788AbiAXGjm (ORCPT ); Mon, 24 Jan 2022 01:39:42 -0500 X-UUID: e0731d60e70742ac87e0b2356132db18-20220124 X-UUID: e0731d60e70742ac87e0b2356132db18-20220124 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 152998873; Mon, 24 Jan 2022 14:39:36 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 24 Jan 2022 14:39:35 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 Jan 2022 14:39:34 +0800 Message-ID: Subject: Re: [PATCH v21 3/8] soc: mediatek: SVS: introduce MTK SVS engine From: Roger Lu To: AngeloGioacchino Del Regno , Matthias Brugger , Enric Balletbo Serra , Kevin Hilman , Rob Herring , Nicolas Boichat , Stephen Boyd , Philipp Zabel CC: Fan Chen , HenryC Chen , YT Lee , Xiaoqing Liu , Charles Yang , Angus Lin , Mark Rutland , Nishanth Menon , , , , , , , Guenter Roeck Date: Mon, 24 Jan 2022 14:39:34 +0800 In-Reply-To: <63d8884d-d02d-53f9-8524-4a074ca5bfea@collabora.com> References: <20220107095200.4389-1-roger.lu@mediatek.com> <20220107095200.4389-4-roger.lu@mediatek.com> <63d8884d-d02d-53f9-8524-4a074ca5bfea@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi AngeloGioacchino, Sorry for the late reply and thanks for the advice. On Fri, 2022-01-07 at 15:33 +0100, AngeloGioacchino Del Regno wrote: > Il 07/01/22 10:51, Roger Lu ha scritto: > > The Smart Voltage Scaling(SVS) engine is a piece of hardware > > which calculates suitable SVS bank voltages to OPP voltage table. > > Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck > > when receiving OPP_EVENT_ADJUST_VOLTAGE. > > > > Signed-off-by: Roger Lu > > --- > > drivers/soc/mediatek/Kconfig | 10 + > > drivers/soc/mediatek/Makefile | 1 + > > drivers/soc/mediatek/mtk-svs.c | 1446 ++++++++++++++++++++++++++++++++ > > 3 files changed, 1457 insertions(+) > > create mode 100644 drivers/soc/mediatek/mtk-svs.c [snip] > > + > > +struct svs_platform_data { > > + char *name; > > + struct svs_bank *banks; > > + bool (*efuse_parsing)(struct svs_platform *svsp); > > + unsigned long irqflags; > > + const u32 *regs; > > + u32 bank_max; > > + int (*probe)(struct svs_platform *svsp); > > +}; > > + > > Please move the definition of struct svs_platform_data at the beginning of > the file for increased readability. Okay. I'll move them at the beginning of the file in the next patch. > > With that done, > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com>