From: Randy Dunlap <rdunlap@infradead.org>
To: Sean Anderson <sean.anderson@seco.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Peter Korsgaard <jacmet@sunsite.dk>,
kernel test robot <yujie.liu@intel.com>
Subject: Re: [PATCH] tty: serial: uartlite: Document uartlite_data in kernel-doc style
Date: Mon, 6 Nov 2023 12:45:54 -0800 [thread overview]
Message-ID: <dc85784d-c96c-45a4-bbfa-036f535b048f@infradead.org> (raw)
In-Reply-To: <20231106152428.3641883-1-sean.anderson@seco.com>
On 11/6/23 07:24, Sean Anderson wrote:
> Use @ and - to conform with kernel-doc style.
>
> Reported-by: kernel test robot <yujie.liu@intel.com>
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
Greg will probably just wait to apply it sometime after the current
merge window closes. At least that's been my experience.
> ---
> I have no idea what phase of release the kernel is in. If it is too
> late/early in the cycle, please just review this at the appropriate
> time. This patch is unlikely to need rebasing, and I am unlikely to
> remember to send it later.
>
> drivers/tty/serial/uartlite.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 404c14acafa5..e586d7aeac98 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -62,11 +62,11 @@ static struct uart_port *console_port;
> #endif
>
> /**
> - * struct uartlite_data: Driver private data
> - * reg_ops: Functions to read/write registers
> - * clk: Our parent clock, if present
> - * baud: The baud rate configured when this device was synthesized
> - * cflags: The cflags for parity and data bits
> + * struct uartlite_data - Driver private data
> + * @reg_ops: Functions to read/write registers
> + * @clk: Our parent clock, if present
> + * @baud: The baud rate configured when this device was synthesized
> + * @cflags: The cflags for parity and data bits
> */
> struct uartlite_data {
> const struct uartlite_reg_ops *reg_ops;
--
~Randy
next prev parent reply other threads:[~2023-11-06 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 15:24 Sean Anderson
2023-11-06 20:45 ` Randy Dunlap [this message]
2023-11-21 4:45 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc85784d-c96c-45a4-bbfa-036f535b048f@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jacmet@sunsite.dk \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sean.anderson@seco.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®