From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B478F47799D for ; Fri, 15 May 2026 11:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778843379; cv=none; b=XgWcbvXdPu+Vk10bFlo4fi/mZeIEStNEnW/PbyoCoSaSt2ndCfqOUYwDxkGHYtMy9MtF6v2eawQusQdT9E7YSdhab+LamOS7gVBCTHc9fHENCD/jbmoSXnfPHKVe5OCSyFMDUVL4kIkIarWOs0qhnU7lFWFEyaWHB7/NPyKpKeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778843379; c=relaxed/simple; bh=drOaZU4ycDJzaI5EMDnNtFwnSocXqA53ZlNwvBAN9IA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tGwZuyDgUKmmTvipGBCSMgP9cz/o6TDLlbWgLTcWh8gpxhcYM0tOs63DWAqR9U2P/mjmu5creGYrkoyAAldtQA2aIGXv6uMwDa/plabj0tGJMmYYkkEyE55trSOyfF0iv8xpQBZPDT5/ycTUxEQLB01A6GNl1cZEkLz0uErdMQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z3OZMR/x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MuoCk2Av; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z3OZMR/x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MuoCk2Av" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F5X5Y13514759 for ; Fri, 15 May 2026 11:09:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= smHaQRf2PotzKGQNp55ek4h21N45u+3lfeYBM6Exau8=; b=Z3OZMR/x3B6wBihE vzFeZiurGmbf9kf4QbAYq0mLvtmYfmWm2RyE8l4vpLlkipQXLRrqJseYwDMv1jsj qtM5pUK8qbIT3W3s9O+HjRJZ2wTnlbQ+6ONpHPYwc2Wn2/aZ9Vs4OQK7OuoGRlGh 6NmM+j9Cv1V2KP+95QLXjkpljRhOcxlPZee4sLGiiOaL2u3Pfzir2O5oOGPdMLPT Yw/0CMPfjz0wmiPKVrmqhN8Weky5je10FkeihosAok5LVF5kpcu7nd4VHtk+ieXE YkuVXNMmtmGhkUzO8qRCMG9ZaAi3SpFdmK3guHQSmErx/8ebHQYD8kH9TA67NhI/ y/0hfg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1vaymc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 11:09:35 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50d890580e1so156745161cf.3 for ; Fri, 15 May 2026 04:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778843375; x=1779448175; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=smHaQRf2PotzKGQNp55ek4h21N45u+3lfeYBM6Exau8=; b=MuoCk2AvOU8MUjItVtNXC8IUL3F9Wu39rjRVLqqnewbLCQiM+y52ksHx59VoH4BtEm C0SqcN0X3AC8K0JN0NL+okGbOoKJP2GCCAGoxlJ9ScZ+xINEMOX7v/2NgTO3CpbClCFz OppNN9Wvip1yUX5W1a6FmLteIGwHPfT5Sl1Ownx8Y6F5oilklf0wUvEElHwC5wlSKxpR ex50nf3UW4ov7crawFe5RbzweEKfkSY71XhA8v1mgDKr51NIITUqEBz5Ztvoc9PWPcgk pAo9rBUOyJxQF9y3qtYh219iWFP/S2W1+KcX4Q9pCJDcsrCcQTf5p+9eJ6vuYJZCZZn5 puDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778843375; x=1779448175; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=smHaQRf2PotzKGQNp55ek4h21N45u+3lfeYBM6Exau8=; b=tHbUFjxYOVJKSBrUOH6G5G2aSxBrZAih1WQI2X7652m45gwHBomhtoB50wzTYfsDvx oWrJmPmPI0uSr6dJooQb3MRlQaRTK5mbH9Q8AA134AFK5J3zY2Ce+k2vpS9tb23pHh4F SMmOKatLIZmwoCU+XtMrowCzJ5nEG1ZkMH9JBalsCkmtN6uuOcgpiKSKwt+V8TeqCJ6g vugJDx/NvyF8g5jd6fTRnewOI1OYOzxmSi5p8plFupDsuQ7B1EKIUUHXv4JIDh/QHm86 AbzJA2TbZP6Oq9QXv+Yso/A2Pj3a6i2cYAh+W2EC8hfl0yEGF5812pCxRn8HdKWJLCtF 10dQ== X-Forwarded-Encrypted: i=1; AFNElJ9oLdkoE8s/3Ful+qwdtu5axKDs9Vx/x3fjWO46/bDtcBh+VZn+ItnUodlfbPJWoulgKFBIRBlO+Z0V0uA=@vger.kernel.org X-Gm-Message-State: AOJu0YyHCvvXuZsShh/7KsF7F+ztYImCysnSgVWrQruatcuh6et6JZ9n zkRZL+CHBoHf4ORJQcpXN9eYQpJlY0nP11Uk9Wh3GDAhI+BK0iEVRABzdrdclrkWQsX4dxD7qHw N1T30m8KajwYPq7arxr31HM5hLRLDr45a1Uxe3kA+Eeh8bNcPER8m8jvgwiVsRnxNSC4= X-Gm-Gg: Acq92OEw0OsyhRbB31wd24TzTnyMiO9WlmYdVVYrZ3XOZqG/AUwi/oUDXZ5yazzdB0S JQdb/vvm9KIYT8gfY00xQM3xNMT8s88++IWbES2Qqlq+AwKvn7tSgaE9LbcrxChV20CyRNyOE0R eNj73Y4WZUjkIrhjuCDpV7H4CByusiKFbV3WzpXx7hsxQAXukQ3aBH/AUZsYg97VzAK3NxKnOEs ZAioHfYcSQQBPETL8oPOg4iMtgfICbLObk+UH8QRV+MVtbnfSiDipfqYiShrG2QXVzLi+ZHYp3Z MiVgQSn2j9QK2T41EFWh3SJAv64VWaBpY5IydrYFi0o23ielFXoVZak2RkwsEsvjoqQ6IU3nCJ3 h38OGHau7wxvXNT6twsO/GCzU9bQVqoit2w4P8kPHBvwYHtSji1aF3NgheD0oxN95HHlO6vsvBa N2tz36ht8P+cPDoWF3CVs+eIM9PyQL+TSxfBfxWkX5jSUIEdK7ewtrEVO660KtAMtshA8CkZufi rs= X-Received: by 2002:a05:622a:480b:b0:50e:df54:c36d with SMTP id d75a77b69052e-5165a057fd4mr44963211cf.18.1778843374905; Fri, 15 May 2026 04:09:34 -0700 (PDT) X-Received: by 2002:a05:622a:480b:b0:50e:df54:c36d with SMTP id d75a77b69052e-5165a057fd4mr44962671cf.18.1778843374442; Fri, 15 May 2026 04:09:34 -0700 (PDT) Received: from ?IPV6:2001:14bb:c6:df5c:d8ed:c370:3eee:b864? (2001-14bb-c6-df5c-d8ed-c370-3eee-b864.rev.dnainternet.fi. [2001:14bb:c6:df5c:d8ed:c370:3eee:b864]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3945c8c8415sm14724911fa.11.2026.05.15.04.09.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 04:09:33 -0700 (PDT) Message-ID: Date: Fri, 15 May 2026 14:09:31 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260428-c630-fix-idle-v1-1-29d0da326eb3@oss.qualcomm.com> <57696ca6-42ce-46d6-9b30-cd5ad4378e25@oss.qualcomm.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDExMiBTYWx0ZWRfXx0rkNdMSLnUT Tg/h1Lz6i/JeOW5YSf6LuP8fQuVSocqhm+E4+tbzZKXY++gGrHYF//vTZd4rUK0oKFnmFzRPFBR aadLthwOtlUMwwUk3Z4DIY8nUM1UuGo7XKV2Af5pm4PgvJiNY1J5yMOoXkmLL7a0+PVNUg7Cx/P TXJY7/8N4fuKolh8pdS5d/0PB8t/gIMRddxkvO1UKBLkgZuV+hiWHh4UscD1lIvq1bkTpiaDPly 2NYOER3E973pniVA4k4JRWnG9XYqOiUgHaEOx1BfNCLk+vtkzrpZ7s8V6kitMbaM/L9jqfhi7fH i7D+OO/NQv62+u6P6Z0n9DeSNSCj7atGBn7A2oGp0vXGt9TcnvSMWwl8eJwUGaXLlAxWf+SODP5 QlcrW1ipSjDqb4mfqYwMWj4ZRt0hON3PsP/T4MSTVb40I5ueFI6SFHofZcoyVIFjftDRyGJjr6s hLh1WMu7C7qgD0ojjAg== X-Proofpoint-GUID: Ll-VfKDmyB_jpIkq-iyKWI1HEAXTkCoM X-Proofpoint-ORIG-GUID: Ll-VfKDmyB_jpIkq-iyKWI1HEAXTkCoM X-Authority-Analysis: v=2.4 cv=BvqtB4X5 c=1 sm=1 tr=0 ts=6a06feef cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=pouD296ARJvTD37ZcawA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150112 On 15/05/2026 14:03, Konrad Dybcio wrote: > On 5/15/26 1:01 PM, Dmitry Baryshkov wrote: >> On 15/05/2026 14:00, Konrad Dybcio wrote: >>> On 4/28/26 9:36 PM, Dmitry Baryshkov wrote: >>>> With the default PSCI suspend value for cluster idle state Lenovo Yoga >>>> C630 isn't stable enough. For example it might reset if display device >>>> isn't probed early enough. Drop one of the bits from the PSCI suspend >>>> value to make C630 work in stable way. >>>> >>>> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI") >>>> Signed-off-by: Dmitry Baryshkov >>>> --- >>>>   arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++ >>>>   1 file changed, 4 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts >>>> index e41200839dbe..e6c67016552a 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts >>>> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts >>>> @@ -347,6 +347,10 @@ &cdsp_pas { >>>>       status = "okay"; >>>>   }; >>>>   +&cluster_sleep_0 { >>>> +    arm,psci-suspend-param = <0x41003244>; >>>> +}; >>> >>> Is it better if you do hack in a >>> >>> qmp_send(qmp, "{class: cx_mol, res: cx, val: mol}"); >> >> Any clarification? Then I can try hacking it in. > > This will send a message to AOSS to intrusct it to prevent CX from > collapsing This sounds like a dirty hack. I think, hacking psci-suspend-param is a lesser evil. I know that we should spend time on understanding, what should vote on CX instead, but having the issue only on C630 doesn't really help. Maybe it will go away once I can sort out the gcc / dispcc / mdss issue on SDM845 & SM8150. > > You'd need this somewhere early enough so as not to crash > > alternatively, the good ol' > > diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c > index 6d5bbeda0689..2fea94618839 100644 > --- a/drivers/interconnect/qcom/sdm845.c > +++ b/drivers/interconnect/qcom/sdm845.c > @@ -1786,7 +1786,7 @@ static struct platform_driver qnoc_driver = { > .driver = { > .name = "qnoc-sdm845", > .of_match_table = qnoc_of_match, > - .sync_state = icc_sync_state, > + //.sync_state = icc_sync_state, > }, > }; > module_platform_driver(qnoc_driver); > > > should give you a similar result > > Konrad -- With best wishes Dmitry