From: Joe Perches <joe@perches.com>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>,
kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: megaraid: Remove unnecessary assignment to variable ret
Date: Tue, 25 Aug 2020 00:06:26 -0700 [thread overview]
Message-ID: <dc8aca7e3772670782c2abc086cab8b6f81be3c1.camel@perches.com> (raw)
In-Reply-To: <5e8d3765063043f7a90c92c098317319757595ed.camel@perches.com>
On Tue, 2020-08-25 at 00:01 -0700, Joe Perches wrote:
> On Tue, 2020-08-25 at 14:38 +0800, Jing Xiangfeng wrote:
> > The variable ret is being initialized with 'FAILED'. So we can remove
> > this assignement.
>
> If you are going to change the code at all,
> might as well try to improve it more by removing
> the unnecessary out: label altogether.
Looks like the megaraid mailing list is either subscribers-only
or doesn't exist anymore as my mail to it bounced.
One of the maintainers should remove it or update it.
Maybe:
---
diff --git a/MAINTAINERS b/MAINTAINERS
index ac79fdbdf8d0..0c181cd07201 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11060,7 +11060,7 @@ MEGARAID SCSI/SAS DRIVERS
M: Kashyap Desai <kashyap.desai@broadcom.com>
M: Sumit Saxena <sumit.saxena@broadcom.com>
M: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
-L: megaraidlinux.pdl@broadcom.com
+L: megaraidlinux.pdl@broadcom.com (subscribers-only)
L: linux-scsi@vger.kernel.org
S: Maintained
W: http://www.avagotech.com/support/
prev parent reply other threads:[~2020-08-25 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 6:38 Jing Xiangfeng
2020-08-25 7:01 ` Joe Perches
2020-08-25 7:06 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc8aca7e3772670782c2abc086cab8b6f81be3c1.camel@perches.com \
--to=joe@perches.com \
--cc=jejb@linux.ibm.com \
--cc=jingxiangfeng@huawei.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®