From: Antonio Borneo <antonio.borneo@st.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Joel Fernandes <joel@joelfernandes.org>
Cc: Ingo Molnar <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] tracing: Fix printing ptrs in preempt/irq enable/disable events
Date: Tue, 7 Jan 2020 10:21:55 +0100 [thread overview]
Message-ID: <dc9a1a6a32b0e028837a315834c4723ed44dbac5.camel@st.com> (raw)
In-Reply-To: <20191223151301.20be63f7@gandalf.local.home>
On Mon, 2019-12-23 at 15:13 -0500, Steven Rostedt wrote:
> On Sat, 21 Dec 2019 18:47:41 -0500
> Joel Fernandes <joel@joelfernandes.org> wrote:
>
> > On Wed, Dec 04, 2019 at 09:21:15AM -0500, Steven Rostedt wrote:
> > > Joel,
> > >
> > > Any comments on this patch?
> >
> > Steve, it looks like this issue happens with trace-cmd not knowing what
> > _stext is. If I do cat trace_pipe , then I don't see the issue as _stext is
> > looked up correctly but the reporter of the bug is using trace-cmd. Is there
> > a way to solve this within trace-cmd? Not knowing much about trace-cmd
> > internals, I will have to defer to you on this though..
> >
> > Other than this, I need to make the offset to _stext as s32 instead of u32
> > type so that the problem of the symbol location being before _stext does not
> > cause overflow.
> >
> > Lastly, I am not super convinced that we need to store the full pointer just
> > to handle a case where the offset of the symbol might be more than +-2G from
> > _stext. Once we see such issue, then we can handle it. But right now the size
> > of the trace buffer is utilized better by just storing the offset IMHO.
> >
>
> Does this fix it for you?
>
> -- Steve
>
Steve,
this patch fixes the issue for me, thanks!
Tested-by: Antonio Borneo <antonio.borneo@st.com>
There are other cases where the trace buffer is under stress, e.g. during function tracing.
Would it be useful to only store the offset in such cases too?
Regards,
Antonio
next prev parent reply other threads:[~2020-01-07 9:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 15:44 Antonio Borneo
2019-12-04 14:21 ` Steven Rostedt
2019-12-04 16:04 ` Joel Fernandes
2019-12-21 23:47 ` Joel Fernandes
2019-12-23 20:13 ` Steven Rostedt
2019-12-23 20:18 ` Steven Rostedt
2020-01-02 19:53 ` Joel Fernandes
2020-01-07 9:21 ` Antonio Borneo [this message]
2020-01-07 14:22 ` Steven Rostedt
2019-12-04 16:04 ` Joel Fernandes
2019-12-07 0:00 ` Antonio Borneo
2019-12-19 18:45 ` Valentin Schneider
2019-12-21 23:27 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc9a1a6a32b0e028837a315834c4723ed44dbac5.camel@st.com \
--to=antonio.borneo@st.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®