mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Patrick Fischer <admin@tsv-stahl-riesa.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Shardar Shariff Md <smohammed@nvidia.com>,
	Krishna Yarlagadda <kyarlagadda@nvidia.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-tegra@vger.kernel.org, stable@vger.kernel.org,
	Jiri Slaby <jirislaby@kernel.org>,
	Thierry Reding <thierry.reding@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH 0/2] serial: tegra: Fix 32-bit overflows in the clock rate adjustment
Date: Sun, 22 Nov 2026 11:13:23 +0100	[thread overview]
Message-ID: <dc9e1dff-a8f0-4b2d-b4f2-52248196800a@tsv-stahl-riesa.de> (raw)
In-Reply-To: <20261025-upstream-serial-tegra-overflow-v1-0-267b5b7a79ee@tsv-stahl-riesa.de>

Am 25.10.26 um 23:50 schrieb Patrick Fischer via B4 Relay:
> On 32-bit ARM, both the clock rate adjustment from
> "nvidia,adjust-baud-rates" and the check of the resulting rate overflow
> a 32-bit long at the high baud rates the adjustment is meant for. On
> the Tegra Note 7 (Tegra114), Bluetooth at 3 Mbaud therefore ran with a
> UART clock 5.6 % too low, and the check computed -0.18 % and let it
> pass.
> 
> UART clock at 3 Mbaud with a tolerance of 136 for 1 to 4 Mbaud
> (pll_p 408 MHz):
> 
>                     requested    configured   check
>   without patches   47.79 MHz    45.33 MHz    -0.18 %
>   with patches      48.65 MHz    48.00 MHz     0.00 %
> 
> With both patches and the unchanged tolerance of 136, Bluetooth on the
> Tegra Note 7 works at 3 Mbaud: the UART clock is 48.00 MHz, and the
> WL1801 scans and connects to a paired device without HCI errors.
> 
> With a deliberately wrong tolerance of -500, which gives 45.33 MHz at
> 3 Mbaud, the check now reports the deviation (out of range by -555,
> i.e. -5.55 %) instead of letting it pass.
> 
> Both bugs date back to v5.4. 64-bit platforms are not affected.
> 
> Tool use (see Documentation/process/generated-content.rst): both
> patches, their changelogs and this cover letter were prepared with an
> LLM coding assistant (Claude Code), which traced the wrong clock rates
> I measured on the device to the overflows, wrote the fixes and drafted
> the texts. It also recalculated the old and new arithmetic for the
> affected rates in a small userspace program; the results match the
> rates measured on the device. I reviewed the changes and ran the tests
> on the device.
> 
> ---
> Patrick Fischer (2):
>       serial: tegra: Fix overflow in tegra_get_tolerance_rate()
>       serial: tegra: Fix overflow in tegra_check_rate_in_range()
> 
>  drivers/tty/serial/serial-tegra.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> ---
> base-commit: 734bef548a96e8774d6eef5dfa2026c6edc4e80b
> change-id: 20261023-upstream-serial-tegra-overflow-48d3d0f7afd9
> 
> Best regards,
> --  
> Patrick Fischer <admin@tsv-stahl-riesa.de>

Hi Greg,

sorry, I am still new to upstreaming and sent my earlier ping without
any context. This is the series quoted above: it fixes two 32-bit
overflows in serial-tegra.c that leave the UART clock 5.6 % too low at
3 Mbaud on Tegra114, so Bluetooth fails there. Both patches have
Tested-by and Reviewed-by from Svyatoslav and still apply cleanly to
7.4-rc3. Please let me know if anything needs to change.

Thanks,
Patrick

      parent reply	other threads:[~2026-11-22 10:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 22:50 Patrick Fischer via B4 Relay
2026-10-25 22:50 ` [PATCH 1/2] serial: tegra: Fix overflow in tegra_get_tolerance_rate() Patrick Fischer via B4 Relay
2026-10-26  8:50   ` Svyatoslav Ryhel
2026-10-25 22:50 ` [PATCH 2/2] serial: tegra: Fix overflow in tegra_check_rate_in_range() Patrick Fischer via B4 Relay
2026-10-26  8:50   ` Svyatoslav Ryhel
2026-11-22  9:42 ` [PATCH 0/2] serial: tegra: Fix 32-bit overflows in the clock rate adjustment Patrick Fischer
2026-11-22  9:46   ` Greg Kroah-Hartman
2026-11-22 10:13 ` Patrick Fischer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc9e1dff-a8f0-4b2d-b4f2-52248196800a@tsv-stahl-riesa.de \
    --to=admin@tsv-stahl-riesa.de \
    --cc=clamor95@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=kyarlagadda@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=smohammed@nvidia.com \
    --cc=stable@vger.kernel.org \
    --cc=thierry.reding@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®