From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alina Yu <alina_yu@richtek.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC
Date: Wed, 26 Jul 2023 11:53:11 +0200 [thread overview]
Message-ID: <dca2c683-0049-4bd2-3780-37f334ba6b03@linaro.org> (raw)
In-Reply-To: <1690355592-10920-2-git-send-email-alina_yu@richtek.com>
On 26/07/2023 09:13, Alina Yu wrote:
> Add bindings for Richtek RTQ2208 IC controlled SubPMIC
>
> Signed-off-by: Alina Yu <alina_yu@richtek.com>
Thank you for your patch. There is something to discuss/improve.
> +
> + richtek,mtp-sel-high:
> + type: boolean
> + description:
> + vout register selection based on this boolean value.
> + false - Using DVS0 register setting to adjust vout
> + true - Using DVS1 register setting to adjust vout
> +
> + regulators:
> + type: object
> +
On this level of indentation:
additionalProperties: false
I think I missed this in previous versions. I am sorry.
Rest looks good to me, but this needs to be fixed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-26 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 7:13 [PATCH v5 0/2] Add Richtek RTQ2208 SubPMIC support Alina Yu
2023-07-26 7:13 ` [PATCH v5 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC Alina Yu
2023-07-26 9:53 ` Krzysztof Kozlowski [this message]
2023-08-03 6:36 ` ChiYuan Huang
2023-08-05 21:27 ` Krzysztof Kozlowski
2023-08-07 6:13 ` Alina Yu
2023-07-26 7:13 ` [PATCH v5 2/2] regulator: rtq2208: Add Richtek RTQ2208 SubPMIC driver Alina Yu
2023-08-03 7:24 ` ChiYuan Huang
2023-08-03 11:08 ` Mark Brown
2023-08-07 6:34 ` Alina Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dca2c683-0049-4bd2-3780-37f334ba6b03@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alina_yu@richtek.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®