From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937537AbdAEBUH (ORCPT ); Wed, 4 Jan 2017 20:20:07 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:54931 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933960AbdAEBUF (ORCPT ); Wed, 4 Jan 2017 20:20:05 -0500 X-AuditID: b6c32a2c-f79ad6d000007a0b-86-586d9f0ebda3 Subject: Re: [PATCH] mmc: dw_mmc: Fix some coding style To: Ziyuan Xu , ulf.hansson@linaro.org Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: Jaehoon Chung Message-id: Date: Thu, 05 Jan 2017 10:19:10 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: <1483534376-6521-1-git-send-email-xzy.xu@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDKsWRmVeSWpSXmKPExsWy7bCmli7f/NwIg41fTCwu75rDZnHkfz+j xfG14RZL5oc6sHjcubaHzePvrP0sHp83yQUwR6XaZKQmpqQWKaTmJeenZOal2yp5B8c7x5ua GRjqGlpamCsp5CXmptoqufgE6Lpl5gDtUlIoS8wpBQoFJBYXK+nb2RTll5akKmTkF5fYKkUb GhrpGRqY6xkZGemZGMdaGZkClSSkZpy+O5u5YK10xdFrS9kaGM+KdjFyckgImEh8ObKQDcIW k7hwbz2YLSSwlFHi6BKvLkYuILudSeJl01smmIa2R32sEInljBL3j09jgXDuMUq8+fsArEpY wFziztudYLaIgK3EgTcvmEFsZgFriZ8/WllBbDYBHYnt346D1fAK2EkcWbUNaDUHB4uAqsTn l2YgYVGBMInN91+yQ5QISvyYfI8FxOYUcJX4cvIKK8RIA4kZUw4zQdjyEpvXvGUGuUdC4Deb xMS7zcwgMyUEZCU2HWCGeMBFom3FDqiPhSVeHd/CDmFLS/xdeosRorebUeLfl41sEE4Po8St rauh3jeWuP/gHtQzfBK9v58wQSzglehoE4IwPSR6T/NAVDtKvF32ghkSPjMYJfq3LWeZwCg/ C8k/s5D8MAvJDwsYmVcxiqUWFOempxabFhjqFSfmFpfmpesl5+duYgSnNC2dHYz3FngfYhTg YFTi4X0wNTdCiDWxrLgy9xCjBAezkgjvy9lAId6UxMqq1KL8+KLSnNTiQ4ymwCCeyCwlmpwP TLd5JfGGJmaGJkaWQGhuaK4kzrugwjpCSCA9sSQ1OzW1ILUIpo+Jg1OqgXFJ7//zy4s1405/ CS8rStp+W/RWHq9fgYOORI9hAHv9qedeLlOzb8/9dYafZ/mjxpgWf8Ulr2e4BeTceqjTlRUT rDp3yoPVVd/L16cfsSjZwHTvE+N2humSF49OnD/j4ecZ0i8u9nydu/Sj1q9HReyhYv/Ny12X czHL1ekLSTn5P/nWEvzjxQIlluKMREMt5qLiRABktf8AfwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsVy+t9jAV2++bkRButeKllc3jWHzeLI/35G i+Nrwy2WzA91YPG4c20Pm8ffWftZPD5vkgtgjnKzyUhNTEktUkjNS85PycxLt1UKDXHTtVBS yEvMTbVVitD1DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbxum7s5kL1kpXHL22lK2B8axoFyMn h4SAiUTboz5WCFtM4sK99WwgtpDAUkaJ72+Euxi5gOwHjBLNa06wgCSEBcwl7rzdyQRiiwjY Shx484IZomgWo8S6df1g3cwC1hI/f7SCTWUT0JHY/u04WAOvgJ3EkVXbgGo4OFgEVCU+vzQD MUUFwiSeNzpBVAhK/Jh8D2wVp4CrxJeTV1hBSpgF9CTuX9SCGC4vsXnNW+YJjEArETpmIVTN QlK1gJF5FaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZwnDyT3sF4eJf7IUYBDkYlHt6O vzkRQqyJZcWVuYcYJTiYlUR4X87OjRDiTUmsrEotyo8vKs1JLT7EaAr0xERmKdHkfGAM55XE G5qYm5gbG1iYW1qaGCmJ8zbOfhYuJJCeWJKanZpakFoE08fEwSnVwNjGt9S21U1B3ujOiiV5 3koFDgdmBH6Zqm3T+tpI/iSLcnAXF7/uEaP8d3e+Tn3//ujJbqvKqofM9+1u8Lif3mrTJPBO L4cnbMHB7+YH5sgXF2/0bStwUtT8Y1Cp99J/Yk7XW6aozassW3a9CH7rx6pxyHbrfbaUCFOJ ddv4l3VVPvxf/znysRJLcUaioRZzUXEiAOEWjAipAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170105011910epcas5p4e5b2b826acc185e7432d64e8ce3a85fc X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbUzUvU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170104125752epcas4p2a801fce6fd376d02d7440ad4bfe1716b X-RootMTR: 20170104125752epcas4p2a801fce6fd376d02d7440ad4bfe1716b References: <1483534376-6521-1-git-send-email-xzy.xu@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01/04/2017 09:52 PM, Ziyuan Xu wrote: > Let's fix the warnings from checkpatch.pl: > > - line over 80 characters; > - block comments should align the * on each Lines; > - statements not starting on a tabstop. If there is no critical problem, I think that current codes are keeping better than changing. When someone contribute the patches relevant to these, it can be also changed, (It's more meaningful.) Best Regards, Jaehoon Chung > > Signed-off-by: Ziyuan Xu > --- > > drivers/mmc/host/dw_mmc.c | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index ed63237..a8efe3f 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -94,7 +94,8 @@ struct idmac_desc { > > __le32 des1; /* Buffer sizes */ > #define IDMAC_SET_BUFFER1_SIZE(d, s) \ > - ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | (cpu_to_le32((s) & 0x1fff))) > + ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | \ > + (cpu_to_le32((s) & 0x1fff))) > > __le32 des2; /* buffer 1 physical address */ > > @@ -2733,16 +2734,16 @@ static void dw_mci_init_dma(struct dw_mci *host) > struct device_node *np = dev->of_node; > > /* > - * Check tansfer mode from HCON[17:16] > - * Clear the ambiguous description of dw_mmc databook: > - * 2b'00: No DMA Interface -> Actually means using Internal DMA block > - * 2b'01: DesignWare DMA Interface -> Synopsys DW-DMA block > - * 2b'10: Generic DMA Interface -> non-Synopsys generic DMA block > - * 2b'11: Non DW DMA Interface -> pio only > - * Compared to DesignWare DMA Interface, Generic DMA Interface has a > - * simpler request/acknowledge handshake mechanism and both of them > - * are regarded as external dma master for dw_mmc. > - */ > + * Check tansfer mode from HCON[17:16] > + * Clear the ambiguous description of dw_mmc databook: > + * 2b'00: No DMA Interface -> Actually means using Internal DMA block > + * 2b'01: DesignWare DMA Interface -> Synopsys DW-DMA block > + * 2b'10: Generic DMA Interface -> non-Synopsys generic DMA block > + * 2b'11: Non DW DMA Interface -> pio only > + * Compared to DesignWare DMA Interface, Generic DMA Interface has a > + * simpler request/acknowledge handshake mechanism and both of them > + * are regarded as external dma master for dw_mmc. > + */ > host->use_dma = SDMMC_GET_TRANS_MODE(mci_readl(host, HCON)); > if (host->use_dma == DMA_INTERFACE_IDMA) { > host->use_dma = TRANS_MODE_IDMAC; > @@ -2756,9 +2757,9 @@ static void dw_mci_init_dma(struct dw_mci *host) > /* Determine which DMA interface to use */ > if (host->use_dma == TRANS_MODE_IDMAC) { > /* > - * Check ADDR_CONFIG bit in HCON to find > - * IDMAC address bus width > - */ > + * Check ADDR_CONFIG bit in HCON to find > + * IDMAC address bus width > + */ > addr_config = SDMMC_GET_ADDR_CONFIG(mci_readl(host, HCON)); > > if (addr_config == 1) { > @@ -3337,8 +3338,8 @@ int dw_mci_runtime_resume(struct device *dev) > * Restore the initial value at FIFOTH register > * And Invalidate the prev_blksz with zero > */ > - mci_writel(host, FIFOTH, host->fifoth_val); > - host->prev_blksz = 0; > + mci_writel(host, FIFOTH, host->fifoth_val); > + host->prev_blksz = 0; > > /* Put in max timeout */ > mci_writel(host, TMOUT, 0xFFFFFFFF); >