From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Ioan-daniel, Pop" <Pop.Ioan-daniel@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
"Sa, Nuno" <Nuno.Sa@analog.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Cuciurean, Sergiu" <Sergiu.Cuciurean@analog.com>,
"Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
"Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Tobias Sperling <tobias.sperling@softing.com>,
Alisa-Dariana Roman <alisadariana@gmail.com>,
"Schmitt, Marcelo" <Marcelo.Schmitt@analog.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Trevor Gamblin <tgamblin@baylibre.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 4/5] dt-bindings: iio: adc: add ad7405
Date: Wed, 4 Jun 2025 16:03:02 +0200 [thread overview]
Message-ID: <dcaea307-bbd8-4b6a-ad6c-04f6a2d8e473@kernel.org> (raw)
In-Reply-To: <PH0PR03MB6335ECFCD0C0DEF0230E25B6D16CA@PH0PR03MB6335.namprd03.prod.outlook.com>
On 04/06/2025 15:05, Ioan-daniel, Pop wrote:
>>
>> On 02/06/2025 15:43, Pop Ioan Daniel wrote:
>>> Add devicetree bindings for ad7405/adum770x family.
>>>
>>> Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
>>> ---
>>> changes in v5:
>>> - create an example based on adi,ad7625.yaml that is very similar to this
>> part
>>> - do not add Reviewed-by tag due to the change that I've made.
>>
>> Which change? I see ZERO differences against version which was reviewed.
>
> Hi! The difference is in the io-backends assignment:
Change in the binding. You just pasted example. What change did you make
to invalidate review?
> examples:
> + - |
> + adc {
> + compatible = "adi,ad7405";
> + clocks = <&axi_clk_gen 0>;
> + vdd1-supply = <&vdd1>;
> + vdd2-supply = <&vdd2>;
> + io-backends = <&axi_adc>;
> + };
> +...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-04 14:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 13:43 [PATCH v5 0/5] Add support for AD7405/ADUM770x Pop Ioan Daniel
2025-06-02 13:43 ` [PATCH v5 1/5] iio: adc: ad4851: ad4851_set_oversampling_ratio parameters update Pop Ioan Daniel
2025-06-02 13:43 ` [PATCH v5 2/5] iio: backend: update iio_backend_oversampling_ratio_set Pop Ioan Daniel
2025-06-02 14:58 ` Andy Shevchenko
2025-06-02 13:43 ` [PATCH v5 3/5] iio: adc: adi-axi-adc: add axi_adc_oversampling_ratio_set Pop Ioan Daniel
2025-06-02 13:43 ` [PATCH v5 4/5] dt-bindings: iio: adc: add ad7405 Pop Ioan Daniel
2025-06-02 14:05 ` Krzysztof Kozlowski
2025-06-04 13:05 ` Ioan-daniel, Pop
2025-06-04 14:03 ` Krzysztof Kozlowski [this message]
2025-06-02 13:43 ` [PATCH v5 5/5] iio: adc: ad7405: add ad7405 driver Pop Ioan Daniel
2025-06-02 15:01 ` Andy Shevchenko
2025-06-02 16:59 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcaea307-bbd8-4b6a-ad6c-04f6a2d8e473@kernel.org \
--to=krzk@kernel.org \
--cc=Antoniu.Miclaus@analog.com \
--cc=Dragos.Bogdan@analog.com \
--cc=Marcelo.Schmitt@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=Pop.Ioan-daniel@analog.com \
--cc=Sergiu.Cuciurean@analog.com \
--cc=alisadariana@gmail.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
--cc=tgamblin@baylibre.com \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®