From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031827AbdIZTGX (ORCPT ); Tue, 26 Sep 2017 15:06:23 -0400 Received: from mail-cys01nam02on0050.outbound.protection.outlook.com ([104.47.37.50]:36940 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030327AbdIZTGU (ORCPT ); Tue, 26 Sep 2017 15:06:20 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Andy Lutomirski , Tom Lendacky Subject: Re: [Part1 PATCH v4 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support To: Borislav Petkov References: <20170916123418.37807-1-brijesh.singh@amd.com> <20170916123418.37807-3-brijesh.singh@amd.com> <20170917140206.GA4733@nazgul.tnic> From: Brijesh Singh Message-ID: Date: Tue, 26 Sep 2017 14:06:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170917140206.GA4733@nazgul.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR08CA0086.namprd08.prod.outlook.com (2603:10b6:404:b6::24) To DM2PR12MB0156.namprd12.prod.outlook.com (2a01:111:e400:50ce::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d79fffea-de8b-43ca-c08a-08d50511aa38 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DM2PR12MB0156; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;3:kFGKyJPVECr1sRQPhARhQxiOgLw2EOLLhY6c2MMBqYU/BrKwoRghZh/+ePrIHxE56yWIWfHRsTPevG1sckKtywc6IuesqAbKEdYr49BnkwunhOXZNuBuzyJQT2oyDyUIHdw8vawfOFBeDWgpQE+xxVt0hQYkfOCkv24H/1zGMnKOfpe+CYWeMGA4+yMhCllbAv66BveCQQhO2owfhmJmS2VuBGLKuy291xwXcUbPo2oD1T1u2e/NzLZuK/4h2z7h;25:18jpFwBNKUyZa0s41r6rDtl2Jy+hA6uYe/e0+OeyiQN+CXacZICxqWD1Qm37rn7sjYB7SlctS/lULSgrddmGJ4jSs3TGwRn9FrqynK5LJTVis+OVW0qwLkyeBHBV1aZ3NiHTxCEBYWXSeRzgWdEX5rn+FJecuRE+06C3tYgG0NRRBK/vKP5QgHK6KD1CahPwEg7GCo4qot6EQwEvi2Q9OqSX8CRj/74oSLAfYzVgCiA4X86qPLGJ1DdIOG2BhJyxCZ27rpzITX2h0c8GViJzluA22QFUu0hLYZA1Dmy+z8P6IeswvMlLaIyLnaTR1UBvCf3BJK00tmoaQmAmGgOQLw==;31:sApXxHGOlkNc8gK85iyZKzl1GQZ/mMu2gFz1I/5sAfHp2Kfh+fyf9mRVCj1f54t6NeWmKe+AhFFPnzqPpyuPpeBKFZoO5xgF88oIbObjG+JR9Ovrvlj1QTFuMhBt15W+iOl+fw95ZP2JrZ/S6ftPI4js12XeTSKCUdVpo2k3V38ooPczvEMzCZeii+eUg4gdZq0FdWnxPx0C7pkOMOvd4rlQk0C1EsTWclQU81rGT1w= X-MS-TrafficTypeDiagnostic: DM2PR12MB0156: X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:wRQxMzsorRTSE0xAyzb0NaET6eYPd+42BXfH0/TqCJQF+M3IpLkJTqji1A5KmHtt+cVTZH6wQBuHq8pW/+02wBGFH1kYKsoRgBXTehuU2ST8K32KcANYXKh1SLssD/IYeLluaxThSbvB+TDXV0XiZXlEYpfr4+2WeGCjv3GIxqhmdlTXrGEFpV7b+2FUdlS1Se/bx+gT+19kWgLZy+brQTxVj66JpEWNu9IK+7BSDRjtA7EtTCX507pgP1Tj7iNBNgVV14JaM8HqSu/Jl2BJ4unxUO/as0iSnx9Ro+jlye8bmojrPB2GC2vTlZmP6/JTAHac14y73SQxJQZTaD7ny0LgYohIK+KX2qEALfKOusITdgamu9vJEIGUF1cT5iUS5NygixjVijBFVrGkZpdCLIFXwMVDgBdZiquGAl1fEBgbg07y6pO+EVsBV3G0BsLQXE7AKeo5HbAGInmwLcdHYp7VoHcu/5F5dXaDnx51ntOBHGahoZhvSi2W4cSPrh0n;4:QNfL1bX6lXmYnhatkMGpTTqPvKtFegTVc1kSSljYsO6DvzcI9BbLrlfOTxhsIW3+gt6ZA0r+nfi3+XT2i7sEpHm0qOjy7575IHJGSs95iMcEhy62+940nCvnpFGLB6Sc3eEtEI8EiZrCiC/V02vJnxDRirhJlIJK6WODac/RcOBNTJrGy0bpQK4bgIYVY56f/aFRksBFU29Hw9eoM9Us+A+lIQj67wCYEv/lhXAHzRnVfUxQnhh6zS2e22ExvsJM X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR12MB0156;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR12MB0156; X-Forefront-PRVS: 0442E569BC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(39860400002)(346002)(377454003)(199003)(189002)(24454002)(23676002)(53936002)(83506001)(53546010)(189998001)(81156014)(33646002)(6916009)(81166006)(66066001)(2950100002)(47776003)(65806001)(8676002)(106356001)(65956001)(6486002)(50466002)(77096006)(65826007)(64126003)(2906002)(6246003)(86362001)(6116002)(101416001)(31696002)(8936002)(478600001)(7736002)(305945005)(68736007)(50986999)(16576012)(54356999)(316002)(76176999)(5660300001)(16526017)(229853002)(3846002)(31686004)(105586002)(6666003)(4326008)(97736004)(230700001)(58126008)(36756003)(25786009)(54906003)(309714004);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0156;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:3;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTU2OzIzOktxVDB1bUlFMCtxSXVId1dqTDd6dkw1emJJ?= =?utf-8?B?bm1DUnJFQUJMN3ZKZ1pSZXFSbnBZSDBXSG52RHF4ZmtySU4xenBxSSttV2Vl?= =?utf-8?B?VVQwY2NqdU1ISDAxbU9sV0k4ZnRMcnRuNWluZzFNc2VCbVRZWmFUZDNnNi9C?= =?utf-8?B?eTZxWmx5M2FVSitTYlNIVFE0dXRlNVdYaGxTL2dlZFNqU0JnVVFudTI2Nm9o?= =?utf-8?B?blUrUVlvMTF0bFl3NWhlYUxzb2F5cFVTTUJnbU9jd3I2S3NRNWErMUNJbTJ1?= =?utf-8?B?Q3gzbWxaWTdpSzhKZHc3bnN6c3EybUUycG00d080VWFOeGhvd2hRTmJVUG1a?= =?utf-8?B?aHdEYzZIWTkyaEVzMUQ4SlptMWxqWGdyaTZjZlNxZitoY3dQTmhuZEVJVlE0?= =?utf-8?B?SnFYdE1oWEV5ZmhmNUswZTdOSjdqbHpxRW1xR1JBZ01uQkNPWkNVZEE2OWph?= =?utf-8?B?a0RQL2x0cStHeWZQelJkbFExU3l6dGxkTGx5a1R4Z1EwSlFDRTR1d1JZQU1i?= =?utf-8?B?NDBuZ0psTytJYlFTdHl3c29rWHNBckEwK2dqOGJBWkEvNkRBbGRCbWdYSnEv?= =?utf-8?B?anA0eEYrTUVWUlY1dHcxck5Yc2JVTUZtZUtQL1dWWkNtQTlncmpZMmF3TWwx?= =?utf-8?B?Vmh1SzFvcFdrSXlGNTFmdDIyVytwbTFFay9oMzltdlQ2VStPN0ZybmpKL3NH?= =?utf-8?B?bW1HZHAvc3lHeks5SmhQenBCenY0WFZBTzd5L1lsbHdEaTIvaUNhRjNUdDBt?= =?utf-8?B?M2lzeEkyVm4zK2tpWjFzSW9iNzVyTVNOQVlxd0t3Yy94R2w1T2YyRHZxbXZr?= =?utf-8?B?YjJlM1ZBcmVBUUdaWjBSQkZLY2d1bCtpREVscEVFVVUzNU11SjNyT0RKZXpT?= =?utf-8?B?S05RZlJmR2JMT0xoUUx4cUxPWjNwSk9yZFZIMVNOcXdsQjNLTUhtRUR3UWFB?= =?utf-8?B?R1VkUXo0Q0pCYjNSS1dQNFQvbCtoSit4QWlZWVZTZzFtdWxPQW9hSDIvWElp?= =?utf-8?B?bzUzMkFSdC9sLzVCVThvY2M3K3RPa2J0TGJicUExaTBvempzYzJoMkpJMVFm?= =?utf-8?B?SkJPV3FFakhBRStEWU1PSEJoOEs2VmlQUCtUN1RwVG9QYml0UldIUzhUaTFy?= =?utf-8?B?NDd4MzErQ1N1QWdEeGw0ZkVvdHI0bXpjS2R0ZEMzcGdWNnh6aGhsOUNwcXVh?= =?utf-8?B?T3ZWSnhobXROZFpvSDhWR1U1RVY2QUF1N0VMdHNOMWpvTTMva3EyQkFoVXBz?= =?utf-8?B?czBqMGdaQlRyamtSMG5lWHVKSWZUWWt1VGhDdWlIZm9WU0I5UldCWmxXUHQ0?= =?utf-8?B?NUFDaFRMRmpUWjJVSEhEV29LK3NvTTBGakQxNGVBU01ZZlRIMHF1eWVYU2Rk?= =?utf-8?B?dEFEQlpoMERnalZtczhtSXFoRGM4QW9RcmVscVNOeTM2YTVXNWRZK0R3V0tI?= =?utf-8?B?aUhXUEluaXU1NmRzd21Gb3ZhTm5HTUNQbnV5dzdNMmtyVFJFV0wveC90ZGpS?= =?utf-8?B?eGdRZTkxRmd0TnNzSEJzTGMxQnRBbEY3UDJaZnJoNlVpdllZOHZGWlpTMDBJ?= =?utf-8?B?NjQrVFdvT3RGN2pudnZzZzl5Y2YzRHF0T3hMeXhRWTRmNW5iak5OQ3c0L3BL?= =?utf-8?B?NS9EejFYenZaR2Fld2ZRNSt6cktOc0xNc1FEY0pYQmdWU244UkZiQ05qOUxu?= =?utf-8?B?NmFhMk4vOWhXQTdiV2tzc0s0eTB4M09zYzFnK3AzcVgveUp5eUJZb3hqa1E2?= =?utf-8?B?K3NZWEpPVk1LRmJ0bTJteUoxdzVtTWZKaERsdXM0c1orTEtVVUJsTVNFNHR1?= =?utf-8?B?T1hSRVVNT1JIa0JYMmJEdTVVRFpGMVJJekhOQUhnUEtIdVNSTUpnK3dpYm1n?= =?utf-8?Q?j0SovSen8Ulg/M5r4P5ayhWAm6rfnOyv?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;6:B9jQxg+AVz8lUwt+HU3iybD0fHFpMgcuE9dwrTnF0CV413+il1kHIRtZ8oKxV4EBpGQaycWvGvwr19hYqkayGyUFpi+5iUnmLbR3UeejdPNUYbYDzSWiz1+YRPcZxZZtFO0+kCkmmtPL5p7khT4KCTALLxQIHeKPwOYhfi9ZldsOeZ2eS10PirtV1sVPbu03AbKEde0heqFvsE0aL4rIruMvLox09YjOVh2BuFRWkaJBImMxevJRUwc2E/OdXH3sEzlKVp1XauS2Z/mPcYaQmH4413xxxa+xXKorYIJvYMurVhvF7W2PqQ22M8bhsSGjEyCndcXMtsy4/mIj3/McIQ==;5:cEJ9LhsAM9Q6pYVE+07Jafs624zJvxit7CjaK9C2mhw22De1h9kUk9G77INYirbvumHZnhZ4DjJ7N7HkUXCC10ClGK32YyaIiMVFYAESMpwg8cYuMjIcaoLTJiBb13DiWSyol4y0QhI/kI3hH3XzSA==;24:2tSHO9fHTJTQCnQ1LKjU49ou09WpwDSpy797DZIC4whHAExx7xLSyu5JuCEmEJ4gmobPUm7F0xJWcjHRXZAwVq0NEhFCsDX+L2mSsMOIfRI=;7:2+32m1PpP0FfMaIZMvndzjj6rCUdgEX8m2eqBs525F7vIrW47Cte+7IIMtT3dRzK4E6AynhpRe3qX5t+kGoXqpb/NP+2lYlEplCciPZtDltIBp+u+v3FxTuXTrcMJ4SRY7Wvtzd3GmDtftq6ouCHfyw09le9S2aM3hiXT61Vq+3LAoWSipsGF9CVpV8e+jCe9VkHTI609reUYgGVi5eZT3SRsaUHWECPsVSNqyYJofA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:O8duWjbeWc8CHiczb6iLBwmhRhH+uRBLyfM29re/wpFR1fBBXses5pJg35lRqEwTtl3lqeZKfXlZ70e7OQk2GSu3Bg4P6qzZQOHy+Ckqmn2AGtKyTtPQ3X75dr4hFiU4UXCstvq9N1OSqqq6wHJkvfDN2B+yYrKRXicipUDwI23KKrrLxZlHWwnlNqyqr1IIXosV374HXXRXqzwXKQDLlYWlDxSwjyLSzUu9zHS/Q5/TtGfZYuDPcYxs+j8DDz5T X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 19:06:15.7784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2017 09:02 AM, Borislav Petkov wrote: ... >> >> +unsigned int sev_enabled __section(.data) = 0; > > static. > Will covert to static in next rev. ... > >> -static inline u64 sme_get_me_mask(void) >> +static inline bool mem_encrypt_active(void) >> { >> - return sme_me_mask; >> + return !!sme_me_mask; > > As before, you don't need the !!. > Will fix in next rev. thanks