From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbdJKVfN (ORCPT ); Wed, 11 Oct 2017 17:35:13 -0400 Received: from mga02.intel.com ([134.134.136.20]:34939 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750718AbdJKVfM (ORCPT ); Wed, 11 Oct 2017 17:35:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,362,1503385200"; d="scan'208";a="162107672" Subject: Re: [PATCH] IB/hfil: Delete unused bypass flags To: Christos Gkekas , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <1507755409-12280-1-git-send-email-chris.gekas@gmail.com> From: Don Hiatt Message-ID: Date: Wed, 11 Oct 2017 14:35:10 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507755409-12280-1-git-send-email-chris.gekas@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2017 1:56 PM, Christos Gkekas wrote: > Clean up unused bypass variables in verbs. > > Signed-off-by: Christos Gkekas > --- > drivers/infiniband/hw/hfi1/verbs.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c > index e232f3c..62c3f4e 100644 > --- a/drivers/infiniband/hw/hfi1/verbs.c > +++ b/drivers/infiniband/hw/hfi1/verbs.c > @@ -891,14 +891,12 @@ int hfi1_verbs_send_dma(struct rvt_qp *qp, struct hfi1_pkt_state *ps, > u8 sc5 = priv->s_sc; > int ret; > u32 dwords; > - bool bypass = false; > > if (ps->s_txreq->phdr.hdr.hdr_type) { > u8 extra_bytes = hfi1_get_16b_padding((hdrwords << 2), len); > > dwords = (len + extra_bytes + (SIZE_OF_CRC << 2) + > SIZE_OF_LT) >> 2; > - bypass = true; > } else { > dwords = (len + 3) >> 2; > } > @@ -1034,7 +1032,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, struct hfi1_pkt_state *ps, > int ret = 0; > pio_release_cb cb = NULL; > u32 lrh0_16b; > - bool bypass = false; > u8 extra_bytes = 0; > > if (ps->s_txreq->phdr.hdr.hdr_type) { > @@ -1044,7 +1041,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, struct hfi1_pkt_state *ps, > dwords = (len + extra_bytes) >> 2; > hdr = (u32 *)&ps->s_txreq->phdr.hdr.opah; > lrh0_16b = ps->s_txreq->phdr.hdr.opah.lrh[0]; > - bypass = true; > } else { > dwords = (len + 3) >> 2; > hdr = (u32 *)&ps->s_txreq->phdr.hdr.ibh; Thanks!  Those were useful at one time. ;-) Reviewed-by: Don Hiatt