From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD63C5519F for ; Wed, 18 Nov 2020 05:22:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7E6924655 for ; Wed, 18 Nov 2020 05:22:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726580AbgKRFWi (ORCPT ); Wed, 18 Nov 2020 00:22:38 -0500 Received: from mxout70.expurgate.net ([91.198.224.70]:10201 "EHLO mxout70.expurgate.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726256AbgKRFWh (ORCPT ); Wed, 18 Nov 2020 00:22:37 -0500 Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1kfFvM-000Pvy-Tr; Wed, 18 Nov 2020 06:22:32 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfFvM-000TPg-7R; Wed, 18 Nov 2020 06:22:32 +0100 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id E1322240041; Wed, 18 Nov 2020 06:22:31 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 8009F240040; Wed, 18 Nov 2020 06:22:31 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 25B0E204F6; Wed, 18 Nov 2020 06:22:31 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 18 Nov 2020 06:22:31 +0100 From: Martin Schiller To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3] net/tun: Call netdev notifiers Organization: TDT AG In-Reply-To: <20201117163245.4ff522ef@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> References: <20201116104121.20884-1-ms@dev.tdt.de> <20201117163245.4ff522ef@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Message-ID: X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.15 X-purgate-type: clean X-purgate-ID: 151534::1605676952-000035B9-463974AD/0/0 X-purgate: clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-18 01:32, Jakub Kicinski wrote: > On Mon, 16 Nov 2020 11:41:21 +0100 Martin Schiller wrote: >> Call netdev notifiers before and after changing the device type. >> >> Signed-off-by: Martin Schiller >> --- >> >> Change from v2: >> use subject_prefix 'net-next' to fix 'fixes_present' issue >> >> Change from v1: >> fix 'subject_prefix' and 'checkpatch' warnings >> >> --- >> drivers/net/tun.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/tun.c b/drivers/net/tun.c >> index 3d45d56172cb..2d9a00f41023 100644 >> --- a/drivers/net/tun.c >> +++ b/drivers/net/tun.c >> @@ -3071,9 +3071,13 @@ static long __tun_chr_ioctl(struct file *file, >> unsigned int cmd, >> "Linktype set failed because interface is up\n"); >> ret = -EBUSY; >> } else { >> + call_netdevice_notifiers(NETDEV_PRE_TYPE_CHANGE, >> + tun->dev); > > This call may return an error (which has to be unpacked with > notifier_to_errno()). OK, I'll fix that and send a v3 patch. > >> tun->dev->type = (int) arg; >> netif_info(tun, drv, tun->dev, "linktype set to %d\n", >> tun->dev->type); >> + call_netdevice_notifiers(NETDEV_POST_TYPE_CHANGE, >> + tun->dev); >> ret = 0; >> } >> break;