From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269BDC7EE29 for ; Thu, 25 May 2023 19:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236550AbjEYTrU (ORCPT ); Thu, 25 May 2023 15:47:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235464AbjEYTrN (ORCPT ); Thu, 25 May 2023 15:47:13 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E527EE69; Thu, 25 May 2023 12:46:50 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9608D5C0351; Thu, 25 May 2023 15:46:19 -0400 (EDT) Received: from imap52 ([10.202.2.102]) by compute5.internal (MEProxy); Thu, 25 May 2023 15:46:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squebb.ca; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1685043979; x=1685130379; bh=ds 54NBbEQEF4Jg2h5usa6N/fyRH0XIYDquJWQjOiKKk=; b=XcHvR1B/PkzInUdwBm dljh0a5+oSLSPG5QLy0CoXC+xpKcmkOdhnJRJFb9tRoIS9QfbmvCF9sODaO5ov+5 9fWrxTJO3fCRIZsI0q36CDPVlM5P6zhGg4Js940Yma6Nti76yRM8x4mRl0R0j4Qs Nf66uGtpWafQ1plMLECbAgqrJvAdPt7QEserk6pUgsZ7lqRUhZDveuQxTFNYgW74 9WMimYWZwd9xsVDjzJyaGs5Bl5irnYWbabsaUdJ+B7lCusTotrLKMLEdRE58F+Zi O/TD2STJl7L56t/WAXYSoH12B4J6te2IX3I5uk2yHnHpOVVFcth2a6LCdJGBSR5g GiBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1685043979; x=1685130379; bh=ds54NBbEQEF4J g2h5usa6N/fyRH0XIYDquJWQjOiKKk=; b=m149zc9UscX8OVCH2GDQQUhVmqw/R IUMOd685IH0okcp+LxPIIUpttDE25pRm66/ziE3Kf4rYAHsAeZ8rmj6TlMNlz9rW 4vTtmcM41YoLwFG1Ud6s47BlHdKP+kYReAKQxmWs4Wy1sbve1loba2leIpg1Mb1W Gtz8PncixGNgdICgKCGsUD5WT0RXydjLz5CJCZA6rrDMq8WG+12CoS2gNWeUlir7 luxHe9cU0jO/ihcve526mAckMuPcEGKl8ckTIqqg3rp6uMCVQTeji+Qhd9Qtt6O1 KbWPTTVSB757U7bTAizcy2XMPxJOJAzTsR75G186j6XLJps+HTKbI+JvQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejjedgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdfo rghrkhcurfgvrghrshhonhdfuceomhhpvggrrhhsohhnqdhlvghnohhvohesshhquhgvsg gsrdgtrgeqnecuggftrfgrthhtvghrnhepieeufeejieevteduvdekteefledtveffvedu hefffeejudefvdeijeegudegkefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepmhhpvggrrhhsohhnqdhlvghnohhvohesshhquhgvsggsrdgt rg X-ME-Proxy: Feedback-ID: ibe194615:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4E287C60091; Thu, 25 May 2023 15:46:19 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20230525193132.3727-1-mpearson-lenovo@squebb.ca> <20230525193132.3727-3-mpearson-lenovo@squebb.ca> <17963a3d-996f-4bb8-918e-aadba15be9bc@app.fastmail.com> Date: Thu, 25 May 2023 15:45:58 -0400 From: "Mark Pearson" To: "Hans de Goede" Cc: "markgross@kernel.org" , "platform-driver-x86@vger.kernel.org" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] platform/x86: think-lmi: Correct NVME password handling Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2023, at 3:43 PM, Hans de Goede wrote: > Hi, > > On 5/25/23 21:39, Mark Pearson wrote: >> Hi Hans, >> >> My apologies - I completely forgot to add the v2 tag on this patch series...had a complete brain fart. > > No worries I did not even notice the v2 was missing, > my brain automatically added it :) > >> I assume I should resend them all - correctly named. > > Well I have some review remarks on patch 5/5, it would be good if you > can address those (if you agree with them) and then lets jump straight > to v3 to avoid confusion ? > Works for me :) Mark