From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CF4C6786F for ; Wed, 31 Oct 2018 02:26:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28D3F2082B for ; Wed, 31 Oct 2018 02:26:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28D3F2082B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728860AbeJaLWf (ORCPT ); Wed, 31 Oct 2018 07:22:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42104 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728671AbeJaLWf (ORCPT ); Wed, 31 Oct 2018 07:22:35 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 159DB307B969; Wed, 31 Oct 2018 02:26:37 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-109.pek2.redhat.com [10.72.12.109]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7439560C47; Wed, 31 Oct 2018 02:26:28 +0000 (UTC) Subject: Re: [PATCH] kdump, vmcoreinfo: Export sme_me_mask value to vmcoreinfo To: Baoquan He , Borislav Petkov , Dave Young Cc: Petr Tesarik , linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, mingo@redhat.com, tglx@linutronix.de References: <20181029083118.GC1884@MiWiFi-R3L-srv> <20181029095738.GB20101@zn.tnic> <15897206-c1a6-ced6-3a1b-f71da8fc9c83@redhat.com> <20181029114414.GA11408@MiWiFi-R3L-srv> <90385882-7fd1-a674-ec5a-19bd42471a5e@redhat.com> <20181029134918.GB32150@zn.tnic> <699ab34e-1373-582d-4e58-e76bd57ec34f@redhat.com> <20181030050900.GA25987@dhcp-128-65.nay.redhat.com> <20181030091542.GD32102@zn.tnic> <20181030092314.GC14493@MiWiFi-R3L-srv> From: lijiang Message-ID: Date: Wed, 31 Oct 2018 10:26:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181030092314.GC14493@MiWiFi-R3L-srv> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 31 Oct 2018 02:26:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2018年10月30日 17:23, Baoquan He 写道: > > Hi Boris, DaveY and Lianbo, > > On 10/30/18 at 10:15am, Borislav Petkov wrote: >> On Tue, Oct 30, 2018 at 01:09:00PM +0800, Dave Young wrote: >>> It is not the content, I think it is a good catch from Boris, it would >>> be good to document the exported things in somewhere eg. >>> Documentation/kdump/vmcoreinfo.txt > > For the vmcoreinfo variables document, I personally think it might be > not necessary. The reason is that all the old varialbles are exported > with the name of themselves. We know what they are or what they > represent since they are all kernel symbols or macro. Only this me_mask, > it's a local variable and store the value of sme_me_mask for now, may > store more info later like Petr mentioned, and also will store the memory > encryption information of TME (which is intel's transparent memory encryption). > We can add code comment around to tell these. > Thank you, everyone. I personally agree with Baoquan's opinion. What do you think about? Boris and other reviewer? If the vmcoreinfo document is necessary, would you like to help me to provide an outline? I can try my best to write the document. Anyway, we should make a choice. Regards, Lianbo > Personal opinion. > > Thanks > Baoquan >