From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pv50p00im-ztdg10021201.me.com (pv50p00im-ztdg10021201.me.com [17.58.6.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99A4424024E for ; Mon, 13 Jan 2025 15:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=17.58.6.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736781337; cv=none; b=b8kiw0ifMpynUb3+Wh7cfk+7WdPnveS8dqDQAANUA5lQwloIrx2YpzoBXAdO71RmxX5AMTUETUYbLmnLw2Cgc9pu0f87vCuyGu7Oym5rAkdZEpQG62X3m/99s6I8jm3NAakic9sJEvL6TW+gSCVqEufMBJA81UqRMPKnuutPbJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736781337; c=relaxed/simple; bh=MrIXePv+PltB2pqQMlGKJDMwQVhUguxK/ZXfvC255kg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MwGqlxzQhGIIG4tCNu8OPorDvSI8JeiOrHC3jLrY+FaeMk+DYbsiJhwH/fFk13XHNcCn92S4djQBzuejQgkbiKhnObUF45RK7/rogAmrdboXDieQMG+eL5HArKkcsACzx8Z0cI/PhyDfUdfh4WNAgRZct3woaAR13DH8wGfoLvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=xJtlKj+C; arc=none smtp.client-ip=17.58.6.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="xJtlKj+C" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1736781335; bh=2V6tFmBi8NvcRm4JpWLiNsx86CvlStNDM8wUbIBGTos=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type: x-icloud-hme; b=xJtlKj+CgfV77qkFa5fyTaa9Iq6D9fGb4Fdk+3yZf8tCpAfvTzcOYspKAiQ7spFJx 1DmI2rr3E9GMdPEQTyoFaqrU54eUpNpl+5WBsA4RoLIPQNs1xQUlxGBHKXiUBhZNIG 4w4PDN8FklXeVEFzXg7Q7HF+z9YqNv9/2/aGhHi9NfqHmdf2A8Dy75C3wswxnMAlHf L+9B7VJ5eSn8WXX71t8/9dhYVaXiTyGToiC2Nmdm5KDWcE4DFEjVI4yVwGNazjulbq 7xKifFU0Sbw5wf8aBFw01EWvyVXwUgH1qAOgJbhrSmYNIl+KccFjrDi1bKPs+7KDkL bJjd50cQbRuJg== Received: from [192.168.1.26] (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10021201.me.com (Postfix) with ESMTPSA id 2EA5B3118D88; Mon, 13 Jan 2025 15:15:28 +0000 (UTC) Message-ID: Date: Mon, 13 Jan 2025 23:15:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] Bluetooth: qca: Fix poor RF performance for WCN6855 To: Johan Hovold Cc: Marcel Holtmann , Luiz Augusto von Dentz , Steev Klimaszewski , Bjorn Andersson , "Aiqun Yu (Maria)" , Cheng Jiang , Jens Glathe , Paul Menzel , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu , stable@vger.kernel.org References: <20250113-wcn6855_fix-v3-1-eeb8b0e19ef4@quicinc.com> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: YRWF4Q3e8gFAsu7A4M8NcPMML3dS59SC X-Proofpoint-GUID: YRWF4Q3e8gFAsu7A4M8NcPMML3dS59SC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-13_05,2025-01-13_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 mlxlogscore=767 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2501130128 On 2025/1/13 23:04, Johan Hovold wrote: >> case QCA_WCN6855: >> - snprintf(config.fwname, sizeof(config.fwname), >> - "qca/hpnv%02x.bin", rom_ver); >> + qca_read_fw_board_id(hdev, &boardid); > For consistency, this should probably have been handled by amending the > conditional above the switch: > > if (soc_type == QCA_QCA2066 || soc_type == QCA_WCN7850) > qca_read_fw_board_id(hdev, &boardid); > sorry for that not notice this comments. qca_read_fw_board_id() may be invoked twice if adding reading board ID here see below branch: config.type = TLV_TYPE_NVM; if (firmware_name) { /* The firmware name has an extension, use it directly */ if (qca_filename_has_extension(firmware_name)) { snprintf(config.fwname, sizeof(config.fwname), "qca/%s", firmware_name); } else { *qca_read_fw_board_id(hdev, &boardid);* qca_get_nvm_name_by_board(config.fwname, sizeof(config.fwname), firmware_name, soc_type, ver, 0, boardid); } > but long term that should probably be moved into > qca_get_nvm_name_by_board() to avoid sprinkling conditionals all over > the driver. > > I'm fine with this as a stop gap unless you want to move the call to the > QCA2066/WCN7850 conditional: > > Reviewed-by: Johan Hovold