From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
Rao Mandadapu <quic_srivasam@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Cc: Patrick Lai <quic_plai@quicinc.com>
Subject: Re: [PATCH v2 6/7] soundwire: qcom: add support for v2.0.0 controller
Date: Mon, 17 Apr 2023 16:16:28 +0200 [thread overview]
Message-ID: <dccd1951-9fbe-272b-541d-72446ea892e6@linaro.org> (raw)
In-Reply-To: <f2f1871c-38f1-52b0-d90d-d1f263048606@linaro.org>
On 13/04/2023 13:27, Srinivas Kandagatla wrote:
RM_INTERRUPT_STATUS_RMSK);
>>
>> /* Configure No pings */
>> ctrl->reg_read(ctrl, SWRM_MCP_CFG_ADDR, &val);
>> u32p_replace_bits(&val, SWRM_DEF_CMD_NO_PINGS, SWRM_MCP_CFG_MAX_NUM_OF_CMD_NO_PINGS_BMSK);
>> ctrl->reg_write(ctrl, SWRM_MCP_CFG_ADDR, val);
>>
>> - if (ctrl->version >= SWRM_VERSION_1_7_0) {
>> + if (ctrl->version == SWRM_VERSION_1_7_0) {
>> ctrl->reg_write(ctrl, SWRM_LINK_MANAGER_EE, SWRM_EE_CPU);
>> ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL,
>> SWRM_MCP_BUS_CLK_START << SWRM_EE_CPU);
>> + } else if (ctrl->version >= SWRM_VERSION_2_0_0) {
>
> we can move this to a proper switch case rather than if else's
OK
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-17 14:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 13:24 [PATCH v2 0/7] soundwire: qcom: add support for SM8550 (Soundwire v2.0.0) Krzysztof Kozlowski
2023-04-03 13:24 ` [PATCH v2 1/7] dt-bindings: soundwire: qcom: add Qualcomm Soundwire v2.0.0 Krzysztof Kozlowski
2023-04-04 14:20 ` Rob Herring
2023-04-03 13:24 ` [PATCH v2 2/7] dt-bindings: soundwire: qcom: add 16-bit sample interval Krzysztof Kozlowski
2023-04-04 14:21 ` Rob Herring
2023-04-04 18:18 ` Krzysztof Kozlowski
2023-04-06 15:59 ` Rob Herring
2023-04-12 15:28 ` Srinivas Kandagatla
2023-04-12 16:16 ` Krzysztof Kozlowski
2023-04-13 11:12 ` Srinivas Kandagatla
2023-04-17 14:17 ` Krzysztof Kozlowski
2023-04-03 13:24 ` [PATCH v2 3/7] soundwire: qcom: allow 16-bit sample interval for ports Krzysztof Kozlowski
2023-04-04 18:03 ` Konrad Dybcio
2023-04-03 13:25 ` [PATCH v2 4/7] soundwire: qcom: use consistently 'ctrl' as state variable name Krzysztof Kozlowski
2023-04-04 18:07 ` Konrad Dybcio
2023-04-13 11:13 ` Srinivas Kandagatla
2023-04-03 13:25 ` [PATCH v2 5/7] soundwire: qcom: prepare for handling different register layouts Krzysztof Kozlowski
2023-04-06 13:24 ` Konrad Dybcio
2023-04-13 11:14 ` Srinivas Kandagatla
2023-04-03 13:25 ` [PATCH v2 6/7] soundwire: qcom: add support for v2.0.0 controller Krzysztof Kozlowski
2023-04-06 13:28 ` Konrad Dybcio
2023-04-13 11:27 ` Srinivas Kandagatla
2023-04-17 14:16 ` Krzysztof Kozlowski [this message]
2023-04-03 13:25 ` [PATCH v2 7/7] soundwire: qcom: use tabs for indentation in defines Krzysztof Kozlowski
2023-04-06 13:28 ` Konrad Dybcio
2023-04-13 13:11 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dccd1951-9fbe-272b-541d-72446ea892e6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=quic_plai@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®