From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF0DC4332F for ; Wed, 15 Nov 2023 01:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234274AbjKOBG7 (ORCPT ); Tue, 14 Nov 2023 20:06:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbjKOBG6 (ORCPT ); Tue, 14 Nov 2023 20:06:58 -0500 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85CD7DC; Tue, 14 Nov 2023 17:06:55 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E39E55C0150; Tue, 14 Nov 2023 20:06:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 14 Nov 2023 20:06:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1700010414; x=1700096814; bh=ZfFaIHFWUpEiFsmXQhLKQzZFRlFi+XgkIGO E31T1wx4=; b=s6iUKWriyYhRjPG6hlTrcyQ2zmFGlLVIxhnbH+RXJOt95U30Z06 MaftuwLQeDHVtJ4L4260JQ7VLYCOTYBEfpXJ3kqDVCffGvemH0tInLKETcL3plXK M/lmhX+UDPrq+BNr9PYNJz4deeq1QIk+7mC83g/LfJ0TYNbG1W+4sUG1d5DsB7Wh LKakKi7k9twvivdZkeFKA1sZaXdg5pQh16qd2yTmPDes6binJ5GPYSatoC/r1TlQ S1DVBStxpQ1mGX8/42GY2z5jZukWstwkON5XJkZShP3ID82ekg0OsPjMFAYjlnLB BMHRq0vjhkRwpi5ahM0pxEfblMf6cvEK4WQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700010414; x=1700096814; bh=ZfFaIHFWUpEiFsmXQhLKQzZFRlFi+XgkIGO E31T1wx4=; b=nxD4uJdHGXMW/Kby432f/6dASClN6oJyvSlCNNtKCfnzw2OeJac Bat8zLNEza4Jt1DwAAShyGMaouuQd/UtqtyFNc3HhTRtArrBrIDRYa6s6l1A9S2c /CVb6oGmsX1dkIAXkXCA10gLom8pG0SjusLaNbae8FekRSVTXSl72xlB3QUG9Ufv 3tkWOCWm/LzY2ZA3+xgXJSUsHRC6cH3+qsdsJUwCQiWd8WxEnt56CjN+shT3t2Jm 0fjc+xjMpokAAvcSl1yuoGDN0BLRIaNuhLOf1i/aCKlL52MnB3EEapiLWrgEmTwx FMDTxLRAxFxczSRUmZQjnWNmgXW7bkB19Ng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefgedgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefkrghn ucfmvghnthcuoehrrghvvghnsehthhgvmhgrfidrnhgvtheqnecuggftrfgrthhtvghrnh epuefhueeiieejueevkefgiedtteehgfdutdelfffhleeflefhudeuvdefhfeghfehnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgrvhgvnh esthhhvghmrgifrdhnvght X-ME-Proxy: Feedback-ID: i31e841b0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Nov 2023 20:06:51 -0500 (EST) Message-ID: Date: Wed, 15 Nov 2023 09:06:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] autofs: fix null deref in autofs_fill_super Content-Language: en-US To: Al Viro Cc: Edward Adam Davis , syzbot+662f87a8ef490f45fa64@syzkaller.appspotmail.com, autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <000000000000ae5995060a125650@google.com> <4fcf49456c32087f5306e84c4a8df5b2bd9f4146.camel@themaw.net> <20231114044110.GR1957730@ZenIV> <20231114152601.GS1957730@ZenIV> <7b982b5e-ecad-1b55-7388-faf759b65cfe@themaw.net> <20231115003527.GW1957730@ZenIV> From: Ian Kent In-Reply-To: <20231115003527.GW1957730@ZenIV> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/11/23 08:35, Al Viro wrote: > On Wed, Nov 15, 2023 at 08:18:33AM +0800, Ian Kent wrote: > >> I guess that including the locking is not going to make much difference. >> >> I don't remember now but it was probably done because there may be many >> >> mounts (potentially several thousand) being done and I wanted to get rid >> >> of anything that wasn't needed. > Seeing that lock in question is not going to be contended... ;-) > > Seriously, though - the fewer complications we have in the locking rules, > the better. Sure, no problem, I'll make that change. I do need to do a compile and test it actually ok works so it's taking a little while. Ian > > Al, currently going through audit of ->d_name/->d_parent uses and cursing > at the 600-odd places left to look through...