From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jthumshirn@suse.de" <jthumshirn@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] scsi: check for equality of result byte values
Date: Wed, 13 Jun 2018 13:09:06 +0000 [thread overview]
Message-ID: <dcd5c76a5d9c2dd376bf7186376c7130889ebaa7.camel@wdc.com> (raw)
In-Reply-To: <20180613075349.7509-3-jthumshirn@suse.de>
On Wed, 2018-06-13 at 09:53 +0200, Johannes Thumshirn wrote:
> if ((cmd->result == (DID_OK << 16)
> - || status_byte(cmd->result) &
> - CHECK_CONDITION)) {
> + || status_byte(cmd->result) == CHECK_CONDITION)) {
A minor comment: the preferred coding style is to place "||" at the end of the
previous line.
> - if ((driver_byte(the_result) & DRIVER_SENSE) == 0) {
> + if (driver_byte(the_result) == DRIVER_SENSE) {
This change looks wrong to me.
Bart.
next prev parent reply other threads:[~2018-06-13 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 7:53 [PATCH v2 0/3] Preparation patch-set for SCSI results rework Johannes Thumshirn
2018-06-13 7:53 ` [PATCH v2 1/3] scsi: remove Scsi_Cmnd typedef Johannes Thumshirn
2018-06-13 11:57 ` Christoph Hellwig
2018-06-19 2:06 ` Martin K. Petersen
2018-06-13 7:53 ` [PATCH v2 2/3] scsi: check for equality of result byte values Johannes Thumshirn
2018-06-13 11:58 ` Christoph Hellwig
2018-06-13 13:09 ` Bart Van Assche [this message]
2018-06-13 7:53 ` [PATCH v2 3/3] scsi: don't add scsi command result bytes Johannes Thumshirn
2018-06-13 11:59 ` Christoph Hellwig
2018-06-13 13:11 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd5c76a5d9c2dd376bf7186376c7130889ebaa7.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®