From: Dave Hansen <dave.hansen@intel.com>
To: ira.weiny@intel.com, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Fenghua Yu <fenghua.yu@intel.com>,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH V5 08/10] x86/entry: Preserve PKRS MSR across exceptions
Date: Wed, 31 Mar 2021 12:31:56 -0700 [thread overview]
Message-ID: <dcd6a103-5220-d624-0655-b9c7146f9de5@intel.com> (raw)
In-Reply-To: <20210331191405.341999-9-ira.weiny@intel.com>
On 3/31/21 12:14 PM, ira.weiny@intel.com wrote:
> + * To protect against exceptions having access to this memory we save the
> + * current running value and sets the PKRS value to be used during the
> + * exception.
This series seems to have grown some "we's".
The preexisting pkey code was not innocent in this regard, either. But,
please fix this up across the series in the next submission. Literally
removing "we" from this sentence doesn't change the meaning at all.
next prev parent reply other threads:[~2021-03-31 19:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 19:13 [PATCH V5 00/10] PKS: Add Protection Key Supervisor support ira.weiny
2021-03-31 19:13 ` [PATCH V5 01/10] x86/pkeys: Create pkeys_common.h ira.weiny
2021-03-31 19:13 ` [PATCH V5 02/10] x86/fpu: Refactor arch_set_user_pkey_access() for PKS support ira.weiny
2021-03-31 19:13 ` [PATCH V5 03/10] x86/pks: Add additional PKEY helper macros ira.weiny
2021-03-31 19:13 ` [PATCH V5 04/10] x86/pks: Add PKS defines and Kconfig options ira.weiny
2021-03-31 19:14 ` [PATCH V5 05/10] x86/pks: Add PKS setup code ira.weiny
2021-03-31 19:14 ` [PATCH V5 06/10] x86/fault: Adjust WARN_ON for PKey fault ira.weiny
2021-03-31 19:14 ` [PATCH V5 07/10] x86/pks: Preserve the PKRS MSR on context switch ira.weiny
2021-03-31 19:14 ` [PATCH V5 08/10] x86/entry: Preserve PKRS MSR across exceptions ira.weiny
2021-03-31 19:31 ` Dave Hansen [this message]
2021-04-01 1:15 ` Ira Weiny
2021-03-31 19:14 ` [PATCH V5 09/10] x86/pks: Add PKS kernel API ira.weiny
2021-03-31 19:14 ` [PATCH V5 10/10] x86/pks: Add PKS test code ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd6a103-5220-d624-0655-b9c7146f9de5@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®