From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26C95C433E0 for ; Sat, 27 Mar 2021 06:51:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2A03619B4 for ; Sat, 27 Mar 2021 06:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230423AbhC0Guo (ORCPT ); Sat, 27 Mar 2021 02:50:44 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14156 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230174AbhC0GuL (ORCPT ); Sat, 27 Mar 2021 02:50:11 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F6qCM0tyrznYxZ; Sat, 27 Mar 2021 14:47:27 +0800 (CST) Received: from [127.0.0.1] (10.40.192.162) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Sat, 27 Mar 2021 14:49:56 +0800 Subject: Re: [PATCH 05/15] remove useless return statement for void function To: , , , References: <1616827256-51840-1-git-send-email-tanxiaofei@huawei.com> <1616827256-51840-6-git-send-email-tanxiaofei@huawei.com> CC: , , , From: Xiaofei Tan Message-ID: Date: Sat, 27 Mar 2021 14:49:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1616827256-51840-6-git-send-email-tanxiaofei@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.192.162] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oh, sorry, the title doesn't contain subsystem and module name. I'll send v2 later. Please ignore this one. thanks. On 2021/3/27 14:40, Xiaofei Tan wrote: > Remove useless return statement for void function, reported by > checkpatch.pl. > > WARNING: void function return statements are not generally useful > FILE: drivers/acpi/acpi_ipmi.c:482: > + return; > +} > > Signed-off-by: Xiaofei Tan > --- > drivers/acpi/acpi_ipmi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c > index 9d6c0fc..bbd00d9 100644 > --- a/drivers/acpi/acpi_ipmi.c > +++ b/drivers/acpi/acpi_ipmi.c > @@ -478,7 +478,6 @@ static void ipmi_register_bmc(int iface, struct device *dev) > ipmi_dev_release(ipmi_device); > err_ref: > put_device(smi_data.dev); > - return; > } > > static void ipmi_bmc_gone(int iface) >