From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
Hironori KIKUCHI <kikuchan98@gmail.com>,
linux-kernel@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Hironori KIKUCHI <kikuchan98@gmail.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/3] drm/panel: st7701: Add support for SPI for configuration
Date: Fri, 21 Jun 2024 09:45:24 +0300 [thread overview]
Message-ID: <dceac1a6-25bf-4d04-a049-4c67846027f2@moroto.mountain> (raw)
In-Reply-To: <20240618081515.1215552-3-kikuchan98@gmail.com>
Hi Hironori,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hironori-KIKUCHI/dt-bindings-display-st7701-Add-Anbernic-RG28XX-panel/20240618-161849
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20240618081515.1215552-3-kikuchan98%40gmail.com
patch subject: [PATCH v1 2/3] drm/panel: st7701: Add support for SPI for configuration
config: i386-randconfig-141-20240621 (https://download.01.org/0day-ci/archive/20240621/202406210841.Q17G5ISz-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202406210841.Q17G5ISz-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/panel/panel-sitronix-st7701.c:1076 st7701_dsi_probe() warn: passing zero to 'dev_err_probe'
vim +/dev_err_probe +1076 drivers/gpu/drm/panel/panel-sitronix-st7701.c
433b7d46874577 Hironori KIKUCHI 2024-06-18 1062 static int st7701_dsi_probe(struct mipi_dsi_device *dsi)
433b7d46874577 Hironori KIKUCHI 2024-06-18 1063 {
433b7d46874577 Hironori KIKUCHI 2024-06-18 1064 struct st7701 *st7701;
433b7d46874577 Hironori KIKUCHI 2024-06-18 1065 int err;
433b7d46874577 Hironori KIKUCHI 2024-06-18 1066
433b7d46874577 Hironori KIKUCHI 2024-06-18 1067 err = st7701_probe(&dsi->dev, DRM_MODE_CONNECTOR_DSI);
433b7d46874577 Hironori KIKUCHI 2024-06-18 1068 if (err)
433b7d46874577 Hironori KIKUCHI 2024-06-18 1069 return err;
433b7d46874577 Hironori KIKUCHI 2024-06-18 1070
433b7d46874577 Hironori KIKUCHI 2024-06-18 1071 st7701 = dev_get_drvdata(&dsi->dev);
849b2e3ff96982 Jagan Teki 2019-01-25 1072 st7701->dsi = dsi;
433b7d46874577 Hironori KIKUCHI 2024-06-18 1073 st7701->write_command = st7701_dsi_write;
849b2e3ff96982 Jagan Teki 2019-01-25 1074
433b7d46874577 Hironori KIKUCHI 2024-06-18 1075 if (!st7701->desc->lanes)
433b7d46874577 Hironori KIKUCHI 2024-06-18 @1076 return dev_err_probe(&dsi->dev, err, "This panel is not for MIPI DSI\n");
^^^
-EINVAL?
433b7d46874577 Hironori KIKUCHI 2024-06-18 1077
433b7d46874577 Hironori KIKUCHI 2024-06-18 1078 dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
433b7d46874577 Hironori KIKUCHI 2024-06-18 1079 MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS;
433b7d46874577 Hironori KIKUCHI 2024-06-18 1080 dsi->format = st7701->desc->format;
433b7d46874577 Hironori KIKUCHI 2024-06-18 1081 dsi->lanes = st7701->desc->lanes;
433b7d46874577 Hironori KIKUCHI 2024-06-18 1082
433b7d46874577 Hironori KIKUCHI 2024-06-18 1083 mipi_dsi_set_drvdata(dsi, st7701);
433b7d46874577 Hironori KIKUCHI 2024-06-18 1084
433b7d46874577 Hironori KIKUCHI 2024-06-18 1085 err = mipi_dsi_attach(dsi);
433b7d46874577 Hironori KIKUCHI 2024-06-18 1086 if (err)
433b7d46874577 Hironori KIKUCHI 2024-06-18 1087 return dev_err_probe(&dsi->dev, err, "Failed to init MIPI DSI\n");
c62102165dd792 Marek Vasut 2022-10-15 1088
c62102165dd792 Marek Vasut 2022-10-15 1089 return 0;
433b7d46874577 Hironori KIKUCHI 2024-06-18 1090 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-06-21 6:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 8:15 [PATCH v1 0/3] drm/panel: st7701: Add Anbernic RG28XX panel support Hironori KIKUCHI
2024-06-18 8:15 ` [PATCH v1 1/3] dt-bindings: display: st7701: Add Anbernic RG28XX panel Hironori KIKUCHI
2024-06-18 9:17 ` Krzysztof Kozlowski
2024-06-21 10:59 ` Hironori KIKUCHI
2024-06-21 15:17 ` Krzysztof Kozlowski
2024-06-18 8:15 ` [PATCH v1 2/3] drm/panel: st7701: Add support for SPI for configuration Hironori KIKUCHI
2024-06-18 9:20 ` Krzysztof Kozlowski
2024-06-21 6:45 ` Dan Carpenter [this message]
2024-06-21 20:31 ` Jessica Zhang
2024-06-22 7:36 ` Hironori KIKUCHI
2024-06-18 8:15 ` [PATCH v1 3/3] drm/panel: st7701: Add Anbernic RG28XX panel support Hironori KIKUCHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dceac1a6-25bf-4d04-a049-4c67846027f2@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=kikuchan98@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®