From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752114AbdHPOq5 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Aug 2017 10:46:57 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:43441 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751588AbdHPOqy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Aug 2017 10:46:54 -0400
Subject: Re: [PATCH v7 9/9] sparc64: Add support for ADI (Application Data
 Integrity)
To: David Miller <davem@davemloft.net>
Cc: dave.hansen@linux.intel.com, corbet@lwn.net, bob.picco@oracle.com,
        steven.sistare@oracle.com, pasha.tatashin@oracle.com,
        mike.kravetz@oracle.com, mingo@kernel.org, nitin.m.gupta@oracle.com,
        kirill.shutemov@linux.intel.com, tom.hromatka@oracle.com,
        eric.saint.etienne@oracle.com, allen.pais@oracle.com,
        cmetcalf@mellanox.com, akpm@linux-foundation.org, geert@linux-m68k.org,
        tklauser@distanz.ch, atish.patra@oracle.com, vijay.ac.kumar@oracle.com,
        peterz@infradead.org, mhocko@suse.com, jack@suse.cz,
        lstoakes@gmail.com, hughd@google.com, thomas.tai@oracle.com,
        paul.gortmaker@windriver.com, ross.zwisler@linux.intel.com,
        dave.jiang@intel.com, willy@infradead.org, ying.huang@intel.com,
        zhongjiang@huawei.com, minchan@kernel.org, vegard.nossum@oracle.com,
        imbrenda@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com,
        aarcange@redhat.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
        linux-mm@kvack.org, khalid@gonehiking.org
References: <cover.1502219353.git.khalid.aziz@oracle.com>
 <cover.1502219353.git.khalid.aziz@oracle.com>
 <3a687666c2e7972fb6d2379848f31006ac1dd59a.1502219353.git.khalid.aziz@oracle.com>
 <20170815.215834.141971110430980112.davem@davemloft.net>
From: Khalid Aziz <khalid.aziz@oracle.com>
Organization: Oracle Corp
Message-ID: <dcf03dde-acd0-b7a3-cc5e-1e0fe98efbe8@oracle.com>
Date: Wed, 16 Aug 2017 08:44:58 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170815.215834.141971110430980112.davem@davemloft.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/15/2017 10:58 PM, David Miller wrote:
> From: Khalid Aziz <khalid.aziz@oracle.com>
> Date: Wed,  9 Aug 2017 15:26:02 -0600
> 
>> +void adi_restore_tags(struct mm_struct *mm, struct vm_area_struct *vma,
>> +		      unsigned long addr, pte_t pte)
>> +{
>   ...
>> +	tag = tag_start(addr, tag_desc);
>> +	paddr = pte_val(pte) & _PAGE_PADDR_4V;
>> +	for (tmp = paddr; tmp < (paddr+PAGE_SIZE); tmp += adi_blksize()) {
>> +		version1 = (*tag) >> 4;
>> +		version2 = (*tag) & 0x0f;
>> +		*tag++ = 0;
>> +		asm volatile("stxa %0, [%1] %2\n\t"
>> +			:
>> +			: "r" (version1), "r" (tmp),
>> +			  "i" (ASI_MCD_REAL));
>> +		tmp += adi_blksize();
>> +		asm volatile("stxa %0, [%1] %2\n\t"
>> +			:
>> +			: "r" (version2), "r" (tmp),
>> +			  "i" (ASI_MCD_REAL));
>> +	}
>> +	asm volatile("membar #Sync\n\t");
> 
> You do a membar here.
> 
>> +		for (i = pfrom; i < (pfrom + PAGE_SIZE); i += adi_blksize()) {
>> +			asm volatile("ldxa [%1] %2, %0\n\t"
>> +					: "=r" (adi_tag)
>> +					:  "r" (i), "i" (ASI_MCD_REAL));
>> +			asm volatile("stxa %0, [%1] %2\n\t"
>> +					:
>> +					: "r" (adi_tag), "r" (pto),
>> +					  "i" (ASI_MCD_REAL));
> 
> But not here.
> 
> Is this OK?  I suspect you need to add a membar this this second piece
> of MCD tag storing code.

Hi Dave,

You are right. This tag storing code needs membar as well. I will add that.

Thanks,
Khalid