From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F851214A84 for ; Thu, 9 Jan 2025 07:45:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736408758; cv=none; b=bo7sg1WRSPAJ1t+RbIWKBUhg8ikl8+k8y9QQFtYuMOi+qgwUHdYO40yMX3kNqbfy2Ahyuwp4hsS7tOVbeFZWQCdduYJ/t8H9VGNMap9kXdi6ax1j6zk0B2kTF2VJuPtY6aBPMB1IM53+Vu4jx7uXVpEJYND6YBA6u9+jW9dxTi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736408758; c=relaxed/simple; bh=wJLBLVJw1KkjAyK32dUglrjiyJ1EAVE+CqnalBZuC5c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f8otlE7Heihhm1j7vqeqrkWreL83pMnQmJMnCxCueug4lDmn3cJcPissrlXsxJKZujvzfCkpbErMOROHh0Y+5rNtGLj1hPhs2Hkm0755UMO+mhE3ZcWVrV1i4FE4VV0DyCIaSMOzrHRJiI7ZH+72874Z/eRaWpLzdq+eqyinzN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hnQ3TaEK; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hnQ3TaEK" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3863c36a731so414423f8f.1 for ; Wed, 08 Jan 2025 23:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736408754; x=1737013554; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wDPDfFPx9ymk/j+yrQwmFxxKqrVHqKkdkC69CbeqD5s=; b=hnQ3TaEKA+K9tFcPkZLSu79VEyIXVxKHFyEhItbSkUx2SFSGgBL1Lji4owQlXYTikG 9S36nSsDtejkQXlKjXQrdhC2w2QrVTq/arzxHqs9EPhKAqaduJ0OQ9pNtzdIwVcmjxPS HR8aDaagILZGYdhmY18/2rWSr1HI6if3/6LdQNAeyBWTQUSPB9BUxGSYoB7pDLeRjyMy Z76J+Na51HUM/PO0Ax1EY/72+lSgXOWyfdHNVWDG3cB0lFzlSS39+e+gi88rhm+MkC/+ FvpcdI9lpWYRPvFn/lh728qdxLYMZM8htVZAtVdJE9u3lh6mnLsRY51+ornbLPRrJ8b9 zE5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736408754; x=1737013554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wDPDfFPx9ymk/j+yrQwmFxxKqrVHqKkdkC69CbeqD5s=; b=eIDd9WBaMfxu1wU+Du8GSYaDXcKKfUP6SeqIg3267iBu12lsCu6BxioQ3eedKBiPae ApXTMZ5LQYCIiHfgTLRXOkB6cRxq+CZCYGcp2MlwPhLIzg21EjbWgnC2iZTWYIUWEF3M 19am7DvkhvYrj7X1ISKMsq8fA4xL2B7AXfBNwdfLdP6ev2cro+Ofo6tuQ2/ancJpgJLm uTo+Ox612T4oO2g9Xrtimq7iwEkGalNIXjZ9TVupnZh171pYFZgQwRh7Kwz5shMYGem3 LVGulN5c9Icn/0uCbstUFpM8LQMlJMilS69tWWJy8v1CpILPbXFS+SIsR8t4cFQcG+hw tWFg== X-Forwarded-Encrypted: i=1; AJvYcCXe1qbK9/EhMiuyvwpIQpGYjHfj6gR9FU6uRtN/sL8S6oTwSKS8pOUIiWeFAtnK2YYUBa65KxOQEzpX8Jc=@vger.kernel.org X-Gm-Message-State: AOJu0YyYvzZo1RZi4XbR0ztyeQAu3xBwa6TsojWfL3El0xzjSmSkjtKF pXfg1Hmp4tc0z+PduVbBE8HgE3qe6LhcTzxwZjjwLgiRPisMSHdqrVFFKZWx+BU= X-Gm-Gg: ASbGnctICC+dNvwktGPPuDJf8x4xzRu+yPvfgOrdneY3tINaA5fSKdMXsmdSZWFjeZH P92KOOq8oXcauLy/xYP9u1LDQq8cBu7uoniondb3KQVT8gR20Nb/CcFVBawnyiqKEknaruL0vmZ XhLNcJEk6KyRgbAt7GgSKMXkjn3APS+GJRzcrooecyf5DD7zdtCcm4UpCb6h+dnbQMi0mo7Gcl5 GJ+sPg1/Kw1caTKJZDMGQ9+bq6v5ISXP3CNHgfCRFS/dapSkJ0yCwOGFifw8w== X-Google-Smtp-Source: AGHT+IEo1TDze8qDTS+/8umRS35r51lCZq582badmEBI2lk5GEiWcjyQ1m1M0MbTn8XadxGeH7MivQ== X-Received: by 2002:a5d:5f82:0:b0:386:3262:28c6 with SMTP id ffacd0b85a97d-38a872fc0famr4878299f8f.5.1736408754580; Wed, 08 Jan 2025 23:45:54 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4c1dc6sm1015700f8f.96.2025.01.08.23.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 23:45:53 -0800 (PST) Date: Thu, 9 Jan 2025 10:45:50 +0300 From: Dan Carpenter To: Alex Elder Cc: Will Walsh , Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: greybus: remove unnecessary parentheses Message-ID: References: <20250109003624.37323-1-iron.will.walsh@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 08, 2025 at 08:56:50PM -0600, Alex Elder wrote: > On 1/8/25 6:36 PM, Will Walsh wrote: > > Unnecessary parentheses in boolean comparisons make it harder to read. > > > > Removed the extra parentheses on line 305 for code readability. > > > > Signed-off-by: Will Walsh > > I'm not sure this makes a big difference in readability but I > personally avoid extra parentheses unless adding them makes a > compiler warning go away. It's not a compiler warning, it checkpatch. regards, dan carpenter