Re: [PATCH v1 03/14] arm64: defconfig: rebuild default configuration

[Marcel Ziswiler <marcel.ziswiler@toradex.com>]

On Mon, 2022-01-10 at 09:39 +0100, Krzysztof Kozlowski wrote:
> On 07/01/2022 19:03, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > Run "make defconfig; make savedefconfig" to rebuild defconfig.
> > 
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > ---
> > 
> >  arch/arm64/configs/defconfig | 135 +++++++++++++----------------------
> >  1 file changed, 50 insertions(+), 85 deletions(-)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index cc5d3ba166b1..79e4bf9f4c2c 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
[snip]
> > @@ -1177,11 +1146,9 @@ CONFIG_FPGA_REGION=m
> >  CONFIG_OF_FPGA_REGION=m
> >  CONFIG_TEE=y
> >  CONFIG_OPTEE=y
> > -CONFIG_SLIMBUS=m
> 
> NAK, blind savedefconfig is undesirable because it later might cause
> dropping of configs (see DEBUGFS case). We discussed it from time to time...

Yes, I agree. I am very sorry that I did not include more information about it. I will do so in v2.

> Basically you should never remove user-selectable options from defconfig.

Yes, actually this particular one is now already enabled anyway. But I will detail all this in v2.

> > +CONFIG_MUX_MMIO=y
> >  CONFIG_SLIM_QCOM_CTRL=m
> >  CONFIG_SLIM_QCOM_NGD_CTRL=m
> > -CONFIG_MUX_MMIO=y
> > -CONFIG_INTERCONNECT=y
> 
> Same.
> 
> >  CONFIG_INTERCONNECT_IMX=m
> >  CONFIG_INTERCONNECT_IMX8MM=m
> >  CONFIG_INTERCONNECT_IMX8MN=m
> > @@ -1209,7 +1176,6 @@ CONFIG_OVERLAY_FS=m
> >  CONFIG_VFAT_FS=y
> >  CONFIG_TMPFS_POSIX_ACL=y
> >  CONFIG_HUGETLBFS=y
> > -CONFIG_CONFIGFS_FS=y
> 
> The same.
> 
> There might be more of such. Don't run savedefconfig blindly.

Yes, sorry again, that I did not include all the information.

> >  CONFIG_EFIVAR_FS=y
> >  CONFIG_SQUASHFS=y
> >  CONFIG_NFS_FS=y
> > @@ -1241,6 +1207,5 @@ CONFIG_MAGIC_SYSRQ=y
> >  CONFIG_DEBUG_FS=y
> >  CONFIG_DEBUG_KERNEL=y
> >  # CONFIG_SCHED_DEBUG is not set
> > -# CONFIG_DEBUG_PREEMPT is not set
> >  # CONFIG_FTRACE is not set
> >  CONFIG_MEMTEST=y
> > 
> 
> 
> Best regards,
> Krzysztof

Cheers

Marcel