From: Erikas Bitovtas <xerikasxx@gmail.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kevin Tsai" <ktsai@capellamicro.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: Add binding document for cm36686
Date: Mon, 9 Feb 2026 17:02:46 +0200 [thread overview]
Message-ID: <dcff3895-53c6-496c-8574-96943d1eddc5@gmail.com> (raw)
In-Reply-To: <5614db64-3ee4-4a41-bd8b-5b89cc3264aa@kernel.org>
> Compatible says cm36672p... Confusing.
> Why higher number is the fallback? Explain this in the commit msg.
This driver was initially written for cm36686, which is an ambient light and
proximity sensor. But cm36672p shares the same register and regfield layout, it
is just missing an ambient light channel, because it is a proximity-only sensor
and has no ambient light registers.
In v1 the compatible looked like this:
compatible:
enum:
- capella,cm36686
- capella,cm36672p
next prev parent reply other threads:[~2026-02-09 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 14:23 [PATCH v2 0/2] iio: light: Add support for Capella cm36686 and cm36672p sensors Erikas Bitovtas
2026-02-09 14:23 ` [PATCH v2 1/2] dt-bindings: Add binding document for cm36686 Erikas Bitovtas
2026-02-09 14:45 ` Krzysztof Kozlowski
2026-02-09 15:02 ` Erikas Bitovtas [this message]
2026-02-09 16:12 ` Krzysztof Kozlowski
2026-02-09 14:23 ` [PATCH v2 2/2] iio: light: Add support for Capella cm36686 and cm36672p sensors Erikas Bitovtas
2026-02-10 3:27 ` kernel test robot
2026-02-09 15:48 ` [PATCH v2 0/2] " Andy Shevchenko
2026-02-09 15:49 ` Andy Shevchenko
2026-02-09 18:20 ` Erikas Bitovtas
2026-02-09 18:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcff3895-53c6-496c-8574-96943d1eddc5@gmail.com \
--to=xerikasxx@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=ktsai@capellamicro.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®