From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E17813EAC61 for ; Thu, 6 Aug 2026 10:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786011566; cv=none; b=DD4CYgsBUj8XY4DQ++oloL7UsosBAON4aZvs3/jHo1A0EeBiB2ETzMOK636+J04y281L29/P9/sWQf4CIgaXxOlarRbMHgO8eitNRuX7eAZVafBP2b9jOvTDMs6iZRlwhg2a53NjffUvJLNajmra+NNYwjlytXHVyppL7HtdFWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786011566; c=relaxed/simple; bh=rNDF6Fc1Nx8BSJb7zv0d/HGA5TytMPXHoOXWeTu5FfY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=dSofkfC9aqBVqpiCXHTpj82OfA7CKJtOHF65tnBT22NLTEq8yLSvF0IcjL6C8JJqm9E97ENPNyS0Ae9NRQ9URAkHyqe8ki8xDLsrydW35BN/6EAbMK/moPH7jmqf4zX/z05O7YIKC9gRnKnfJcSGBPZ3FFuK/YQJVuYYMMWS4kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L3RSyiy9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Mk1WANRe; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L3RSyiy9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Mk1WANRe" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6769neJ72104782 for ; Thu, 6 Aug 2026 10:19:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SF4YFqwTJaTZdpTLrS1SvnqTddRHfDqH32rIPLqrPVw=; b=L3RSyiy99zz3K7Tv 5TxUKkgOkGgR/ViRGa0fVxGbIUQBcfjwliXHXWp0FuCrP1WCKmtsOgkVUH8AZ04+ 7JxR2Me0/iCWhiXva3cpnrWF4xNWhApDPXhQsLbABcAz8yyqgrMWiJQQFCH/eI2i TtYN8lmNOm4EX7AQWY+63KI2vST2amMHOs6zVikQ0yzWKOl1Vq0adEtZM6QF9YgK XaqQCpnvFeJETQ9FtVbh9yUIHQtng2oMKVe9M8ZhH/ibcHK/qm4bKZRikTeWLu5n o6ZB27TmM62XTh2lFYDYtqkz68R1zx1p/txoPAnadrIKomSwbVEzat37WBxhN6+S 8NwyjA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fvq730bmg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 06 Aug 2026 10:19:24 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8486c3411c8so2619046b3a.2 for ; Thu, 06 Aug 2026 03:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786011563; x=1786616363; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=SF4YFqwTJaTZdpTLrS1SvnqTddRHfDqH32rIPLqrPVw=; b=Mk1WANRemLafgMJyyd2jDPkLPGe9aSk4O9DDRN5/hKQbPz276vzZqe+z4sLgKpTqWF dr3VUYpMQtLIco6QnjhQsuB5jduz16HOgdybl+6xkvMaAgd23nv040MgK29XZQtoFWUZ fG3AccYYacfqL7QxpzbuWNF3edks7aWM+H9W69GuIyFhlrqNUFLXMX5MJxv7GGfIXufc JXgvTgW/7+wPSnUAPurciBU6Fgdjpzn4qKR1ynKF9CpIkMGS/UNgk8Uh1cBBTS4Y+v/I wBe0fphyGdLbBVS/EruyURdvHIcvyYYwGn3YKj5EMq1xP6EuB7BRQY3NMRBP4gdLS6ul H9OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786011563; x=1786616363; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SF4YFqwTJaTZdpTLrS1SvnqTddRHfDqH32rIPLqrPVw=; b=VdqjboaB6w0Z5RNqKkMZWleMbDiMKsm7IBslk9pnZ2zJ98npaIw3JDSAE2AaMr+W9L ab7Zb8VRRZqbyiuc6PvVx6cbHgzkqWxK669eCDL5iknO8HseA1c4OqW1pcS+izQnEYfL em3YFv+Ws+hCCGEVSPQodjL3dRcI6jIUeVfen6gmE+SPdR6fDP/9oqteHASYiD0vg8k7 d+tML/MVMwvgOmZtoPIveoTfb13mWi7r4Dcp2ttTGSa6w8TsnRUk2GhDCoJIuEeC/8Fx elPNy0MYcwwYgm7r8n/233D0elEJ1OqFOoIVjkm3dX+ctGvUto7MsMK7lNMD1ZOWpDRg Nb4Q== X-Forwarded-Encrypted: i=1; AHgh+RrH4nbWPIdT3CcYEBmg4Z2x/u0AjSmIMJUmnMYFf0uXcvCT0tv7fyYdbUAwd7hquaJlDgvZqUU027VPCA8=@vger.kernel.org X-Gm-Message-State: AOJu0YzU66FZ19ychAQ46YJgL9yb/yKXWet05f9f3dA7uAIR5dJKxbqK 9SXdAIGebwnioajl4pR/Pm3T1+D8dPcyfgxd0OjYwkvk+i6+dmB/o3kpHRWmD1PhpXaXShcCjnx TvFSPNSWzs3Ulhtam5wr86fY8rIKVPaiDldhIvASoQwRo44fNxuYVu1wHrlbtEhvd2Wk= X-Gm-Gg: AR+sD128hdXQ8P/qwjI303Ybh3YWVGM+szSDgNTvrIjf21FP48u7jCFc/5fDMHM+p2l EKGQa0ZbmnrvwEFg3bX2ev1Cb7Yy1f7ShVp1YI8Znt7Hn7ZJJf9bAM0A5BuwCp3kNPOqeFGv7OS G6c1NetPTeVw5IuM8SuZqt9mfM6H2Fk8lCNNXgoNFm3g3aqeAIOZVr1JKlJJ8BbpnoYZeLT38L/ k833AS+mahQeHwrWndAU7+ryVMWrtva3C7G2Wj9l8+W9AJN1FGEhvrLHpJEQsN5Dz+jLkA5J5CR KrTFyiWfb251HGNJbftpdLX2tfln7u6ZNKYE6jk+GIsx8MGHNXsSd5K6B4uLrVdHONZH1Tki7WD LudBrds94BmBCbz09q+XpPWNRgxl+85Y= X-Received: by 2002:aa7:9303:0:b0:848:77b3:579a with SMTP id d2e1a72fcca58-84f2dfeb92dmr16446730b3a.17.1786011563503; Thu, 06 Aug 2026 03:19:23 -0700 (PDT) X-Received: by 2002:aa7:9303:0:b0:848:77b3:579a with SMTP id d2e1a72fcca58-84f2dfeb92dmr16446688b3a.17.1786011562962; Thu, 06 Aug 2026 03:19:22 -0700 (PDT) Received: from [10.218.14.97] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f459bad48sm1089601b3a.47.2026.08.06.03.19.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 03:19:22 -0700 (PDT) Message-ID: Date: Thu, 6 Aug 2026 15:49:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: qcom-geni: Simplify PM resume error handling To: Mukesh Kumar Savaliya , andi.shyti@kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, viken.dadhaniya@oss.qualcomm.com References: <20260805070013.494426-1-mukesh.savaliya@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <20260805070013.494426-1-mukesh.savaliya@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA2MDA4MCBTYWx0ZWRfX1BSf3gx+v+oO ktDM9S4m8pYPD/Wqu2q2dYZj5jcfcBijd2CwSH4vLmwOqww4J3rRwKn6XWo2O2WQ/ftFM0cNyAg wlj/MgzQktYtMs1Qq5gX7TosiMfDqof/LeP2A95PG9pA7bqRYHYxhehwvKEsz876NQOjmAGnPT1 igjc5iSvV2FzYWIv4oNyloIpFZBVTovdEpYU5sRm2bpsb6gGTuolwYIreXaUuCfIbpW0J8+fGtI GLpwHwcp7/dkzkFZm5J1TqPKr7Rd6hJt3ojFxyJjE3SAVrS4kIuoAPM6SOEg4ERVnaYGzVhWfIz RW8C7z4lAnhu1+f1miXBoGfnz1qgXzrP0eW37D0FLWllsutBQEN7M5xOYVYrY64M0fW9XzzrxFM Bnw74MgpKBSVkhKjfR5BBxxvF1Mp7GCx6NV7u/5TtAHdubcczgANSbMPnlKYdA52jg3Piqm6AID M8BLCApPH1kgbK8jsAw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODA2MDA4MCBTYWx0ZWRfXwk8T3J818Vty G8QA6aoioxkGXTY2LWFvIjXnfkmkwIGDjnWOdFbd5cOjCx9kThEl3gjL+kEeSgzj30k3UQJD3FB nmHQDIS+EQl/WM9rFQv3tveJGnTTbp4= X-Authority-Analysis: v=2.4 cv=EeH4hvmC c=1 sm=1 tr=0 ts=6a745fac cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=6z8TwaGRFWoLiM2ZyNYA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: JbqbmBEW7q5lte1IFr4862vOjKrPA_iy X-Proofpoint-GUID: JbqbmBEW7q5lte1IFr4862vOjKrPA_iy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_06,2026-08-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 suspectscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608060080 On 05-08-2026 12:30, Mukesh Kumar Savaliya wrote: > The driver currently logs pm_runtime_resume_and_get() failures with > dev_err() and returns the error code separately. > > Replace this with dev_err_probe(), which combines the dev_err() log > message and the return value propagation into a single call, consistent > with how all other error paths in this driver already report failures. > > No functional change intended. > > Signed-off-by: Mukesh Kumar Savaliya > --- > drivers/i2c/busses/i2c-qcom-geni.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index d5c977e34994..96015e077b69 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -994,10 +994,8 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) > int ret; > > ret = pm_runtime_resume_and_get(gi2c->se.dev); > - if (ret < 0) { > - dev_err(gi2c->se.dev, "error turning on device :%d\n", ret); > - return ret; > - } > + if (ret < 0) > + return dev_err_probe(gi2c->se.dev, ret, "error turning on device\n"); > > proto = geni_se_read_proto(&gi2c->se); > if (proto == GENI_SE_INVALID_PROTO) { Acked-by: Praveen Talari