From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D24B2571C5 for ; Wed, 31 Dec 2025 12:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767182705; cv=none; b=oD6eLReGJvx+bDUFptXQSYD2nrSPFPgQM7dfBHsKVl/0Fit4kL9pYqYdPoqqAth8ITEaQUAjYmzOTB/jobeloK8F02wkiXJCJ2V0k8SKeiQV5jts4xrImLbQN9fYUryvIFx+ISDKN/SVUZlNRCfjYu5qWwKUYs+3kRnckltx4uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767182705; c=relaxed/simple; bh=SENiCz0Nn5G8mBkqXLcSD4qJTOucujaqgbE5UhXTpPc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SbZ7c51MpXMzm7m2zhlcdwH4uLyXvo+Ce5LJtu7HR+OmmPZVDCfd57fjoOVx1KOHidF9TykfAKdy42slcZl8qhPgaNe7IXH/addH2rP83mbrVSDvrzBratOnKkEP+JjSwehH8IP/R4f90ncVGLUuxXkAeg5cfXU9gw2Ur2QCwFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YbOT9Q4/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WiV4ZlzE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YbOT9Q4/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WiV4ZlzE" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BV3dQNv1830478 for ; Wed, 31 Dec 2025 12:05:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cAiyfMF/g9yjPkCOoTBHtDUTlB8CTuK3gitehBAPkvg=; b=YbOT9Q4/hsa5nJM8 TIFznLqkCr/ro3BwOmX1HN8+eyL3/4lPdrtWG+XrICtYanVCzX8mUnVPczlkRzS5 NgeTX7fejQHXSMu1pOHPa/Z+IyVCvdG+xIYNsx5b7RjPeoiwGpSCdZc6laz/yrMY vuGlayM4mcukTYOTHWmZv3oHMtYvcQ2DJLg9Ams+UUrqsauc2nuHISzYeG+Xdthg GXMGPqrKoJEOTdmf44BGdWSUTC7fepB1sRo1f+MIaP2s+ktpdsa8GO7m07pB3YcU HTU5eLieB4kLQAVLLd644PsW58xTHipwv9YCKX9rRwTz5icQPRG6R20ywXgLLDNr jCQy3Q== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bcv4agtjb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 31 Dec 2025 12:05:01 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8887c61412bso37018806d6.1 for ; Wed, 31 Dec 2025 04:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767182701; x=1767787501; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cAiyfMF/g9yjPkCOoTBHtDUTlB8CTuK3gitehBAPkvg=; b=WiV4ZlzEBa9YTRbjkI8jkonTNxWEEdZAIf4zzplXwj1jomFhdY0T/UM0dcFYZlcuCu jJbE0coDle/hwBq6PNAgPcAMPYQ2X5+4pe9XBnIWkRq9sugFKqwM81R2KWKMpFG87RXd RkyizpPC8V0YugkcPVXHbhAauViThaZmub2CQT8FQSYEklSeBidQ4/Os7Zl4gNdV+XUF 46lmHguetnxYQp1ioYj16a4+V/COo7/W/52p72l4U4+C70Kic29YoIKh1beyiB0CIG+0 HAGlRAjuAKdCXAgfvUSOGwiwh4HDheja5vyYwoQvccTFnd/8CuPa4ucUKPG5dJNci6vU 20yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767182701; x=1767787501; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cAiyfMF/g9yjPkCOoTBHtDUTlB8CTuK3gitehBAPkvg=; b=gOIALh67NSXcHCBurHcOo1wJ43w5WWWtavIqXxk20vddzFzO5M4mwLr3/2hPKP14I9 NFtydZEoJq/vMCIeFURriG4Ew29G0ygX7uz3O0kFCxInarMUy5wZoli4BuqXetP3Quid Cb8xRF6G/7TDyK/IGRXnw03YqXt62LVQ/9nKLrqn/pHIe0lI49noF8sMkz8OJjoFUS/L x5Ml7jaimFV5UGId5FnPSKsDjlT3GyLc8GaDoVgPzKT/S0ys6dV6m/KrJm9O1y5TGlxL tmxs1c5aX9rsxMHGBamxg/14yHT7Xbk4NViA6UWAdWckqo4laGN+9oCtW7Tl31gVgjMm NrTg== X-Forwarded-Encrypted: i=1; AJvYcCWiGNxBvORtGFXZynF/AD5z0Tv3MYuM3ZlVhI4UDAiBqeN4ZBb9rFQD0NONDheBra3/J1/ZR54D5oz5g8g=@vger.kernel.org X-Gm-Message-State: AOJu0Yzol6phzlvozNGUOiF79U9/GZAkO5+pCzyutpP9YAv6G9Ss/l1T LSBaNi9VvKc3fVHfAHV2C5cAjJGqD57sEks4LUsaBtOUxDkUEY1tLyvFS4bCMKpmLigfE+9UZ0B 8W6DKTqhwoRtFwVYVyso+jdIybJjRAHV4LVHcjaDr7WqP5k/uFdAzbai+SByRI7O4oeY= X-Gm-Gg: AY/fxX6KsfiRNMGR+CT8v0FboenrHqp32z9jRKj18fh9neCvduzDU+gSx7IuC5Brzcb qBxRHnzuXxhjbyoojjiBJO4gY0zMHIard/7fOwL/UCKZpzaNAB6fM/k9PJteDNKF541T4/9MXIB IGOMs/KsN0zrqhnDvH9CTb2P55ma1vZSguWwaw0d1nDLyL1TYIye+bVO9MwXmAAgDswt3X1H5b6 0usZqPc1Nur2Cj7rv33ijp2gSJDHbRIn2du8SGMz+bj+QuhFIw5EvxfEpWpy3g3hJJeSfj2oYCe UEflUS2kkzNatmW6Gz67Z4LB+NiJZeoYCEVUiXQ4kdpPz1OvQ38GCbq9DEX6OXdH6hE9KDiG2S4 XxyUCbIoRZNG8vp6/1NFBOIBgV/FkU5Zvn5qmiXsL2ZcFFWQUmsPA/iafUBUgt/8zVg== X-Received: by 2002:a05:622a:cc:b0:4ee:1db1:a61d with SMTP id d75a77b69052e-4f4abcf3ba4mr419279471cf.3.1767182700798; Wed, 31 Dec 2025 04:05:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmspfRwTHtI0ttV2ZEBE7PjFXjLSRr3IkJr1HAIkpcbq09C8vb9gCxrZVPdH50btLnUkiSig== X-Received: by 2002:a05:622a:cc:b0:4ee:1db1:a61d with SMTP id d75a77b69052e-4f4abcf3ba4mr419279021cf.3.1767182700295; Wed, 31 Dec 2025 04:05:00 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b9159ac90sm37752595a12.29.2025.12.31.04.04.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Dec 2025 04:04:59 -0800 (PST) Message-ID: Date: Wed, 31 Dec 2025 13:04:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/14] Bluetooth: qca: fix ROM version reading on WCN3998 chips To: Dmitry Baryshkov , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , Jeff Johnson , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , Vinod Koul , Balakrishna Godavarthi , Matthias Kaehlcke Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-pm@vger.kernel.org, Krzysztof Kozlowski References: <20251231-wcn3990-pwrctl-v1-0-1ff4d6028ad5@oss.qualcomm.com> <20251231-wcn3990-pwrctl-v1-3-1ff4d6028ad5@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251231-wcn3990-pwrctl-v1-3-1ff4d6028ad5@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: EDByZ2K74JW5q-2TRZ23TLzv0F7QeAm0 X-Authority-Analysis: v=2.4 cv=Ps6ergM3 c=1 sm=1 tr=0 ts=6955116d cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=_XeksoCtAhHN6JefJdYA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMxMDEwNSBTYWx0ZWRfXzs+rY9v05wAl pV4ebY0RgkdIV4RFXyYC2oN/Cj7CwmMGlj6xYyXG1MDBIao2gpf6reVcrUYNYCQwj6XLzGVEGRg b7hrmwBLkhJaN4c9+yJdvQIj9GCVC7+rzzM4cdt/A/C15t7sYu3SvraqZSluKePq1TlDatkqtfh CHioDlGwiQVfK3rrQpefrBd0LFP3lDW3C43xIc3mG+E/qzO30ZopBUTbwIUJD3YluKNME2fkxGw f8JtND3mODj8Tl1eglTmzMaBALs4vZe02kytb+rWZj/y3CuXQkFtZNStQXlidpRTWeMBJ9kUdkD 0ly8BZ3yE+Y1QBxVUQikz1z31yQ4zYQHvURPWNra+2Z/WfgdLDsorO+FWNb73TwkstdMyGzMx2g 5qAwiPjc5alOCo5gmIqC3ondhStyoYvljSinVLRUMg0AfQ/0zDL54OlLeNN5seGTRnDq9EF2t0c Ag1mRzCafOgVS6wqRsA== X-Proofpoint-GUID: EDByZ2K74JW5q-2TRZ23TLzv0F7QeAm0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-31_03,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512310105 On 12/31/25 12:35 AM, Dmitry Baryshkov wrote: > WCN3998 uses a bit different format for rom version: > > [ 5.479978] Bluetooth: hci0: setting up wcn399x > [ 5.633763] Bluetooth: hci0: QCA Product ID :0x0000000a > [ 5.645350] Bluetooth: hci0: QCA SOC Version :0x40010224 > [ 5.650906] Bluetooth: hci0: QCA ROM Version :0x00001001 > [ 5.665173] Bluetooth: hci0: QCA Patch Version:0x00006699 > [ 5.679356] Bluetooth: hci0: QCA controller version 0x02241001 > [ 5.691109] Bluetooth: hci0: QCA Downloading qca/crbtfw21.tlv > [ 6.680102] Bluetooth: hci0: QCA Downloading qca/crnv21.bin > [ 6.842948] Bluetooth: hci0: QCA setup on UART is completed > > Fixes: 523760b7ff88 ("Bluetooth: hci_qca: Added support for WCN3998") > Signed-off-by: Dmitry Baryshkov > --- > drivers/bluetooth/btqca.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c > index 7c958d6065be..86a48d009d1b 100644 > --- a/drivers/bluetooth/btqca.c > +++ b/drivers/bluetooth/btqca.c > @@ -804,6 +804,8 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, > */ > if (soc_type == QCA_WCN3988) > rom_ver = ((soc_ver & 0x00000f00) >> 0x05) | (soc_ver & 0x0000000f); > + else if (soc_type == QCA_WCN3998) > + rom_ver = ((soc_ver & 0x0000f000) >> 0x07) | (soc_ver & 0x0000000f); > else > rom_ver = ((soc_ver & 0x00000f00) >> 0x04) | (soc_ver & 0x0000000f); This looks like rom_ver is essentially maj|min or so with min = 4lsb and maj being a couple bits up.. no big deal in the end, but this could be expressed more nicely Konrad