From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA03C433ED for ; Thu, 15 Apr 2021 16:04:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FE20611AD for ; Thu, 15 Apr 2021 16:04:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234152AbhDOQEr (ORCPT ); Thu, 15 Apr 2021 12:04:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233734AbhDOQEk (ORCPT ); Thu, 15 Apr 2021 12:04:40 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DC08C061574; Thu, 15 Apr 2021 09:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=l8YXxHl5FfuimubfvcxmzJgMq+3HqkH1Xf70Zd6yln4=; b=LDlcmZCLGC7nLxW5erwgytybMS 3dX62eN/PzqtcA8eyW7pF4fkM4zzoaSuXKDJSLc1fxNMAOr2YPjMI/EH5rcrNdG1ckzjf3trNEKHj ZgB7oSHcU+WghUSiCwin45Fw45tH9fOPjBSQAb4RaISDmdmtd1twU1asPJ3uNNsj9ogbmBmgSNXR4 mMT2udkp4tKmlMljnG97MD5fF5KCuOZ57e9+U4k9qQFzBy2mhJ6yx2YFUqIN8Y+ZSdmEyjKesgHLI FIr+fXdQ+5O+5VrIi8t+FaIRKWF/xOFkAXiKoIqTLZZtkJOjs6EsZEFBrI58JV7GgFAgzrvvVqwLC lEO38PEw==; Received: from [2601:1c0:6280:3f0::df68] by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lX4T3-008mxN-3R; Thu, 15 Apr 2021 16:03:49 +0000 Subject: Re: [PATCH] uml: fix W=1 missing-include-dirs warnings To: Masahiro Yamada Cc: Linux Kernel Mailing List , Michal Marek , Linux Kbuild mailing list , Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org References: <20210414192657.17764-1-rdunlap@infradead.org> From: Randy Dunlap Message-ID: Date: Thu, 15 Apr 2021 09:03:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/15/21 12:04 AM, Masahiro Yamada wrote: > On Thu, Apr 15, 2021 at 4:02 PM Randy Dunlap wrote: >> >> On 4/14/21 11:52 PM, Masahiro Yamada wrote: >>> On Thu, Apr 15, 2021 at 4:27 AM Randy Dunlap wrote: >>>> >>>> Currently when using "W=1" with UML builds, there are over 700 warnings >>>> like so: >>>> >>>> CC arch/um/drivers/stderr_console.o >>>> cc1: warning: ./arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] >>>> >>>> but arch/um/ does not have include/uapi/ at all, so don't >>>> include arch/um/include/uapi/ in USERINCLUDE for UML. >> >> >>>> Option 4: simply mkdir arch/um/include/uapi >>>> That's what I did first, just as a test, and it works. >>> >>> >>> I like Option 4. >>> >>> But, you cannot do "mkdir -p arch/um/include/uapi" at build-time >>> because the build system should not touch the source tree(, which >>> might be read-only) >>> for O= building. >>> >>> How about adding >>> >>> arch/um/include/uapi/asm/Kbuild, >>> >>> which is just having a SPDX one-liner? >> >> Wow! :) >> That's what Al Viro suggested also. >> I'll submit that patch later today (Thursday my time). >> >> thanks. >> -- >> ~Randy >> > > > BTW, after fixing this UML problem, > can we move -Wmissing-include-dirs to the top Makefile? I don't see why not. And eventually remove this one: fs/btrfs/Makefile:subdir-ccflags-y += -Wmissing-include-dirs > Is there any other source of -Wmissing-include-dirs > warnings? I can't give a full answer on that; only that I haven't seen any others and also that all other arch/*/include/ do have a uapi/ subdir. -- ~Randy