From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F036B3769E3 for ; Wed, 20 May 2026 12:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779280874; cv=none; b=J5tVqkhJNMgID68unBIc26k6dHQPt47O7FEGidpoKgIDxc174IBcybxIDBOfottmUeZaWFCh47ShvK5dHCn2G/XKWGW0vfoEaw7PwtsWknHeezfEgd6Vjo5S98pLvAI4gandUNNdSpdHhaGzVVhCiEFIJXBsSMO9GpaOU7nhkmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779280874; c=relaxed/simple; bh=WKswCxoOQ8jRILBr741XFfschLIhFZABWS7WRA9WPA4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WTfZvb05GoVpmv6KpWhlCkN+NfL5QnYT5uOgc9I08UvUGc+ar8A0/G5U4CTz5rAljJePjzDhb+ZSmD8GWe59xnKLyPgzMWKusofwAyMgYJ10N7aHYuNzvVObpVzM5Jim+V3jg34/e3DP1ozX1PhWdFWzlFn6gaL2/TEqy927wew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xf1JjL31; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g/UNwXUU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xf1JjL31"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g/UNwXUU" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64K9nXJO446929 for ; Wed, 20 May 2026 12:41:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LwsVm+YOh5jnyc4/SA6T4mh8Ap3/phALbTKY3f+nmlg=; b=Xf1JjL31MWue/lap J3Ws9trMgWZt8XbPO78iNZlRqn26iOEER487KxS7KsamPJydejXjubIlKlZiPyj5 d6NnTouIhl6dqnjJvpfhzyZ8Bi7YKEdMzq0DGRahBXKs/P/voFpazjMzKP53enGX a9F7MVs8jQ5jIAH24T1u97eqWQ9JjEFdD5xmondmAs4b9Ye4iYajUL2KG3RU03IP f4Na1mFim2YJPTgGAVwlcil36Kw7xqx27Py6sGKvjYYAlyqjl9bH0YuytO6aeIVv ioOdnXx43qvfl9liAQJWlSQWJL6iquvj4VjjZlJE+zyLbPSfgSutCzdSUyQ3oLhX ju0daw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9anrgktn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 12:41:11 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36641fe4aedso9417598a91.1 for ; Wed, 20 May 2026 05:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779280871; x=1779885671; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LwsVm+YOh5jnyc4/SA6T4mh8Ap3/phALbTKY3f+nmlg=; b=g/UNwXUUyHUK2HZzreEUHi8UAzPjge1B703fLBs17s1F/52pSd4ZgjsHpdjJBUZxhu ZLxralzC/uHSh+EuXqK2mVzQCbOw4bgbNN1fioN07K1duJc04axbJ4G92SzBbpKnz4NZ BIgff8jqV8NPAvR6Wt/z/TRH1KTIIsIC71oFhyiZvvNG+Hwz7MtxQAZo7kX8HAjAG1sc 0KuXw3SlPcSNOMeYTYavPV7eoAYFIRIbLkjINQdS9aQXdhdhd11CgpEXow0Aov8tYO4g bvwp39p2HcVo9sMGHl0jkBIa0y3Fh475aNRCXvUe/n2tezPMA2e88Vne9MvVqMmfGc8p 1Fjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779280871; x=1779885671; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LwsVm+YOh5jnyc4/SA6T4mh8Ap3/phALbTKY3f+nmlg=; b=JJ7wRLOJy2fqWXrcsMNvZ1WGM0Uu6slh2mjxnc9FDwbVBUR3gc9yF9qt0swyILSqD4 gj9vn9hyIHzAP9gx2C4YV8ndL2D18C4jQ/2bWlVPqOlhP22axr+mCyfOpz6Fcyb0/dpI Fv3y9Lsb7NhiDt9pJqOp6wksa/41YTwEy+l8XNkl9QRPDBTvMhqGYM09OuAemKhLymsK 5v/JGALhVGV0v4kQmCClIKxy8SxKB8yuacSPCmHL1RnhTCJPd8F2JFQKoKHe2EryBs1L xEIJKJgo6HD4xYqthFwwwcxhyotOKApGf0kZA+1JQrTfOczB0TO4aQ31NYoqUzpXrP5u jtfQ== X-Forwarded-Encrypted: i=1; AFNElJ96PppR8hFlX4LyoWeV7M1fmHj+Vx/Te0l8OFzqLUZ6PLIFodbOPQxr5bVEZBU1PegQyfTLJffsj3p/BE0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2Lml+7JGX1XmmmXP9MGANxLp72C5SSmF/2OsY9HKjzwuoOUv2 cRemG6n8WHEL5jmmqeqK9ExiPMIrvsScaoI7YD53HFE8nBcZK9nEN+aSthUbnRQRScvmx451Vti i7Oswo6lApmAewAwRga8lN0x9ua6Y91qI2R9L6VQR/VOe0RBIl9e+hdoBiqQaHs3yN4M= X-Gm-Gg: Acq92OGvEs1crRjZPDTbqizXvrxL54HkxV/MlpxT+oM41ZDcmiuV4pT9vZNqTjTCJfL yrytDU07aFKmlpu1w+c894to1BbD/2wUPUQlHPjREXR+7DaTOSFhGDbpP60UrlID0AFFGTrZuu5 WRGgWOOXXRChnIZjLyI1nTdZ94Y8UKV8Q29kpssiRx9TiVnRzpwmOiCZceC3OKGtYSwRSyd3Olo pM4oPo//xe76yCbuIJUTfU4dtXNKxFnzLtM8KLIeJ/jVk4uieGLL3n3EZBnfzy2DyP644RuIZWP 9DxIS0req1yn1WnUmR9Rp3JSp8yLs7N6iDsjipqGP4B7Y+IiXAaquqyay6EewKVOuPWgFtCAJzV FQ6SQykCxQAh9omEV+li0oWFOeo77pltEruwH7ei01UWAHRr6nZg= X-Received: by 2002:a17:90a:51e6:b0:369:932a:2b6d with SMTP id 98e67ed59e1d1-369932a2fa4mr10930264a91.6.1779280870554; Wed, 20 May 2026 05:41:10 -0700 (PDT) X-Received: by 2002:a17:90a:51e6:b0:369:932a:2b6d with SMTP id 98e67ed59e1d1-369932a2fa4mr10930248a91.6.1779280869950; Wed, 20 May 2026 05:41:09 -0700 (PDT) Received: from [10.206.100.243] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36968dae27bsm15522213a91.1.2026.05.20.05.41.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 05:41:09 -0700 (PDT) Message-ID: Date: Wed, 20 May 2026 18:10:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7807S panel controller To: Krzysztof Kozlowski , dmitry.baryshkov@oss.qualcomm.com Cc: Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ayushi Makhija , rajeevny@qti.qualcomm.com References: <20260518-ili7807s-panel-v1-0-d7b048163b1c@oss.qualcomm.com> <20260518-ili7807s-panel-v1-1-d7b048163b1c@oss.qualcomm.com> <20260519-curly-courageous-sturgeon-2facfe@quoll> Content-Language: en-US From: Arpit Saini In-Reply-To: <20260519-curly-courageous-sturgeon-2facfe@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: _aXTrozgTRiYa6uc-6dFCADdzDiX9_Jt X-Proofpoint-ORIG-GUID: _aXTrozgTRiYa6uc-6dFCADdzDiX9_Jt X-Authority-Analysis: v=2.4 cv=UuJT8ewB c=1 sm=1 tr=0 ts=6a0dabe7 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=e5mUnYsNAAAA:8 a=EUspDBNiAAAA:8 a=ERuXJlKj0EQyFFk6GMsA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=Vxmtnl_E_bksehYqCbjh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDEyMiBTYWx0ZWRfX0ztW2c6qn2qQ tJ8pRVIngqKZ2h7g5s7BpLzdSun9U/4X9JHaU8+I1HbYwrBgOguxdbbwgK7snYJcmJR0OsptRNj jfnLepzPf29coHZRcAa1a/3i+jgyBlRyA2Puzs+9VMOJaEyijCD4UOeTmnXsKeJ3KICtYwHopHf bUgNdmImOypqw8StsLrcbzet6Vpdsm5ayMawsXmTrBAJriBdoLZ7iPq4vTua/uxXE7fBaFZcqVz s5BAHvJCqhUGLoSXfolkLv7Njbid9lEF9MGPRBM13gKLJZPWrg5ppkV8CFBoEWqr0XktPgr7P8t C5agVoi63GCE68M7SPYlZrv5fKZ7buaPLQ+PRiCrIS4F3OF5OlYGCYtpeKzuuzByd1Sqe8pxa+n GTo+WdMSnjQg+xsXZ9PSKhH4Jglx/DAfCt6uIAo1sglrQ0OBO/u3zA2MoDVx4eiEKgJ2NdibHoj B0ZD2tK0w7IRxO+s3Gw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200122 Hi Krzysztof , Dmitry On 5/19/2026 4:02 PM, Krzysztof Kozlowski wrote: > On Mon, May 18, 2026 at 04:34:12PM +0530, Arpit Saini wrote: >> ILI7807S is a DSI display controller used to drive MIPI-DSI panels. >> The DLC DLC0697 1080x1920 LCD panel is based on this controller. >> >> The panel requires a reset GPIO, backlight enable GPIO, I/O voltage > > If panel requires it, so should the binding. > Ack, I will update. > ... > >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + reset-gpios: true >> + >> + backlight-en-gpios: >> + description: Backlight enable GPIO (active high) > > What is the name of the pin in ili7807s device? > Display daughter card has WLED driver as well as LCD bias driver. The WLED driver's Enable is coming from WLED_P1_EN and PWM is coming from LCD_CABC output of the panel. DISPLAY0_BACKLIGHT_ENABLE (GPIO 91) of ITP baseband card ==> WLED_P1_EN of Display Daughter Card (DC) In the display daughter card of Shikra ITP platform, we are not using the external PWM for WLED driver. But connected the CABC output of the panel to the WLED driver. Backlight update is happening using MIPI DCS command which is driving the CABC output (i.e., PWM for WLED). Because of above HW configuration, we need to enable the MIPI DCS brightness update on this panel. The below command of dlc0697_init_sequence() is enabling this. mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x24); After checking this, I realized that this panel can be used without the DCS backlight as well when it's using PWM based backlight control. I can add `has_dcs_backlight` in panel_desc and set it true for dlc0697. I will update bindings and add backlight as optional property. Currently "backlight-en" as optional. I will fix the commit text as Krzysztof pointed out and update the commit text to get add more clarity. please let me know if you have any comments. >> + >> + vddi-supply: >> + description: I/O voltage supply (1.8V) >> + >> + avdd-supply: >> + description: Positive LCD bias supply (AVDD), typically +5.5V >> + (range 4.5V to 6.3V) >> + >> + avee-supply: >> + description: Negative LCD bias supply (AVEE), typically -5.5V >> + (range -6.3V to -4.5V) >> + >> + port: true >> + >> +required: >> + - compatible >> + - reg >> + - reset-gpios >> + - vddi-supply >> + - avdd-supply >> + - avee-supply >> + - port >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + dsi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + panel@0 { >> + compatible = "dlc,dlc0697", "ilitek,ili7807s"; >> + reg = <0>; >> + >> + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; >> + backlight-en-gpios = <&tlmm 91 GPIO_ACTIVE_HIGH>; >> + >> + vddi-supply = <&pm4125_l15>; >> + avdd-supply = <&avdd>; >> + avee-supply = <&avee>; >> + >> + port { >> + panel_in: endpoint { >> + remote-endpoint = <&dsi0_out>; >> + }; >> + }; >> + }; >> + }; >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 26060e51c067..529aed669401 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -7941,6 +7941,13 @@ S: Maintained >> F: Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml >> F: drivers/gpu/drm/bridge/chipone-icn6211.c >> >> +DRM DRIVER FOR ILITEK ILI7807S DSI PANEL >> +M: Arpit Saini >> +S: Maintained >> +T: git https://gitlab.freedesktop.org/drm/misc/kernel.git > > Drop, unless you handle patches for this driver. Ack, I will update. > >> +F: Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml >> +F: drivers/gpu/drm/panel/panel-ilitek-ili7807s.c > > Drop, no such file at this point. Ack, I will update. > > Best regards, > Krzysztof >