From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93B4039D6E7 for ; Tue, 14 Apr 2026 08:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776156415; cv=none; b=EPETlYXaNI0m+FO6b7SUdSnnpHEZGTMun6h0jpnBcGEj51Ii8FWS6LcM5myiBx/11xQjI1xMjeD85m0zdRKNCjfexI76gp+JZKCZFjsjgsHYqbQf/h3QT2+mdbKvTP+toS/6X39mNS7/cYFT1YZ0HAnighU6Ms8gv4YhqAoR+1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776156415; c=relaxed/simple; bh=SYartanFMsIv2g6KjhxWu2Uxv7zuc881jae3LKtkqM0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=shzDl1OzXi/6D8bGS0EC8FcOk6ORU2PkakARVsnac++gIO868Qe3Ufif4xaOsuYEQHlgdtlvVVm7yjG5QXObx9/v8gThWtiq/ie0NPLiOzkADO+ghyaRxxKbSfpXq519arytuCApIXfpSQUQupUJRcc3m/FUTivpmBQyDJ7TagE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WBcIM9qG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Cu4H3Cju; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WBcIM9qG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Cu4H3Cju" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E6V0qk2509966 for ; Tue, 14 Apr 2026 08:46:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9HwoJ6Qkx24lge+pKZcUJTrizcXF0yAUZNbBWQ0V6Pw=; b=WBcIM9qGm8abf0gY wMOp1RpexZQQsSNkdTdA82jRVyfKGJSqjHr0TxsTzEe0vnHnIHg9aq2pAZccjpMK MGcYCsvRWnPGfD0WYebNRtByZ7qHsMYQdujy1sFI6bKsGHXrLHcm7beZrBJ94Wkx lgO7LkRj0cwK24rKZKNIOSqLcMOohc2KJlRkx5pAEU9/fFBJUqg4iaRG1eAYvOkB jJlnk5q8GJzRFmiDyB5ZX0zNqh4S15BD/Z4c3CXxwGc/2Bdd18HI8qvaWbiOZf4d LjnipRinigDQxNRx8L3qJcFuBiYXDN0cspq/8gYJI2c4xfwU7A7oi43p9ZbQLTvk wtYLqg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh867stuy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 08:46:52 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5073ed1ec6fso14247101cf.1 for ; Tue, 14 Apr 2026 01:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776156412; x=1776761212; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9HwoJ6Qkx24lge+pKZcUJTrizcXF0yAUZNbBWQ0V6Pw=; b=Cu4H3CjupsiK5PhTU/MysiM+xH1iHYLqpZqdTyXIFYpyQrZIAk7Hg9pjNjNTv5M8b/ MNUFkB4euJExVYqSk6tsgQsQW4lBncVfJg5lYRxtU4k2aF6nQ8ali7qWbWMGoaof/0Ed FZK2diP9JZ+jrfgzf9NIFJ5vRpD2Z2TCh90WVv2dQBTQJQvdgrFuMloyvO2ihVCqgM6A FVuxJD1EebMs5OqmzxbHLli07mIhaTLpNWdxxrdhHYwUMTUyn+xCi31NCWMWgeUSSgwV MfPw6yT0UOZhugJuGwlg6+d7NOMSJZV7yi65nHSEJ+bdNrVxybkqlhjDAuIea6RXLOWV R2cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776156412; x=1776761212; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9HwoJ6Qkx24lge+pKZcUJTrizcXF0yAUZNbBWQ0V6Pw=; b=czLGhRar+0s/xpQelPemdER0hO95d5l5WzD45c1Bnfka3+jrk6pzlDRH3rkXMgFDLk hG0yCdMifZHUlTN3TKlDmQa+lbVFA1MkUr4uqz2eGB9o/EE6O9LOp7dIv4RnDAJ8QsgY vfMTmhSJwDiywry6rHleYfp/kaH3Y4MygUIPfkoPM0fWFwOMXXnVaSYo1x8dc0wjMjBb mYObhHVbxE575bD4wFJK/r1P69EhSRXQOsKCxbJU51jCItM0QoMXLOX3RyMCHl1eLt3U ac8T5swJVJKwdcZpYPV2TVDv4SSoT2ZphjVF/tFTkG67Ti1Z3Em1m9K7kNoFD/vcx2LH J3kA== X-Forwarded-Encrypted: i=1; AFNElJ97rYmYeDllo7QVHCdxTEzTCF6Q9n3Jo4A+qgbuvqGStsIDwMphB7AdfY2fllbfevbRO7/PmJ8YzItvh90=@vger.kernel.org X-Gm-Message-State: AOJu0YyDM+Zh6Y9szX934Ob+o7nxGGxZM+c1ctla+Fk7WUKzXrW+LaGL lF22sZyxHx/aBEOsdM2JVwWKY+zr7mJ5GRc935pJ3Y0Ko5B/hDXV50b9h4nf55l65p9r9PQuajW 5IxVFCp+LNibDwJvuUuPu/J2n0u6ebRkEkqaMRclRxVBDsrzzhz1zjsjZVuz2ZE/UuA8= X-Gm-Gg: AeBDieu9fB3i9wRSaGhwkLpKZQwd5qnrYrHQCTfpoVoGdUi5rNwtP+aeNDjRnEhDoU2 XAvRWAhK88YPo+KOqAzoFAqN7JliP9Z7wVpxWfQ70soO1WaJVzfzH2QmK29x0QqzdqrTBqfws1z 31/NkgFh+VTqzI/gP2a4o7pEl7p4gJ7hvTpeO9i7H3ZbJfr2DMyFKCZJlW8iNiky/+iH44Cpv9A XRdrouUDc75DFKVmYW4FecDkwxD46Q3/FOZEG3C+r6AGZcZa9GwP9maCjZy8wfbtYTh7D5dIigb bofiq/mocqWmLR4sOJP9q1hnOYWY+CjD5XZbwu9Fqgvmxpm/vtqhUIxLlJtpcQ/6scFbuVyTfmK xlVBWCOEgTDE13Vk3Y8dop/27lDnHR7du2soBGzDPbvVqu2yRJkOUmd8CXYQEjph405rZ9mpVQx sVqKpUUdMqLNlo6A== X-Received: by 2002:ac8:5949:0:b0:50d:714d:e966 with SMTP id d75a77b69052e-50dd57f6e28mr167151571cf.0.1776156411817; Tue, 14 Apr 2026 01:46:51 -0700 (PDT) X-Received: by 2002:ac8:5949:0:b0:50d:714d:e966 with SMTP id d75a77b69052e-50dd57f6e28mr167151341cf.0.1776156411332; Tue, 14 Apr 2026 01:46:51 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e7c8a4fsm369699366b.54.2026.04.14.01.46.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 01:46:50 -0700 (PDT) Message-ID: Date: Tue, 14 Apr 2026 10:46:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM To: Ajay Kumar Nandam , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@oss.qualcomm.com References: <20260413121824.375473-1-ajay.nandam@oss.qualcomm.com> <20260413121824.375473-2-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260413121824.375473-2-ajay.nandam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: P3rGW3KPxvJyDSKSU8VYKhBS3Y7KoTvs X-Proofpoint-GUID: P3rGW3KPxvJyDSKSU8VYKhBS3Y7KoTvs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA4MSBTYWx0ZWRfX5aGgGFqR1J3j A8fejmG3O7njpDka4YydkywtNGpSOU2WTBG8AN2YNhmaLLvqURFlvOMQLFN93KrtHHrAej+r5dt Qbqpz4is5RDuQC2H0exlLHCn/seM6/upMuVF5Xt+J4tJNwlF3jqFjK7iBuvXCH8lBVbp1ItGPcL MLZ0UTMCD9JzWXn8sc2wsDhVIWPACL3f3Vdz7MALzQmPf+IvULwxdwNifsZ2T8Ztc5EGPVzb5OT Tn+OCI6+2J2U83yMelB6FX3/OFaIGRiU7w1MzdYMi/JZNzzaGZQ+esSw7UZ9dNusKSuWubFePWN J8aiC73u7J+Xk971a32lAsowZWvakD2oS+H3G5mjp3Y7MIdcuAt/nQFKGR0MRInoVWblc9YjVeT jn82spGKfZ1T1TDb6tbN9FRLsjX6eD2kHiRkTg9h/BI8EnOy2XAwcpNWzuaERvHlCHlr+YSkQsL 5Yn5fQccYX06tGlA5NA== X-Authority-Analysis: v=2.4 cv=etzvCIpX c=1 sm=1 tr=0 ts=69ddfefc cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=weikHDwYOGaAN1ZrU1wA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140081 On 4/13/26 2:18 PM, Ajay Kumar Nandam wrote: > Convert the LPASS WSA macro codec driver to use the PM clock framework > for runtime power management. > > The driver now relies on pm_clk helpers and runtime PM instead of > manually enabling and disabling macro, dcodec, mclk, npl, and fsgen > clocks. Runtime suspend and resume handling is delegated to the PM > core via pm_clk_suspend() and pm_clk_resume(), while existing runtime > PM callbacks continue to manage regcache state. > > This ensures clocks are enabled only when the WSA macro is active, > improves power efficiency on LPASS platforms supporting LPI/island > modes, and aligns the driver with common ASoC runtime PM patterns used > across Qualcomm LPASS codec drivers. > > Signed-off-by: Ajay Kumar Nandam > --- [...] > + pm_runtime_set_autosuspend_delay(dev, 3000); FWIW I have mostly the same comments as on your other series Notably, msm-5.10 uses 50 ms of autosuspend delay for the macros (100 for VA for $reasons) Konrad