mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: X86 ML <x86@kernel.org>, linux-kernel@vger.kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>, Willy Tarreau <w@1wt.eu>,
	Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Lutomirski <luto@kernel.org>
Subject: [PATCH 1/5] x86/entry/32: Clean up enable_sep_cpu to prepare for 64-bit merge
Date: Thu, 23 Jul 2015 08:31:39 -0700	[thread overview]
Message-ID: <dd0e00a1ca7f2a1396f6fb16abe1690c4bb748bd.1437665045.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1437665045.git.luto@kernel.org>
In-Reply-To: <cover.1437665045.git.luto@kernel.org>

Switch from wrmsr to wrmsrl_safe to prepare to merge the 32-bit and
64-bit code, and use __KERNEL_CS explicitly to initialize
MSR_IA32_SYSENTER_CS.  While we're at it, tweak the whitespace a
bit.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 arch/x86/kernel/cpu/common.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 922c5e0cea4c..9b3a43583f81 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -1001,15 +1001,13 @@ void enable_sep_cpu(void)
 	 * We cache MSR_IA32_SYSENTER_CS's value in the TSS's ss1 field --
 	 * see the big comment in struct x86_hw_tss's definition.
 	 */
-
 	tss->x86_tss.ss1 = __KERNEL_CS;
-	wrmsr(MSR_IA32_SYSENTER_CS, tss->x86_tss.ss1, 0);
-
-	wrmsr(MSR_IA32_SYSENTER_ESP,
-	      (unsigned long)tss + offsetofend(struct tss_struct, SYSENTER_stack),
-	      0);
 
-	wrmsr(MSR_IA32_SYSENTER_EIP, (unsigned long)entry_SYSENTER_32, 0);
+	wrmsrl_safe(MSR_IA32_SYSENTER_CS, __KERNEL_CS);
+	wrmsrl_safe(MSR_IA32_SYSENTER_ESP,
+		    (unsigned long)tss +
+		    offsetofend(struct tss_struct, SYSENTER_stack));
+	wrmsrl_safe(MSR_IA32_SYSENTER_EIP, (unsigned long)entry_SYSENTER_32);
 
 out:
 	put_cpu();
-- 
2.4.3


  reply	other threads:[~2015-07-23 15:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 15:31 [PATCH 0/5] x86: Unify SYSENTER setup and add a 64-bit SYSENTER stack Andy Lutomirski
2015-07-23 15:31 ` Andy Lutomirski [this message]
2015-07-23 15:56   ` [PATCH 1/5] x86/entry/32: Clean up enable_sep_cpu to prepare for 64-bit merge Steven Rostedt
2015-07-23 16:02     ` Andy Lutomirski
2015-07-23 17:27       ` Brian Gerst
2015-07-23 18:01         ` Andy Lutomirski
2015-07-23 18:33           ` Andy Lutomirski
2015-07-23 18:42             ` Andy Lutomirski
2015-07-23 18:50               ` Linus Torvalds
2015-07-23 15:31 ` [PATCH 2/5] x86/entry/64, entry: Set up a valid sysenter stack and prepare for 32-bit merge Andy Lutomirski
2015-07-23 16:01   ` Steven Rostedt
2015-07-23 16:04     ` Andy Lutomirski
2015-07-23 16:10       ` Steven Rostedt
2015-07-23 16:46         ` Andy Lutomirski
2015-07-23 16:59           ` Steven Rostedt
2015-07-23 15:31 ` [PATCH 3/5] x86/entry: Merge 32-bit and 64-bit sysenter setup code Andy Lutomirski
2015-07-23 16:06   ` Steven Rostedt
2015-07-23 16:45     ` Andy Lutomirski
2015-07-23 15:31 ` [PATCH 4/5] x86/entry: Only allocate space for SYSENTER_stack if needed Andy Lutomirski
2015-07-23 15:31 ` [PATCH 5/5] x86/entry: Replace SWAPGS_UNSAFE_STACK with SWAPGS in entry_SYSENTER_compat Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd0e00a1ca7f2a1396f6fb16abe1690c4bb748bd.1437665045.git.luto@kernel.org \
    --to=luto@kernel.org \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=w@1wt.eu \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome